From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44BB8C77B70 for ; Thu, 6 Apr 2023 14:07:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238992AbjDFOH3 (ORCPT ); Thu, 6 Apr 2023 10:07:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239030AbjDFOG7 (ORCPT ); Thu, 6 Apr 2023 10:06:59 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E86B1AF13; Thu, 6 Apr 2023 07:06:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=G4nuJcd5AfkMWWoRDvdvNvpxfbVN9zYnFiB5IonV9R4=; b=ZPPa0C0aUl2YsTOMEmCxixeqeA AWpQbKdrF/xvgjzQ+8tx1cMnnTqG2ifwZHpRyiWpp7VcxtHepPNTze3lhfhN2nNp6dhCTdjQn68fV 3M8H4pGqYxv77IZ3MolD8ce/ZTdLuzJGQ+kU7x2WE8bNZe8rROnAT9qYVSh3MlDW/13Q=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1pkQFg-009dNo-K7; Thu, 06 Apr 2023 16:06:12 +0200 Date: Thu, 6 Apr 2023 16:06:12 +0200 From: Andrew Lunn To: Ivan Bornyakov Cc: netdev@vger.kernel.org, linux@armlinux.org.uk, hkallweit1@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-kernel@vger.kernel.org, system@metrotek.ru Subject: Re: [PATCH net v2 2/2] net: sfp: avoid EEPROM read of absent SFP module Message-ID: References: <20230406130833.32160-1-i.bornyakov@metrotek.ru> <20230406130833.32160-3-i.bornyakov@metrotek.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230406130833.32160-3-i.bornyakov@metrotek.ru> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 06, 2023 at 04:08:33PM +0300, Ivan Bornyakov wrote: > If SFP module is not present, it is sensible to fail sfp_module_eeprom() > and sfp_module_eeprom_by_page() early to avoid excessive I2C transfers > which are garanteed to fail. > > Suggested-by: Andrew Lunn > Signed-off-by: Ivan Bornyakov Reviewed-by: Andrew Lunn Andrew