From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BCA2EB64D9 for ; Thu, 15 Jun 2023 14:58:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343986AbjFOO6l (ORCPT ); Thu, 15 Jun 2023 10:58:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40196 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241059AbjFOO63 (ORCPT ); Thu, 15 Jun 2023 10:58:29 -0400 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CAAE31FFA for ; Thu, 15 Jun 2023 07:58:27 -0700 (PDT) Received: by mail-lf1-x131.google.com with SMTP id 2adb3069b0e04-4f849605df4so257437e87.3 for ; Thu, 15 Jun 2023 07:58:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686841106; x=1689433106; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VJ9ynKBRnWmDpkb98fhevLev870/kjy50alhP9fsq/8=; b=udcHcbZhpLbzXdMvbpPKX5Xp/FN3Xvs0oSAAUSCa2El4Qhrn+BjtGT2QR8ZcoxpiPg CCXBtdCXmjtYVBLJ4D7qNJw3fCo6NUf4ojRq0On6vOwYScaUKstfoP7VILA2zESIREiA UAeGY1/bNizxXNmwVF2sL2Mz9+sKB/wmlkvdodoKSeXDqM8PIdYE8LM+u23G9hhsqCuW 8TOXU3qfGdQFuQxpF0iM3f5rVil5G2dIsq/T6cZ/F0+NTce22V6tKNXg79ew6SqMzPzQ NjGLu5L6H3JrbgoEQg1KQQ09yjrZvigU6pdTzF19nMDqW7jldtLzQD3AUTcvUgv4QbZr 9anA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686841106; x=1689433106; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VJ9ynKBRnWmDpkb98fhevLev870/kjy50alhP9fsq/8=; b=C8XB1lJGa6DybASiQ6tjquirkMXaW40QocCy+P6xab26ApF4q4GTc6As7vpq52nmPV /uMKrE9jHmQRwAn0wYMX/NFHP18fWGXPmOCJDwqy895u6Mp9QS+NcdDVFqv/XNLfjWbY 3fjDB5dwtour8mnGSAkl6EySeQSPatqnTuKw5m8g7uCCfG8AoLdKQsjaicSWxg7BUm8C xau3rdWVhtAwaPtjijro258JNZl6XWGVborbGORX29r8WkprJ6YYkPbi6V+zS1IZiCV1 Kj3i8sAvIDyR75twahBzXfsc046G7nMg4nhVMH+YJBhApPYPo8BoZsCGOvsTllDNsYjV RbNg== X-Gm-Message-State: AC+VfDwIrKuhX+wNRHGdHX/JFxNiU/f+cyHPGls+S3uyb9caxI4jQBrC aCcQPLgE6XWqNszi0fmSHtvLpg== X-Google-Smtp-Source: ACHHUZ5QvTrGP83jsEwEryF0zv/zZgROBqTbmaovAyshVnwrrjiq7pHgtoBXpUXCvBYRem+liKUVAw== X-Received: by 2002:a19:da01:0:b0:4f6:198d:2afc with SMTP id r1-20020a19da01000000b004f6198d2afcmr5638158lfg.37.1686841106003; Thu, 15 Jun 2023 07:58:26 -0700 (PDT) Received: from [192.168.1.101] (abyj190.neoplus.adsl.tpnet.pl. [83.9.29.190]) by smtp.gmail.com with ESMTPSA id t12-20020ac2548c000000b004eb4074f40fsm2596751lfk.241.2023.06.15.07.58.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Jun 2023 07:58:25 -0700 (PDT) Message-ID: Date: Thu, 15 Jun 2023 16:58:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH V2 1/2] arm64: dts: qcom: ipq5332: enable GPIO based LEDs and Buttons Content-Language: en-US To: Sridharan S N , agross@kernel.org, andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230615145311.2776-1-quic_sridsn@quicinc.com> <20230615145311.2776-2-quic_sridsn@quicinc.com> From: Konrad Dybcio In-Reply-To: <20230615145311.2776-2-quic_sridsn@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15.06.2023 16:53, Sridharan S N wrote: > Add support for wlan-2g LED on GPIO 36 and wps buttons on GPIO 35. > > Signed-off-by: Sridharan S N > --- This patch references a file that does not exist in -next and does not state any dependency on other patches. With the hundreds of emails flowing in daily, it's impossible to keep track of it. For the patch contents, lgtm. Konrad > Changes in V2: > - Updated commit message > > .../boot/dts/qcom/ipq5332-rdp-common.dtsi | 39 +++++++++++++++++++ > 1 file changed, 39 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/ipq5332-rdp-common.dtsi b/arch/arm64/boot/dts/qcom/ipq5332-rdp-common.dtsi > index 97dc0e5c15f0..a8671a4ac2e4 100644 > --- a/arch/arm64/boot/dts/qcom/ipq5332-rdp-common.dtsi > +++ b/arch/arm64/boot/dts/qcom/ipq5332-rdp-common.dtsi > @@ -19,6 +19,31 @@ > chosen { > stdout-path = "serial0"; > }; > + > + gpio-keys { > + compatible = "gpio-keys"; > + pinctrl-0 = <&gpio_keys_default>; > + pinctrl-names = "default"; > + > + button-wps { > + label = "wps"; > + linux,code = ; > + gpios = <&tlmm 35 GPIO_ACTIVE_LOW>; > + debounce-interval = <60>; > + }; > + }; > + > + leds { > + compatible = "gpio-leds"; > + pinctrl-0 = <&gpio_leds_default>; > + pinctrl-names = "default"; > + > + led-0 { > + gpios = <&tlmm 36 GPIO_ACTIVE_HIGH>; > + linux,default-trigger = "phy0tx"; > + default-state = "off"; > + }; > + }; > }; > > &blsp1_i2c1 { > @@ -52,6 +77,20 @@ > /* PINCTRL */ > > &tlmm { > + gpio_keys_default: gpio-keys-default-state { > + pins = "gpio35"; > + function = "gpio"; > + drive-strength = <8>; > + bias-pull-up; > + }; > + > + gpio_leds_default: gpio-leds-default-state { > + pins = "gpio36"; > + function = "gpio"; > + drive-strength = <8>; > + bias-pull-down; > + }; > + > i2c_1_pins: i2c-1-state { > pins = "gpio29", "gpio30"; > function = "blsp1_i2c0";