From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D021C433EF for ; Mon, 1 Nov 2021 09:36:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6474F610F7 for ; Mon, 1 Nov 2021 09:36:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232905AbhKAJjR (ORCPT ); Mon, 1 Nov 2021 05:39:17 -0400 Received: from foss.arm.com ([217.140.110.172]:36112 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232976AbhKAJgq (ORCPT ); Mon, 1 Nov 2021 05:36:46 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3B83D101E; Mon, 1 Nov 2021 02:34:12 -0700 (PDT) Received: from [192.168.4.86] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 42D553F719; Mon, 1 Nov 2021 02:34:10 -0700 (PDT) Subject: Re: [PATCH] [RFC] arm64: export this_cpu_has_cap To: Will Deacon , Catalin Marinas Cc: Arnd Bergmann , Mathieu Poirier , Anshuman Khandual , Arnd Bergmann , Marc Zyngier , Mark Rutland , David Brazdil , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman References: <20211029113023.760421-1-arnd@kernel.org> <9d4e09b4-47dc-ed3c-2b6d-e0d1a081e592@arm.com> <20211101090143.GA27181@willie-the-truck> From: Suzuki K Poulose Message-ID: Date: Mon, 1 Nov 2021 09:34:08 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211101090143.GA27181@willie-the-truck> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Will On 01/11/2021 09:01, Will Deacon wrote: > On Fri, Oct 29, 2021 at 07:06:23PM +0100, Catalin Marinas wrote: >> On Fri, Oct 29, 2021 at 02:31:23PM +0100, Suzuki K Poulose wrote: >>> On 29/10/2021 12:30, Arnd Bergmann wrote: >>>> From: Arnd Bergmann >>>> >>>> It's now used in a coresight driver that can be a loadable module: >>>> >>>> ERROR: modpost: "this_cpu_has_cap" [drivers/hwtracing/coresight/coresight-trbe.ko] undefined! >>>> >>>> Fixes: 8a1065127d95 ("coresight: trbe: Add infrastructure for Errata handling") >>> >>> Reviewed-by: Suzuki K Poulose >>> Tested-by: Suzuki K Poulose >>> >>> Will, Catalin, Mathieu, >>> >>> Do you have a preference on how this fix can be pulled in ? This may >>> be safe to go via coresight tree if it is not too late. Otherwise, >>> it could go via the arm64 tree. >> >> I think Will already closed/tagged the arm64 tree for the upcoming >> merging window, though he could take it as a fix afterwards. >> >> If it doesn't conflict with the arm64 for-next/core, it's fine by me to >> go through the coresight tree. >> >>>> Signed-off-by: Arnd Bergmann >>>> --- >>>> Not sure if we actually want this to be exported, this is my local >>>> workaround for the randconfig build bot. >>>> --- >>>> arch/arm64/kernel/cpufeature.c | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c >>>> index ecbdff795f5e..beccbcfa7391 100644 >>>> --- a/arch/arm64/kernel/cpufeature.c >>>> +++ b/arch/arm64/kernel/cpufeature.c >>>> @@ -2864,6 +2864,7 @@ bool this_cpu_has_cap(unsigned int n) >>>> return false; >>>> } >>>> +EXPORT_SYMBOL(this_cpu_has_cap); >> >> EXPORT_SYMBOL_GPL? I think this_cpu_has_cap() is a bit more more >> specialised than cpus_have_const_cap(). >> >> With that: >> >> Acked-by: Catalin Marinas > > Yes, at this stage I think it's best for this to go via the Coresight tree. > So with the _GPL export: > > Acked-by: Will Deacon > > If that doesn't work for some reason, I can take it next week after the > initial arm64 queue has been merged. Please just let me know. As I understand correctly, this will now need to go via arm64 tree. The CoreSight tree changes are pulled into Greg's tree and the next it will happen is for the next release. Usually the fixes don't end up there during the -rc cycles. So, I believe it is better if this goes via arm64. Suzuki