From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26F46C433E0 for ; Fri, 19 Mar 2021 04:58:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EBEED64F53 for ; Fri, 19 Mar 2021 04:58:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233777AbhCSE5z (ORCPT ); Fri, 19 Mar 2021 00:57:55 -0400 Received: from mga14.intel.com ([192.55.52.115]:51209 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233743AbhCSE5V (ORCPT ); Fri, 19 Mar 2021 00:57:21 -0400 IronPort-SDR: wZSnQmT6vr012cPpKEXU8eND0R4ASXHu4ggBbwvoreCtlsA3VRllfxmPEtOfRoehMKL30I/urt eY1ffqi661sg== X-IronPort-AV: E=McAfee;i="6000,8403,9927"; a="189205800" X-IronPort-AV: E=Sophos;i="5.81,259,1610438400"; d="scan'208";a="189205800" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Mar 2021 21:57:20 -0700 IronPort-SDR: gqbUnVdsks8bVbgCUK4uiSDeHHRHXd8arwFrRI3rUsmqLHd+yd1ztIrYYGgQcBm9uEfYVVH/jZ XHySkAYbQalw== X-IronPort-AV: E=Sophos;i="5.81,259,1610438400"; d="scan'208";a="406643616" Received: from yjin15-mobl1.ccr.corp.intel.com (HELO [10.238.4.6]) ([10.238.4.6]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Mar 2021 21:57:18 -0700 Subject: Re: [PATCH v2] perf stat: Align CSV output for summary mode To: Arnaldo Carvalho de Melo , Andi Kleen Cc: jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, kan.liang@intel.com, yao.jin@intel.com References: <20210317070205.10315-1-yao.jin@linux.intel.com> <20210317215142.GB1369306@tassilo.jf.intel.com> From: "Jin, Yao" Message-ID: Date: Fri, 19 Mar 2021 12:57:16 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnaldo, On 3/18/2021 9:15 PM, Arnaldo Carvalho de Melo wrote: > Em Wed, Mar 17, 2021 at 02:51:42PM -0700, Andi Kleen escreveu: >>> If you care about not breaking existing scripts, then the output they >>> get with what they use as command line options must continue to produce >>> the same output. >> >> It's not clear there are any useful ones (except for tools that handle >> both). It's really hard to parse the previous mess. It's simply not >> valid CSV. >> >> That's why I'm arguing that keeping compatibility is not useful here. >> >> We would be stuck with the broken mess as default forever. > > Fair enough, lets fix the default then. Jin, can you please consider > adding a 'perf test' shell entry to parse the CSV mode with/without that > summary? This way we'll notice when the new normal gets broken. > > - Arnaldo > Thanks Arnaldo! I will post v3 with the perf test script. Thanks Jin Yao