From: Andrew Shadura <andrew.shadura@collabora.co.uk>
To: Peter Senna Tschudin <peter.senna@gmail.com>,
linux-api@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: shuahkh@osg.samsung.com, mpe@ellerman.id.au, sam.bobroff@au1.ibm.com
Subject: Re: tools-powerpc: Return false instead of -1
Date: Fri, 2 Sep 2016 11:54:13 +0200 [thread overview]
Message-ID: <dbaeea41-e3a6-0469-1e3a-bfda59eb4c46@collabora.co.uk> (raw)
In-Reply-To: <1442487801-22661-1-git-send-email-peter.senna@gmail.com>
On 17/09/15 13:03, Peter Senna Tschudin wrote:
> Returning a negative value for a boolean function seem to have the
> undesired effect of returning true. require_paranoia_below() is a
> boolean function, but the variable used to store the return value is an
> integer, receiving -1 or 0. This patch convert rc to bool, replace -1
> by false, and 0 by true.
The issue still seems to be not fixed.
--
Cheers,
Andrew
prev parent reply other threads:[~2016-09-02 9:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-17 11:03 [PATCH] " Peter Senna Tschudin
2016-09-02 9:54 ` Andrew Shadura [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbaeea41-e3a6-0469-1e3a-bfda59eb4c46@collabora.co.uk \
--to=andrew.shadura@collabora.co.uk \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=peter.senna@gmail.com \
--cc=sam.bobroff@au1.ibm.com \
--cc=shuahkh@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®