From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C452CC4332F for ; Tue, 18 Oct 2022 01:22:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230190AbiJRBWs (ORCPT ); Mon, 17 Oct 2022 21:22:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230094AbiJRBWq (ORCPT ); Mon, 17 Oct 2022 21:22:46 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22F2A13F8E for ; Mon, 17 Oct 2022 18:22:45 -0700 (PDT) Received: from dggpemm500022.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Mrx1T3RLvzHvHJ for ; Tue, 18 Oct 2022 09:22:37 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggpemm500022.china.huawei.com (7.185.36.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 18 Oct 2022 09:22:39 +0800 Received: from [10.67.111.195] (10.67.111.195) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 18 Oct 2022 09:22:38 +0800 Message-ID: Date: Tue, 18 Oct 2022 09:22:38 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH -next] genirq: Add SPARSE_NR_IRQS Kconfig option To: , References: <20220930085839.315461-1-chenlifu@huawei.com> From: chenlifu In-Reply-To: <20220930085839.315461-1-chenlifu@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.111.195] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2022/9/30 16:58, Chen Lifu 写道: > On a large-scale multi-core and NUMA platform, more than 1024 cores and > 16 NUMA nodes for example, even if SPASE_IRQ is selected to increase the > number of interrupt numbers by 8196 base on NR_IRQS, the interrupt numbers > requirement cannot be met. Therefore, make the number of sparse interrupt > numbers configurable. > > Signed-off-by: Chen Lifu > --- > kernel/irq/Kconfig | 8 ++++++++ > kernel/irq/internals.h | 2 +- > 2 files changed, 9 insertions(+), 1 deletion(-) > > diff --git a/kernel/irq/Kconfig b/kernel/irq/Kconfig > index db3d174c53d4..b517b820e329 100644 > --- a/kernel/irq/Kconfig > +++ b/kernel/irq/Kconfig > @@ -123,10 +123,18 @@ config SPARSE_IRQ > ( Sparse irqs can also be beneficial on NUMA boxes, as they spread > out the interrupt descriptors in a more NUMA-friendly way. ) > > If you don't know what to do here, say N. > > +config SPARSE_NR_IRQS > + int "Number of sparse interrupt numbers" > + depends on SPARSE_IRQ > + default 8196 > + help > + This defines the maximum number of interrupt numbers > + that can be dynamically expanded. > + > config GENERIC_IRQ_DEBUGFS > bool "Expose irq internals in debugfs" > depends on DEBUG_FS > select GENERIC_IRQ_INJECTION > default n > diff --git a/kernel/irq/internals.h b/kernel/irq/internals.h > index f09c60393e55..ab8ac93c60e6 100644 > --- a/kernel/irq/internals.h > +++ b/kernel/irq/internals.h > @@ -10,11 +10,11 @@ > #include > #include > #include > > #ifdef CONFIG_SPARSE_IRQ > -# define IRQ_BITMAP_BITS (NR_IRQS + 8196) > +# define IRQ_BITMAP_BITS (NR_IRQS + CONFIG_SPARSE_NR_IRQS) > #else > # define IRQ_BITMAP_BITS NR_IRQS > #endif > > #define istate core_internal_state__do_not_mess_with_it Friendly ping ...