From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753355AbdBAWIU (ORCPT ); Wed, 1 Feb 2017 17:08:20 -0500 Received: from mail-pf0-f196.google.com ([209.85.192.196]:36440 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751130AbdBAWIS (ORCPT ); Wed, 1 Feb 2017 17:08:18 -0500 Subject: Re: [PATCH v2 2/4] net: phy: Initialize mdio clock at probe function To: Yendapally Reddy Dhananjaya Reddy , Rob Herring , Mark Rutland , Russell King , Ray Jui , Scott Branden , Jon Mason , Florian Fainelli , Kishon Vijay Abraham I References: <1484669670-4201-1-git-send-email-yendapally.reddy@broadcom.com> <1484669670-4201-3-git-send-email-yendapally.reddy@broadcom.com> Cc: bcm-kernel-feedback-list@broadcom.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, David Miller From: Florian Fainelli Message-ID: Date: Wed, 1 Feb 2017 14:08:14 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1484669670-4201-3-git-send-email-yendapally.reddy@broadcom.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/17/2017 08:14 AM, Yendapally Reddy Dhananjaya Reddy wrote: > Initialize mdio clock divisor in probe function. The ext bus > bit available in the same register will be used by mdio mux > to enable external mdio. > > Signed-off-by: Yendapally Reddy Dhananjaya Reddy David, this patch should go through your tree (but we forgot to CC you), patch in patchwork is here: http://patchwork.ozlabs.org/patch/716281/ Thanks! > --- > drivers/net/phy/mdio-bcm-iproc.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/phy/mdio-bcm-iproc.c b/drivers/net/phy/mdio-bcm-iproc.c > index c0b4e65..46fe1ae 100644 > --- a/drivers/net/phy/mdio-bcm-iproc.c > +++ b/drivers/net/phy/mdio-bcm-iproc.c > @@ -81,8 +81,6 @@ static int iproc_mdio_read(struct mii_bus *bus, int phy_id, int reg) > if (rc) > return rc; > > - iproc_mdio_config_clk(priv->base); > - > /* Prepare the read operation */ > cmd = (MII_DATA_TA_VAL << MII_DATA_TA_SHIFT) | > (reg << MII_DATA_RA_SHIFT) | > @@ -112,8 +110,6 @@ static int iproc_mdio_write(struct mii_bus *bus, int phy_id, > if (rc) > return rc; > > - iproc_mdio_config_clk(priv->base); > - > /* Prepare the write operation */ > cmd = (MII_DATA_TA_VAL << MII_DATA_TA_SHIFT) | > (reg << MII_DATA_RA_SHIFT) | > @@ -163,6 +159,8 @@ static int iproc_mdio_probe(struct platform_device *pdev) > bus->read = iproc_mdio_read; > bus->write = iproc_mdio_write; > > + iproc_mdio_config_clk(priv->base); > + > rc = of_mdiobus_register(bus, pdev->dev.of_node); > if (rc) { > dev_err(&pdev->dev, "MDIO bus registration failed\n"); > -- Florian