From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: "Wells Lu 呂芳騰" <wells.lu@sunplus.com>,
"andy.shevchenko@gmail.com" <andy.shevchenko@gmail.com>,
"Dan Carpenter" <dan.carpenter@linaro.org>
Cc: Wells Lu <wellslutw@gmail.com>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Kernel Janitors <kernel-janitors@vger.kernel.org>
Subject: Re: RE: [PATCH] pinctrl:sunplus: Add check for kmalloc
Date: Thu, 25 May 2023 20:37:36 +0200 [thread overview]
Message-ID: <dbb3c0bd-3b09-2b59-8cd1-2838b9880abf@wanadoo.fr> (raw)
In-Reply-To: <dd0ea27640d2420eb3b521076c643919@sphcmbx02.sunplus.com.tw>
Le 25/05/2023 à 05:22, Wells Lu 呂芳騰 a écrit :
>> Le 23/05/2023 à 21:37, andy.shevchenko@gmail.com a écrit :
>>> Tue, May 23, 2023 at 05:39:51PM +0000, Wells Lu 呂芳騰 kirjoitti:
>>>>>> Fix Smatch static checker warning:
>>>>>> potential null dereference 'configs'. (kmalloc returns null)
>>>
>>> ...
>>>
>>>>>> configs = kmalloc(sizeof(*configs), GFP_KERNEL);
>>>>>> + if (!configs)
>>>>>
>>>>>> + return -ENOMEM;
>>>>>
>>>>> "Fixing" by adding a memory leak is not probably a good approach.
>>>>
>>>> Do you mean I need to free all memory which are allocated in this
>>>> subroutine before return -ENOMEM?
>>>
>>> This is my understanding of the code. But as I said... (see below)
>>>
>>> ...
>>>
>>>>>> configs = kmalloc(sizeof(*configs), GFP_KERNEL);
>>>>>> + if (!configs)
>>>>>> + return -ENOMEM;
>>>>>
>>>>> Ditto.
>>>
>>> ...
>>>
>>>>> It might be that I'm mistaken. In this case please add an
>>>>> explanation why in the commit message.
>>>
>>> ^^^
>>>
>>
>> Hmmm, not so sure.
>>
>> Should be looked at more carefully, but
>> dt_to_map_one_config (in /drivers/pinctrl/devicetree.c)
>> .dt_node_to_map
>> --> sppctl_dt_node_to_map
>>
>> Should dt_to_map_one_config() fail, pinctrl_dt_free_maps() is called (see
>> https://elixir.bootlin.com/linux/v6.4-rc1/source/drivers/pinctrl/devicetree.c#L281)
>>
>> pinctrl_dt_free_maps() calls dt_free_map(), which calls .dt_free_map, so
>> pinctrl_utils_free_map()
>> (see
>> https://elixir.bootlin.com/linux/v6.4-rc1/source/drivers/pinctrl/sunplus/sppctl.c#L97
>> 8)
>>
>> Finally the needed kfree seem to be called from here.
>> (see
>> https://elixir.bootlin.com/linux/v6.4-rc1/source/drivers/pinctrl/pinctrl-utils.c#L119
>> )
>>
>>
>> *This should obviously be double checked*, but looks safe to me.
>>
>>
>> BUT, in the same function, the of_get_parent() should be undone in case
>> of error, as done at the end of the function, in the normal path.
>> This one seems to be missing, should a memory allocation error occur.
>>
>>
>> Just my 2c,
>>
>> CJ
>
> Thank you for your comments.
>
> From the report of kmemleak, returning -ENOMEM directly causes memory leak. We
> need to free any memory allocated in this subroutine before returning -ENOMEM.
>
> I'll send a new patch that will free the allocated memory and call of_node_put()
> when an error happens.
Hi,
(adding Dan in copy because the initial report is related to smatch)
I don't use kmemleak, but could you share some input about its report?
I've not rechecked my analysis, but it looked promising.
Maybe Dan could also give a look at it and confirm your finding, or dig
further with smatch to make sure that its static analysis was complete
enough.
CJ
>
>
> Best regards,
> Wells Lu
next prev parent reply other threads:[~2023-05-25 20:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 10:11 Wells Lu
2023-05-23 16:42 ` andy.shevchenko
2023-05-23 17:39 ` Wells Lu 呂芳騰
2023-05-23 19:37 ` andy.shevchenko
2023-05-23 20:05 ` Christophe JAILLET
2023-05-25 3:22 ` Wells Lu 呂芳騰
2023-05-25 18:37 ` Christophe JAILLET [this message]
2023-05-25 19:42 ` Dan Carpenter
2023-05-26 2:04 ` Wells Lu 呂芳騰
2023-05-26 5:19 ` Christophe JAILLET
2023-05-25 19:19 ` Dan Carpenter
2023-05-25 20:00 ` Christophe JAILLET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbb3c0bd-3b09-2b59-8cd1-2838b9880abf@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=andy.shevchenko@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wells.lu@sunplus.com \
--cc=wellslutw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®