From: "Arnd Bergmann" <arnd@arndb.de>
To: "Tzu-Ching Yang" <shingekinocore@gmail.com>,
"Yury Norov" <yury.norov@gmail.com>
Cc: "Rasmus Villemoes" <linux@rasmusvillemoes.dk>,
Linux-Arch <linux-arch@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bitops: Share the generic ffs()/fls() binary search via UNROLL()
Date: Fri, 16 Oct 2026 09:16:37 +0200 [thread overview]
Message-ID: <dbb44e92-0bc5-449d-9e43-1f93362aa6c3@app.fastmail.com> (raw)
In-Reply-To: <7eb58dd0-99f9-45aa-bdf4-9707a0c9e1b4@app.fastmail.com>
On Fri, Oct 16, 2026, at 07:54, Arnd Bergmann wrote:
>
> I don't understand what you are trying to do here, but I don't
> think we want this change: I find the nested macros harder
> to read than the open-coded version and your changelog text
> fails to explain what the purpose is.
If you are interested in creating helpful patches in this area,
maybe you could work towards eliminating the generic versions
of these functions in favor of using the builtin ones on targets
where the compilers produce sensible code for them.
Arnd
next prev parent reply other threads:[~2026-10-16 7:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-16 2:56 Tzu-Ching Yang
2026-10-16 5:54 ` Arnd Bergmann
2026-10-16 7:16 ` Arnd Bergmann [this message]
2026-10-16 13:53 ` Tzu-Ching Yang
2026-10-16 14:49 ` Arnd Bergmann
2026-10-16 16:17 ` Yury Norov
2026-10-16 16:35 ` Tzu-Ching Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbb44e92-0bc5-449d-9e43-1f93362aa6c3@app.fastmail.com \
--to=arnd@arndb.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=shingekinocore@gmail.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®