From: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>
To: Matthew Schwartz <matthew.schwartz@linux.dev>, broonie@kernel.org
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Oder Chiou <oder_chiou@realtek.com>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/5] ASoC: rt721-sdca: wait for PDEs to reach PS0 after powering them up
Date: Wed, 4 Nov 2026 12:44:16 +0100 [thread overview]
Message-ID: <dbbf4042-efd1-4465-a034-2932ebfc9d25@linux.dev> (raw)
In-Reply-To: <20261103200540.3863272-6-matthew.schwartz@linux.dev>
On 11/3/26 21:05, Matthew Schwartz wrote:
> The PDE event handlers write REQUESTED_PS and return, so DAPM unmutes
> the feature unit and the stream starts while the power domain is still
> transitioning. On the ASUS ROG Xbox Ally X20 the first headset mic
> capture after the capture path powers down starts with about 0.45 s
> pinned at full scale, and the DisCo tables give the jack function PDEs
> up to 500 ms to reach PS0.
>
> Poll ACTUAL_PS with sdca_asoc_pde_poll_actual_ps() after each power up,
> like rt722 does since its DMIC pop noise fix, and use the 500 ms maximum
> for the jack function PDEs. Power down is left alone because ACTUAL_PS
> can stay at PS0 while the data port is still running.
Sounds like the right thing to do
Reviewed-by: Pierre-Louis Bossart <pierre-louis bossart@linux.dev>
IIRC there was a good regmap-related reason why we split the write to
REQUESTED_PS, and the wait on ACTUAL_PS, but the net result is that some
folks don't wait...
prev parent reply other threads:[~2026-11-04 11:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 20:05 [PATCH v2 0/5] ASoC: support the ASUS ROG Xbox Ally X20 audio Matthew Schwartz
2026-11-03 20:05 ` [PATCH v2 1/5] ASoC: amd: acp-config: force SoundWire probe on ASUS RC74XA Matthew Schwartz
2026-11-03 20:05 ` [PATCH v2 2/5] ASoC: amd: acp: add ACP70 SoundWire machine entry for " Matthew Schwartz
2026-11-03 20:05 ` [PATCH v2 3/5] ASoC: tas2783-sdw: use the BIOS speaker ID in the firmware name Matthew Schwartz
2026-11-03 20:05 ` [PATCH v2 4/5] ASoC: sdw_utils: honor empty DisCo port lists when creating DAI links Matthew Schwartz
2026-11-04 3:01 ` Liao, Bard
2026-11-04 11:36 ` Pierre-Louis Bossart
2026-11-03 20:05 ` [PATCH v2 5/5] ASoC: rt721-sdca: wait for PDEs to reach PS0 after powering them up Matthew Schwartz
2026-11-04 11:44 ` Pierre-Louis Bossart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbbf4042-efd1-4465-a034-2932ebfc9d25@linux.dev \
--to=pierre-louis.bossart@linux.dev \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=matthew.schwartz@linux.dev \
--cc=oder_chiou@realtek.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®