From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08123C433E9 for ; Fri, 12 Mar 2021 18:06:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C4F1964F49 for ; Fri, 12 Mar 2021 18:06:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232509AbhCLSF6 (ORCPT ); Fri, 12 Mar 2021 13:05:58 -0500 Received: from foss.arm.com ([217.140.110.172]:58980 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232233AbhCLSF1 (ORCPT ); Fri, 12 Mar 2021 13:05:27 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6E625ED1; Fri, 12 Mar 2021 10:05:27 -0800 (PST) Received: from [10.57.17.106] (unknown [10.57.17.106]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2F7A43F7D7; Fri, 12 Mar 2021 10:05:25 -0800 (PST) Subject: Re: [PATCH v2 3/5] thermal/drivers/devfreq_cooling: Use device name instead of auto-numbering To: Daniel Lezcano Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Zhang Rui , Amit Kucheria References: <20210312170316.3138-1-daniel.lezcano@linaro.org> <20210312170316.3138-3-daniel.lezcano@linaro.org> From: Lukasz Luba Message-ID: Date: Fri, 12 Mar 2021 18:05:24 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20210312170316.3138-3-daniel.lezcano@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/12/21 5:03 PM, Daniel Lezcano wrote: > Currently the naming of a cooling device is just a cooling technique > followed by a number. When there are multiple cooling devices using > the same technique, it is impossible to clearly identify the related > device as this one is just a number. > > For instance: > > thermal-devfreq-0 > thermal-devfreq-1 > etc ... > > The 'thermal' prefix is redundant with the subsystem namespace. This > patch removes the 'thermal' prefix and changes the number by the device > name. So the naming above becomes: > > devfreq-5000000.gpu > devfreq-1d84000.ufshc > etc ... > > Signed-off-by: Daniel Lezcano > --- > V2: > - Removed idr.h header > - Used kasprintf instead of fixed buffer length on the stack > - Fixed typo in the log > --- > drivers/thermal/devfreq_cooling.c | 25 ++++++++----------------- > 1 file changed, 8 insertions(+), 17 deletions(-) > Reviewed-by: Lukasz Luba