From: Philipp Zabel <p.zabel@pengutronix.de>
To: Xia Yan <yanxia@cmss.chinamobile.com>,
Vinod Koul <vkoul@kernel.org>,
linux-phy@lists.infradead.org
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
Manivannan Sadhasivam <mani@kernel.org>,
Pengcheng Li <lpc.li@hisilicon.com>,
Jiancheng Xue <xuejiancheng@hisilicon.com>,
Shawn Guo <shawn.guo@linaro.org>, Shawn Guo <shawnguo@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
yana06070@163.com
Subject: Re: [PATCH] phy: hisilicon: fix UTMI reset leaks in INNO USB2 PHY
Date: Wed, 11 Nov 2026 10:15:43 +0100 [thread overview]
Message-ID: <dbc39e63b74e1df9dfb134b6100a8deb0ba6afcd.camel@pengutronix.de> (raw)
In-Reply-To: <20261111085942.159625-1-yanxia@cmss.chinamobile.com>
On Mi, 2026-11-11 at 16:59 +0800, Xia Yan wrote:
> hisi_inno_phy_probe() acquires an exclusive UTMI reset control for each
> child node but never releases it on probe failure or driver detach.
> The leaked controls remain acquired, so a later probe can fail with
> -EBUSY when requesting the same resets.
>
> Register a devres action after each successful lookup to release the
> control on probe failure and detach.
>
> Found during source review of reset-control lifetimes.
>
> Build-tested the driver object on x86_64 with W=1 and reset support
> enabled. No hardware testing.
>
> Fixes: ba8b0ee81fbb ("phy: add inno-usb2-phy driver for hi3798cv200 SoC")
> Cc: stable@vger.kernel.org # needs of_node_put(child) on <= 6.6
> Signed-off-by: Xia Yan <yanxia@cmss.chinamobile.com>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
It looks like an equivalent to devm_get_clk_from_child() for reset
controls could be useful.
regards
Philipp
prev parent reply other threads:[~2026-11-11 9:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 8:59 Xia Yan
2026-11-11 9:15 ` Philipp Zabel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbc39e63b74e1df9dfb134b6100a8deb0ba6afcd.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=kishon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=lpc.li@hisilicon.com \
--cc=mani@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=shawn.guo@linaro.org \
--cc=shawnguo@kernel.org \
--cc=stable@vger.kernel.org \
--cc=vkoul@kernel.org \
--cc=xuejiancheng@hisilicon.com \
--cc=yana06070@163.com \
--cc=yanxia@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®