From: "H. Peter Anvin" <hpa@zytor.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Joe Perches <joe@perches.com>, Ben Pfaff <blp@nicira.com>,
Christopher Li <sparse@chrisli.org>,
Josh Triplett <josh@joshtriplett.org>,
linux-sparse@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2] sparse: Allow override of sizeof(bool) warning
Date: Thu, 27 Feb 2014 07:10:25 -0800 [thread overview]
Message-ID: <dbc47544-a6f6-4ab4-80b0-25d93a1666e2@email.android.com> (raw)
In-Reply-To: <20140227082529.GA18210@pd.tnic>
Keep in mind, too, that for the kernel we don't care about the full C standard but a subset. We rely on extrastandard behavior all over the place. For all ABIs supported by the kernel, sizeof(_Book) == 1 and so everything is sane.
On February 27, 2014 12:25:29 AM PST, Borislav Petkov <bp@alien8.de> wrote:
>On Wed, Feb 26, 2014 at 07:42:37PM -0800, H. Peter Anvin wrote:
>> sizeof(_Bool), like for many other types, is ABI-dependent, but that
>> doesn't mean it is illegitimate.
>>
>> I don't think C99 says that it is invalid (which means C99 doesn't
>> permit is to be a packed bitmap.)
>
>Ok, but what can be said about the __pcpu_size_call() use case where we
>do sizeof(bool)? We have there accessors for sizes 1,2,4 and 8. Can we
>simply assume that the ABI will give us a size of bool which is one of
>those?
>
>What if sizeof(bool) is 3?
>
>Or, are we saying that sizeof(bool) will always be of some natural,
>native size like byte, short, int or long so we're good there?
>
>Thanks.
--
Sent from my mobile phone. Please pardon brevity and lack of formatting.
next prev parent reply other threads:[~2014-02-27 15:11 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-26 22:49 The sheer number of sparse warnings in the kernel H. Peter Anvin
2014-02-26 23:25 ` Borislav Petkov
2014-02-27 8:27 ` Richard Weinberger
2014-02-26 23:28 ` Greg KH
2014-02-26 23:29 ` Greg KH
2014-02-26 23:31 ` H. Peter Anvin
2014-02-26 23:37 ` H. Peter Anvin
2014-02-27 1:19 ` Josh Boyer
2014-02-27 1:21 ` H. Peter Anvin
2014-03-04 23:13 ` Valdis.Kletnieks
2014-02-27 0:11 ` H. Peter Anvin
2014-02-27 1:34 ` Greg KH
2014-02-27 2:09 ` Joe Perches
2014-02-27 3:15 ` Dave Jones
2014-02-27 4:32 ` Greg KH
2014-02-27 10:11 ` Guenter Roeck
2014-02-27 1:52 ` Peter Hurley
2014-02-27 4:19 ` H. Peter Anvin
2014-02-27 4:31 ` Greg KH
2014-02-27 9:22 ` Geert Uytterhoeven
2014-02-27 0:48 ` Joe Perches
2014-02-27 0:51 ` H. Peter Anvin
2014-02-27 1:06 ` Joe Perches
2014-02-27 1:33 ` [PATCH] err.h: Use bool for IS_ERR and IS_ERR_OR_NULL Joe Perches
2014-02-27 2:03 ` [PATCH] sparse: Allow override of sizeof(bool) warning Joe Perches
2014-02-27 2:08 ` [RFC PATCH] Makefile: sparse - don't check sizeof(bool) Joe Perches
2014-02-27 2:28 ` [PATCH] sparse: Allow override of sizeof(bool) warning Josh Triplett
2014-02-27 2:53 ` [PATCH V2] " Joe Perches
2014-02-27 2:58 ` Josh Triplett
2014-02-27 3:19 ` [PATCH V3] " Joe Perches
2014-02-27 3:29 ` [PATCH V2] " H. Peter Anvin
2014-02-27 3:38 ` Joe Perches
2014-02-27 3:42 ` H. Peter Anvin
2014-02-27 8:25 ` Borislav Petkov
2014-02-27 15:10 ` H. Peter Anvin [this message]
2014-02-27 15:24 ` Theodore Ts'o
2014-02-27 15:48 ` H. Peter Anvin
2014-02-27 16:01 ` Borislav Petkov
2014-02-27 16:10 ` Dan Carpenter
2014-02-27 16:52 ` H. Peter Anvin
2014-02-27 17:06 ` James Hogan
2014-02-27 4:00 ` Ben Pfaff
2014-02-27 4:19 ` H. Peter Anvin
2014-02-27 4:26 ` Ben Pfaff
2014-02-27 4:32 ` H. Peter Anvin
2014-02-27 20:22 ` Christopher Li
2014-02-27 20:26 ` H. Peter Anvin
2014-02-27 20:39 ` Joe Perches
2014-02-27 20:55 ` Christopher Li
2014-02-27 21:49 ` Joe Perches
2014-02-27 20:44 ` Christopher Li
2014-02-27 21:00 ` Joe Perches
2014-02-27 21:03 ` Christopher Li
2014-02-27 21:41 ` Christopher Li
2014-02-27 9:56 ` The sheer number of sparse warnings in the kernel Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbc47544-a6f6-4ab4-80b0-25d93a1666e2@email.android.com \
--to=hpa@zytor.com \
--cc=blp@nicira.com \
--cc=bp@alien8.de \
--cc=joe@perches.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sparse@vger.kernel.org \
--cc=sparse@chrisli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®