From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6F80C4167B for ; Mon, 4 Dec 2023 11:37:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232694AbjLDLhf (ORCPT ); Mon, 4 Dec 2023 06:37:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45704 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229711AbjLDLhd (ORCPT ); Mon, 4 Dec 2023 06:37:33 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 6B927E6; Mon, 4 Dec 2023 03:37:39 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 65BA0152B; Mon, 4 Dec 2023 03:38:26 -0800 (PST) Received: from [10.163.35.18] (unknown [10.163.35.18]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DCBD23F6C4; Mon, 4 Dec 2023 03:37:34 -0800 (PST) Message-ID: Date: Mon, 4 Dec 2023 17:07:30 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V2 1/7] coresight: replicator: Move ACPI support from AMBA driver to platform driver Content-Language: en-US To: James Clark , Sudeep Holla Cc: linux-arm-kernel@lists.infradead.org, Lorenzo Pieralisi , Mike Leach , Maxime Coquelin , Alexandre Torgue , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-stm32@st-md-mailman.stormreply.com References: <20231201062053.1268492-1-anshuman.khandual@arm.com> <20231201062053.1268492-2-anshuman.khandual@arm.com> <20231201123515.gntwvhsxd5nzojn7@bogus> <58882cab-89ce-4554-aee4-24e70d82fc09@arm.com> <2aec13e9-4ae3-676f-1ba8-c9e9a9241063@arm.com> From: Anshuman Khandual In-Reply-To: <2aec13e9-4ae3-676f-1ba8-c9e9a9241063@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/4/23 15:27, James Clark wrote: > > On 04/12/2023 04:48, Anshuman Khandual wrote: >> >> On 12/4/23 09:56, Anshuman Khandual wrote: >>> >>> On 12/1/23 18:05, Sudeep Holla wrote: >>>> On Fri, Dec 01, 2023 at 11:50:47AM +0530, Anshuman Khandual wrote: >>>>> Add support for the dynamic replicator device in the platform driver, which >>>>> can then be used on ACPI based platforms. This change would now allow >>>>> runtime power management for repliacator devices on ACPI based systems. >>>>> >>>>> The driver would try to enable the APB clock if available. Also, rename the >>>>> code to reflect the fact that it now handles both static and dynamic >>>>> replicators. >>>>> >>>>> Cc: Lorenzo Pieralisi >>>>> Cc: Sudeep Holla >>>> Except the minor nit below which may apply also for few other patches >>>> in the series >>>> >>>> Acked-by: Sudeep Holla # For ACPI related changes >>>> Tested-by: Sudeep Holla # Boot and driver probe only >>>> >>>> [...] >>>> >>>>> diff --git a/drivers/hwtracing/coresight/coresight-replicator.c b/drivers/hwtracing/coresight/coresight-replicator.c >>>>> index b6be73034996..64de0bee02ec 100644 >>>>> --- a/drivers/hwtracing/coresight/coresight-replicator.c >>>>> +++ b/drivers/hwtracing/coresight/coresight-replicator.c >>>>> @@ -38,6 +38,7 @@ DEFINE_CORESIGHT_DEVLIST(replicator_devs, "replicator"); >>>>> struct replicator_drvdata { >>>>> void __iomem *base; >>>>> struct clk *atclk; >>>>> + struct clk *pclk; >>>> [minor nit] Perhaps can be documented as well ? >>> Sure, will add the following comment above the structure. >>> >>> @pclk: optional clock for the core parts of the replicator. >> My bad, this will be the following instead. >> >> diff --git a/drivers/hwtracing/coresight/coresight-replicator.c b/drivers/hwtracing/coresight/coresight-replicator.c >> index 64de0bee02ec..44b9a77ec8aa 100644 >> --- a/drivers/hwtracing/coresight/coresight-replicator.c >> +++ b/drivers/hwtracing/coresight/coresight-replicator.c >> @@ -31,6 +31,7 @@ DEFINE_CORESIGHT_DEVLIST(replicator_devs, "replicator"); >> * @base: memory mapped base address for this component. Also indicates >> * whether this one is programmable or not. >> * @atclk: optional clock for the core parts of the replicator. >> + * @pclk: APB clock if present, otherwise NULL >> * @csdev: component vitals needed by the framework >> * @spinlock: serialize enable/disable operations. >> * @check_idfilter_val: check if the context is lost upon clock removal. >> >> I will update replicator, tpiu, tmc, and stm devices. >> > funnel is missing it as well. If you build with W=1 it shows up. Updated, done.