From: John Crispin <john@phrozen.org>
To: Michal Marek <mmarek@suse.com>, Florian Fainelli <f.fainelli@gmail.com>
Cc: openwrt-devel@lists.openwrt.org, lede-dev@lists.infradead.org,
sam@ravnborg.org, linux-kernel@vger.kernel.org
Subject: Re: [LEDE-DEV] [PATCH] initramfs: Escape colons in depfile
Date: Thu, 27 Oct 2016 12:35:30 +0200 [thread overview]
Message-ID: <dbcdc8cc-a383-148a-48bc-52abf0de24bb@phrozen.org> (raw)
In-Reply-To: <1474619740-3725-1-git-send-email-mmarek@suse.com>
Hi,
this seems to be a backport for the kernel tree. please resend it as a
patch adding the actual patch that is being backported to the generic
targets patch folder. this would need to be done for 3.18, 4.1 and 4.4
John
On 23/09/2016 10:35, Michal Marek wrote:
> Special characters are problematic in depfiles, but we can fix colons
> easily.
>
> Reported-by: Florian Fainelli <f.fainelli@gmail.com>
> Signed-off-by: Michal Marek <mmarek@suse.com>
> ---
> scripts/gen_initramfs_list.sh | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/gen_initramfs_list.sh b/scripts/gen_initramfs_list.sh
> index 17fa901418ae..0055b07b03b6 100755
> --- a/scripts/gen_initramfs_list.sh
> +++ b/scripts/gen_initramfs_list.sh
> @@ -97,7 +97,10 @@ print_mtime() {
> }
>
> list_parse() {
> - [ ! -L "$1" ] && echo "$1 \\" || :
> + if [ -L "$1" ]; then
> + return
> + fi
> + echo "$1" | sed 's/:/\\:/g; s/$/ \\/'
> }
>
> # for each file print a line in following format
>
prev parent reply other threads:[~2016-10-27 14:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-13 0:12 gen_initramfs_list.sh escaping problem or stale dependency file? Florian Fainelli
2016-09-13 7:24 ` Michal Marek
2016-09-13 17:28 ` Florian Fainelli
2016-09-19 20:00 ` Florian Fainelli
2016-09-23 7:05 ` Michal Marek
2016-09-23 8:35 ` [PATCH] initramfs: Escape colons in depfile Michal Marek
2016-10-27 10:35 ` John Crispin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbcdc8cc-a383-148a-48bc-52abf0de24bb@phrozen.org \
--to=john@phrozen.org \
--cc=f.fainelli@gmail.com \
--cc=lede-dev@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.com \
--cc=openwrt-devel@lists.openwrt.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®