From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752792AbdBUOhp (ORCPT ); Tue, 21 Feb 2017 09:37:45 -0500 Received: from mailout3.w1.samsung.com ([210.118.77.13]:13672 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752639AbdBUOhi (ORCPT ); Tue, 21 Feb 2017 09:37:38 -0500 MIME-version: 1.0 Content-type: text/plain; charset=utf-8; format=flowed X-AuditID: cbfec7f1-f793f6d000007796-0d-58ac50a91659 Subject: Re: [PATCH] dma-buf: add support for compat ioctl To: =?UTF-8?Q?Christian_K=c3=b6nig?= , linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org, Bartlomiej Zolnierkiewicz From: Marek Szyprowski Message-id: Date: Tue, 21 Feb 2017 15:37:27 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 In-reply-to: <917aff70-64f7-7224-a015-0e77951bbc1d@vodafone.de> Content-transfer-encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupileLIzCtJLcpLzFFi42LZduznOd2VAWsiDBpWKlpsnLGe1eL86gmM Fle+vmez+HLlIZPF5V1z2Cx6NmxldWDzuN99nMnj9r/HzB59W1YxenzeJOfRce8SawBrFJdN SmpOZllqkb5dAlfG7M5NTAVfWCsO7drM3MB4haWLkZNDQsBEouXRY1YIW0ziwr31bCC2kMBS Roljfw26GLmA7M+MEvs2XGWGadh4eDk7RGIZo8Smtl9g3bwCghI/Jt8Dm8osYCXx7F8rK0TR c0aJK2d3g40VBkpMP3MWzBYRqJOYfK+DEaKhQmLBtDlgNpuAoUTX2y42iKF2Es8XzmQCsVkE VCWW/z0JFhcViJHo3TQN7CJOAXuJq1MOQs2Rlzh45TkLyGIJgXnsEuc7m4CaOYAcWYlNB5gh TBeJQ78TIZ4Rlnh1fAs7hC0jcXlyNzRU+hklmlq1IewZjBLn3vJC2NYSh49fZIVYxScxadt0 qJG8Eh1tQhAlHhJt+zsZIWxHiaamVdBguMAo8W3pNNYJjPKzkIJrFlJwzULywQJG5lWMIqml xbnpqcVGesWJucWleel6yfm5mxiBKeT0v+MfdzC+P2F1iFGAg1GJh/eB+5oIIdbEsuLK3EOM EhzMSiK8b42AQrwpiZVVqUX58UWlOanFhxilOViUxHn3LLgSLiSQnliSmp2aWpBaBJNl4uCU amA04HjMtW/bC+klXmfOMrzUbVGZcv4G74aEj9LOijc2OFzkPRt7VOp8Hkf4cg55Pv59q05e NvN+7qRV5TXf4fLTXqYd6S1PHlf4eZxVcHnwnL9c5MBZ01Bh/m32+10PeR9+fy/uxKlZfNNT /Q7fjXTbMue5S5Koo96Zl5LeZ8rXBV7v4Y3vCDqsxFKckWioxVxUnAgAgPpI1x0DAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrNIsWRmVeSWpSXmKPExsVy+t/xK7rrAtZEGCxrs7DYOGM9q8X51RMY La58fc9m8eXKQyaLy7vmsFn0bNjK6sDmcb/7OJPH7X+PmT36tqxi9Pi8Sc6j494l1gDWKDeb jNTElNQihdS85PyUzLx0W6XQEDddCyWFvMTcVFulCF3fkCAlhbLEnFIgz8gADTg4B7gHK+nb JbhlzO7cxFTwhbXi0K7NzA2MV1i6GDk5JARMJDYeXs4OYYtJXLi3nq2LkYtDSGAJo8Sk2SsY QRK8AoISPybfA2tgFjCT+PLyMCtE0XNGiZ4Hm5lBEsICVhLTz5wF6ubgEBGokzi1NxMkLCRw iVGiYUMJRG+FRMPzU2Bz2AQMJbredrFBzLeTeL5wJhOIzSKgKrH870mwuKhAjMTe/vtgcU4B e4mrUw4yQsyRlzh45TnLBEaBWUjOm4XkvFlIyhYwMq9iFEktLc5Nzy020itOzC0uzUvXS87P 3cQIjKhtx35u2cHY9S74EKMAB6MSD2+H65oIIdbEsuLK3EOMEhzMSiK8b42AQrwpiZVVqUX5 8UWlOanFhxhNgY6dyCwlmpwPjPa8knhDE0NzS0MjYwsLcyMjJXHeqR+uhAsJpCeWpGanphak FsH0MXFwSjUwzkmfWu1eLHftbYjvvOYNumodDf1uMpW9m09U1cY8yJpwUaVbcP2MScnK5TP3 zNHndivaZNksenT2are6k0teblHZUZV2wVuQecriB+ZKJfV7H7t6hdaEbpu2w4LJQLQ2pnP/ oZaE53bfJ0WniE/6dN+R2cdJ+5lo6bTj93ZUH8rZP/3nqcZ9SizFGYmGWsxFxYkAOJ/Knb4C AAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170221143729eucas1p1ed2542640f9de9ee301909ea09a6c5ff X-Msg-Generator: CA X-Sender-IP: 182.198.249.180 X-Local-Sender: =?UTF-8?B?TWFyZWsgU3p5cHJvd3NraRtTUlBPTC1LZXJuZWwgKFRQKRs=?= =?UTF-8?B?7IK87ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?TWFyZWsgU3p5cHJvd3NraRtTUlBPTC1LZXJuZWwgKFRQKRtT?= =?UTF-8?B?YW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20170221132114eucas1p2e527d5b5516494ba54aa91f48b3e227f X-RootMTR: 20170221132114eucas1p2e527d5b5516494ba54aa91f48b3e227f References: <1487683261-2655-1-git-send-email-m.szyprowski@samsung.com> <917aff70-64f7-7224-a015-0e77951bbc1d@vodafone.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Christian, On 2017-02-21 14:59, Christian König wrote: > Am 21.02.2017 um 14:21 schrieb Marek Szyprowski: >> Add compat ioctl support to dma-buf. This lets one to use >> DMA_BUF_IOCTL_SYNC >> ioctl from 32bit application on 64bit kernel. Data structures for >> both 32 >> and 64bit modes are same, so there is no need for additional translation >> layer. > > Well I might be wrong, but IIRC compat_ioctl was just optional and if > not specified unlocked_ioctl was called instead. > > If that is true your patch wouldn't have any effect at all. Well, then why I got -ENOTTY in the 32bit test app for this ioctl on 64bit ARM64 kernel without this patch? Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland