From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758697AbcBXSbE (ORCPT ); Wed, 24 Feb 2016 13:31:04 -0500 Received: from 5520-maca-inet1-outside.broadcom.com ([216.31.211.11]:15929 "EHLO mail-irv-18.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758437AbcBXSbA (ORCPT ); Wed, 24 Feb 2016 13:31:00 -0500 Subject: Re: [PATCH 07/50] pinctrl: nsp-gpio: Use devm_pinctrl_register() for pinctrl registration To: Laxman Dewangan , linus.walleij@linaro.org, corbet@lwn.net, lee@kernel.org References: <1456319775-3216-1-git-send-email-ldewangan@nvidia.com> <1456319775-3216-8-git-send-email-ldewangan@nvidia.com> Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-mediatek@lists.infradead.org, Ray Jui , Scott Branden , Jon Mason From: Ray Jui Message-ID: Date: Wed, 24 Feb 2016 10:30:34 -0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <1456319775-3216-8-git-send-email-ldewangan@nvidia.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/24/2016 5:15 AM, Laxman Dewangan wrote: > Use devm_pinctrl_register() for pin control registration. > > Signed-off-by: Laxman Dewangan > Cc: Ray Jui > Cc: Scott Branden > Cc: Jon Mason > --- > drivers/pinctrl/bcm/pinctrl-nsp-gpio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c b/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c > index ac90043..2873f73 100644 > --- a/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c > +++ b/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c > @@ -609,7 +609,7 @@ static int nsp_gpio_register_pinconf(struct nsp_gpio *chip) > pctldesc->npins = gc->ngpio; > pctldesc->confops = &nsp_pconf_ops; > > - chip->pctl = pinctrl_register(pctldesc, chip->dev, chip); > + chip->pctl = devm_pinctrl_register(chip->dev, pctldesc, chip); > if (IS_ERR(chip->pctl)) { > dev_err(chip->dev, "unable to register pinctrl device\n"); > return PTR_ERR(chip->pctl); > Acked-by: Ray Jui Thanks! Ray