From: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
To: Song Liu <liu.song.a23@gmail.com>
Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
Oleg Nesterov <oleg@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
mhiramat@kernel.org, Peter Zijlstra <peterz@infradead.org>,
mingo@redhat.com, acme@kernel.org,
alexander.shishkin@linux.intel.com, jolsa@redhat.com,
namhyung@kernel.org, open list <linux-kernel@vger.kernel.org>,
ananth@linux.vnet.ibm.com,
Alexis Berlemont <alexis.berlemont@gmail.com>,
naveen.n.rao@linux.vnet.ibm.com,
linux-arm-kernel@lists.infradead.org, linux-mips@linux-mips.org,
linux@armlinux.org.uk, ralf@linux-mips.org, paul.burton@mips.com,
Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Subject: Re: [PATCH v9 0/4] Uprobes: Support SDT markers having reference count (semaphore)
Date: Tue, 21 Aug 2018 11:50:43 +0530 [thread overview]
Message-ID: <dbd74447-b3e2-6bcf-2d8b-717b403bdf11@linux.ibm.com> (raw)
In-Reply-To: <2e997c62-371c-1d9d-97ab-65726f588ab5@linux.ibm.com>
Hi Song,
On 08/21/2018 10:53 AM, Ravi Bangoria wrote:
> Hi Song,
>
>> However, if I start a.out AFTER enabling the uprobe, there is something wrong:
>>
>> root@virt-test:~# ~/a.out
>> 11
>> semaphore 0 <<< this should be non-zero, as the uprobe is already enabled
In this testcase, semaphore variable is stored into .bss:
$ nm test | grep semaphore
0000000010010c5e B semaphore
$ readelf -SW ./test | grep "data\|bss"
[22] .data PROGBITS 0000000010010c58 000c58 000004 00 WA 0 0 1
[23] .bss NOBITS 0000000010010c5c 000c5c 000004 00 WA 0 0 2
I'm not so sure but I guess .bss data initialization happens after
calling uprobe_mmap() and thus you are seeing semaphore as 0.
To verify this, if I force to save semaphore into data section by
assigning non-zero value to it:
volatile short semaphore = 1
$ nm test | grep semaphore
0000000010010c5c D semaphore
$ readelf -SW ./test | grep "data\|bss"
[22] .data PROGBITS 0000000010010c58 000c58 000006 00 WA 0 0 2
[23] .bss NOBITS 0000000010010c5e 000c5e 000002 00 WA 0 0 1
increment/decrement works fine.
Ravi
next prev parent reply other threads:[~2018-08-21 6:21 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-20 4:42 Ravi Bangoria
2018-08-20 4:42 ` [PATCH v9 1/4] " Ravi Bangoria
2018-08-20 5:53 ` Song Liu
2018-08-21 21:35 ` Song Liu
2018-08-22 12:39 ` Srikar Dronamraju
2018-08-28 19:07 ` Song Liu
2018-08-28 19:34 ` Steven Rostedt
2018-08-20 4:42 ` [PATCH v9 2/4] Uprobes/sdt: Prevent multiple reference counter for same uprobe Ravi Bangoria
2018-08-20 5:54 ` Song Liu
2018-08-21 21:35 ` Song Liu
2018-08-20 4:42 ` [PATCH v9 3/4] trace_uprobe/sdt: " Ravi Bangoria
2018-08-21 20:46 ` Song Liu
2018-08-20 4:42 ` [PATCH v9 4/4] perf probe: Support SDT markers having reference counter (semaphore) Ravi Bangoria
2018-08-21 21:33 ` Song Liu
2018-08-30 18:45 ` Steven Rostedt
2018-08-30 18:50 ` Arnaldo Carvalho de Melo
2018-08-30 19:43 ` Steven Rostedt
2018-08-20 17:38 ` [PATCH v9 0/4] Uprobes: Support SDT markers having reference count (semaphore) Song Liu
2018-08-21 4:42 ` Ravi Bangoria
2018-08-21 4:55 ` Song Liu
2018-08-21 5:23 ` Ravi Bangoria
2018-08-21 6:20 ` Ravi Bangoria [this message]
2018-08-21 7:34 ` Naveen N. Rao
2018-08-21 11:58 ` Ravi Bangoria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbd74447-b3e2-6bcf-2d8b-717b403bdf11@linux.ibm.com \
--to=ravi.bangoria@linux.ibm.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexis.berlemont@gmail.com \
--cc=ananth@linux.vnet.ibm.com \
--cc=jolsa@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux@armlinux.org.uk \
--cc=liu.song.a23@gmail.com \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=oleg@redhat.com \
--cc=paul.burton@mips.com \
--cc=peterz@infradead.org \
--cc=ralf@linux-mips.org \
--cc=rostedt@goodmis.org \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome