From: Bart Van Assche <bvanassche@acm.org>
To: Lu Hongfei <luhongfei@vivo.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Daniil Lunev <dlunev@chromium.org>,
Jinyoung Choi <j-young.choi@samsung.com>,
Bean Huo <beanhuo@micron.com>,
Peter Wang <peter.wang@mediatek.com>,
open list <linux-kernel@vger.kernel.org>,
"open list:UNIVERSAL FLASH STORAGE HOST CONTROLLER DRIVER"
<linux-scsi@vger.kernel.org>
Cc: opensource.kernel@vivo.com
Subject: Re: [PATCH v4] scsi: ufs: wb: Add explicit flush_threshold sysfs attribute
Date: Mon, 12 Jun 2023 11:21:18 -0700 [thread overview]
Message-ID: <dbdadc45-0566-3a6c-be16-ab8f1f5c7a6a@acm.org> (raw)
In-Reply-To: <20230609091113.22531-1-luhongfei@vivo.com>
On 6/9/23 02:11, Lu Hongfei wrote:
> +What: /sys/bus/platform/drivers/ufshcd/*/wb_flush_threshold
> +What: /sys/bus/platform/devices/*.ufs/wb_flush_threshold
> +Date: June 2023
> +Contact: Lu Hongfei <luhongfei@vivo.com>
> +Description: wb_flush_threshold is a percentage that represents the threshold for flush WB.
> + When avail_wb_buff < wb_flush_threshold, the dev will flush WB when entered H8.
> + When avail_wb_buff >= wb_flush_threshold, it is not necessary.
"Percentage" suggests a number in the range 0..100 while the valid range is 0..10.
Please fix this.
Thanks,
Bart.
prev parent reply other threads:[~2023-06-12 18:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 9:11 Lu Hongfei
2023-06-09 10:18 ` Avri Altman
2023-06-12 18:21 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbdadc45-0566-3a6c-be16-ab8f1f5c7a6a@acm.org \
--to=bvanassche@acm.org \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=dlunev@chromium.org \
--cc=j-young.choi@samsung.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=luhongfei@vivo.com \
--cc=martin.petersen@oracle.com \
--cc=opensource.kernel@vivo.com \
--cc=peter.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®