From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7891FC433F5 for ; Wed, 3 Nov 2021 15:00:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 62C1A60EBC for ; Wed, 3 Nov 2021 15:00:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230450AbhKCPDa (ORCPT ); Wed, 3 Nov 2021 11:03:30 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:47395 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229480AbhKCPD3 (ORCPT ); Wed, 3 Nov 2021 11:03:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635951652; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uwI0Y59Q5jmF4PHv+uLDkwhNmEWKp2IZoCsuOpcoatA=; b=V8hupRDi7JW+MC8owgkOu+/x5Qo5KaggJE3sSIstfNGwbQoL9+gRulz1GWQFi/8GxGc41a enkqUtLyhFFkpJTFmMNpm+gZLs/uvyOcF+btSBtMsx0ql6i57D9Ot9z146O6p1kWLNpk7M zPe2NrI7r68797d6wlshTQaNDptLT/A= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-363-lqHpzZbOMGu-eO_lkIF3ww-1; Wed, 03 Nov 2021 11:00:51 -0400 X-MC-Unique: lqHpzZbOMGu-eO_lkIF3ww-1 Received: by mail-wm1-f71.google.com with SMTP id f20-20020a05600c155400b0030db7b29174so1217302wmg.2 for ; Wed, 03 Nov 2021 08:00:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=uwI0Y59Q5jmF4PHv+uLDkwhNmEWKp2IZoCsuOpcoatA=; b=xP5PCa8TkieU+Ax0ecGYtuDZg/6JhISCi8ILFgk3OsvH3Y39rUF734W0peLJh6h14k TuAVefDAgoqthoKqdkYnf+TfpD2UIAlnafICKy/epp56Stka2r3sYdxkqcjog1VrnBcR pcXm2pi+gRRqphb6s3wqHXIUAg5pXqCxYY9B2A+Z2r4gmVLyZCk4aE5pVv3mSZU37rGh nLsAY+LAbWJ23ypsz9eXEBfglHx9Fqyz9tpdTY2/R+xwt4OfQGJ1OcWs+tbHknpxKnEd H4Zu2YnojudQsgkCAb6Mju5eSxIuJSE2qPmOAZmpT6UnVPFC4L0DxVKZJ7D5Nc80mWOY QNwg== X-Gm-Message-State: AOAM531IJEwM7Ruas/P8eI4vCQ8W2wPqwUGK+67/cT3yw7bhrBRekmAU 9ojyc28f4dV//mckttBtAEQqBG/CjreoqrS3zwod7oymy6toRf9TnM+8FS4kRYZ0HjvXzeb2xCW 3AKq1ec+cpMmIv+mH0WmQE6OQ X-Received: by 2002:a1c:740e:: with SMTP id p14mr15702607wmc.109.1635951649994; Wed, 03 Nov 2021 08:00:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzlHYGSvfJmLDivVAOaT4xxbH7zmwqgCefExXH/bfigpAgkjWjbQ8meeoW65MqFlJvktgySGg== X-Received: by 2002:a1c:740e:: with SMTP id p14mr15702572wmc.109.1635951649817; Wed, 03 Nov 2021 08:00:49 -0700 (PDT) Received: from [192.168.1.128] ([92.176.231.106]) by smtp.gmail.com with ESMTPSA id q1sm2089857wmj.20.2021.11.03.08.00.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Nov 2021 08:00:49 -0700 (PDT) Message-ID: Date: Wed, 3 Nov 2021 16:00:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [RESEND PATCH 0/5] Cleanups for the nomodeset kernel command line parameter logic Content-Language: en-US To: Thomas Zimmermann , linux-kernel@vger.kernel.org Cc: Peter Robinson , =?UTF-8?Q?Michel_D=c3=a4nzer?= , Pekka Paalanen , Daniel Vetter , Neal Gompa , Alex Deucher , Ben Skeggs , Chia-I Wu , =?UTF-8?Q?Christian_K=c3=b6nig?= , Daniel Vetter , Dave Airlie , David Airlie , Gerd Hoffmann , Greg Kroah-Hartman , Gurchetan Singh , Hans de Goede , Jani Nikula , Joonas Lahtinen , Maarten Lankhorst , Maxime Ripard , "Pan, Xinhui" , Rodrigo Vivi , VMware Graphics , Zack Rusin , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-fbdev@vger.kernel.org, nouveau@lists.freedesktop.org, spice-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org References: <20211103122809.1040754-1-javierm@redhat.com> From: Javier Martinez Canillas In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Thomas, On 11/3/21 14:01, Thomas Zimmermann wrote: [snip] >> >> >> Javier Martinez Canillas (5): >> drm/i915: Fix comment about modeset parameters >> drm: Move nomodeset kernel parameter handler to the DRM subsystem >> drm: Rename vgacon_text_force() function to drm_modeset_disabled() >> drm: Add a drm_drv_enabled() helper function >> drm: Use drm_drv_enabled() instead of drm_modeset_disabled() > > There's too much churn here IMHO. Please merge patches 2+3 and 4+5. And > I'd put patch (4+5) first, so you have the drivers out of the way. After > that patch (2+3) should only modify drm_drv_enabled(). > Sure, I'm happy with less patches. Thanks for your feedback. > Best regards > Thomas > Best regards, -- Javier Martinez Canillas Linux Engineering Red Hat