From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C9651A00EC for ; Mon, 6 Jan 2025 09:51:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736157071; cv=none; b=b5t2Ndmk9TsPDNuzFdJyYxELZEcYio5lXbCqTh8RjVOf5XYelmX83pfidrrIeMAgoXdqPExoQeHcQF8jUeJfn/nnLhwqZTowXDQ2vday7Z1HGAD7CiRA5qU1i6vfEphjsPN92e9VGv30sNDp1TXUaVLwAN8yDwPKDksEvMBkkRY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736157071; c=relaxed/simple; bh=StFOGC85qK2urFtRYqnRf9I7iG/S6p8X+y5EyoxL/68=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=W3EVnaoufdyzrFJdzXAcQfOXib5IJDtHtUDQquRG3ab2oERi4HnTBN0TooN/ssR0Dez6O/wx1eTGAntIDOR58AH1SxFCD5R8WmhvausoNPTDlejaE8THlL89fbIBPmpGJYa4dGMUTyBwhdIY0pxQwjCV783tbYVXjbLG980M1y4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=HfyqZzW3; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HfyqZzW3" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-436202dd7f6so161598835e9.0 for ; Mon, 06 Jan 2025 01:51:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736157068; x=1736761868; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+1YcNhTzB+NJ0AXGpO3lzvdJFWAfHpdWAfxwOWgEsxU=; b=HfyqZzW3oBjzFjjkjmCKvKLXK3AKIGhhx5OLsgRsksHDbIrrEZ9gQ8rFA1L4RgycVl K98pUA+sZPmtbHXjkcI1ZyqrbdvkCFrBWVG5MSYJ2HiLBcuv6lOBAJVOhtGJPZILPTqk egdZmcu0qo3GwKtFGumX19Trf6DH0EsDGYINPZDL96lL9ZtTAfV+amEYxDk0eBb0B1Iu ZjKqnnbPzKQxpMDHZVtvIdcwYlE6rjJY+uUH90JCDCLajjoP++Igd0PUOfgnbPyd0pqP +pVoSrmnDmafL+Hg5niPdbaupIeWFHciz5b95mb5LgpQDFa1x+8PtdBgpguL2zJMCEFM w3og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736157068; x=1736761868; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+1YcNhTzB+NJ0AXGpO3lzvdJFWAfHpdWAfxwOWgEsxU=; b=dndUXujmTIweC9z+vNEa5Y7TthL3WfyxS+UHJxQ+I+mZ23+hjtuocypCjDFIMv9XOV HbQ1I2yOmuzqYJ1KPZpyXW9AYk4eb7LfwFA+JgFXtzlIlLrPTjlgOrDciQ3AB62It6UH DkgiRFm/Auqn0Owly5fRicmvBdULrtyvjwFBeW+g+wQJ+/lScYgtsHs1DmIojMemRdYQ rGzZHMWGqb3dBvYCmurse5h4WkH7awlp+pxmvquzBFaorr3yjNThKd9m7wTT2UGbMakY RdcW/UziPuf9ve/TtCHfOtI4okzflSLPIuP/w4zRlh0SnAothmCOy9aoW3Wq1lFEdwLl cNVg== X-Forwarded-Encrypted: i=1; AJvYcCVaouPRZyszFpZsAPCW6ZdwZBhjGhRlD1kBMGziDXshmW4MkY5PU1cra0EHMsGlKWTmt6BagLEjifEds8M=@vger.kernel.org X-Gm-Message-State: AOJu0Yxou+kWBx1Jwt439VHmiGOrMDHc8zFNm5p/eqGAPRMgIF20Tcwj xXLniuP394kGtSWGrsx4jnyBAocQM/xeO/V1C8HQLdwQsZg5/AEnhMhuSFoxkzc= X-Gm-Gg: ASbGncvewoIZIXuJ+oqmUS/0bCVcsg722VP50C6h7uzab1+fhWmHpWLRKiOfhmNXoZ9 idafSrsPT9a+FXZzvlc5/XCxHI4GcSBKep9NDLgCkUW07Txa0BZraqXyJY1mWMv/l0UPgmao5Md 8Z5oGRbF4hwIyG2VXXlw5oacRM4sTRjgCYSHGOPX17KN2iU5ifWMdJf4FJCesqMvMcSQdQSPO8D Usbv2t/KAA5x9EXJVWc3KvJjjV17xAA6cRodyF2JOJrKSM7O+WwoTJYGtBEVw== X-Google-Smtp-Source: AGHT+IHmXleKLa3N60gIDy5ub0LsWvE9b4koj2geI54RUXBm2V6RO5ggQ0ZKvSFfdiPyiXyWjCzTww== X-Received: by 2002:a7b:cb14:0:b0:436:90d4:5f3e with SMTP id 5b1f17b1804b1-43690d46037mr311062535e9.6.1736157067794; Mon, 06 Jan 2025 01:51:07 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c89e2f9sm48633973f8f.81.2025.01.06.01.51.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jan 2025 01:51:07 -0800 (PST) Date: Mon, 6 Jan 2025 12:51:04 +0300 From: Dan Carpenter To: Atharva Tiwari Cc: gregkh@linuxfoundation.org, elder@kernel.org, greybus-dev@lists.linaro.org, johan@kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, mgreer@animalcreek.com, vaibhav.sr@gmail.com Subject: Re: [PATCH] staging: greybus: Remove Module from list before freeing in gb_audio_module_release Message-ID: References: <2024122358-vexingly-broadly-7df7@gregkh> <20241224051917.1971-1-evepolonium@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241224051917.1971-1-evepolonium@gmail.com> On Tue, Dec 24, 2024 at 10:49:17AM +0530, Atharva Tiwari wrote: > Yes I have tested the patch with greybus drivers enabled on Debian 12.It works as expected, and i did not get any errors or warning during the compilation > > Please let me know if further changes are required. > You're trying to ensure that the list is initialized but instead of testing for that, the correct way is to initialize it earlier in the process. regards, dan carpenter