From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752999AbdEHEVE (ORCPT ); Mon, 8 May 2017 00:21:04 -0400 Received: from fllnx209.ext.ti.com ([198.47.19.16]:46840 "EHLO fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750944AbdEHEVC (ORCPT ); Mon, 8 May 2017 00:21:02 -0400 Subject: Re: [PATCH v3 1/2] thermal: core: Allow orderly_poweroff to be called only once To: Pavel Machek References: <1492147105-26692-1-git-send-email-j-keerthy@ti.com> <20170507210219.GB25628@atrey.karlin.mff.cuni.cz> CC: , , , , , , From: Keerthy Message-ID: Date: Mon, 8 May 2017 09:50:05 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170507210219.GB25628@atrey.karlin.mff.cuni.cz> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 08 May 2017 02:32 AM, Pavel Machek wrote: >> thermal_zone_device_check --> thermal_zone_device_update --> >> handle_thermal_trip --> handle_critical_trips --> orderly_poweroff >> >> The above sequence happens every 250/500 mS based on the configuration. >> The orderly_poweroff function is getting called every 250/500 mS. >> With a full fledged file system it takes at least 5-10 Seconds to >> power off gracefully. >> >> In that period due to the thermal_zone_device_check triggering >> periodically the thermal work queues bombard with >> orderly_poweroff calls multiple times eventually leading to >> failures in gracefully powering off the system. >> >> Make sure that orderly_poweroff is called only once. > > Pretty please, can we do it in the core code, not in thermal/? There > are other reasons kernel may want to shut the system down, like for > example critical battery, and if both thermal _and_ bad battery > happen, we want just one shutdown... Pavel, Thermal fix is still valid. As it is having multiple calls. I can work on fixing the core code as well. BTW the latest of this series is v6: https://patchwork.kernel.org/patch/9684929/ - Keerthy > >> Reported-by: Keerthy >> Signed-off-by: Keerthy > > And here probably we need your full name. > > Thanks, > Pavel >