mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Sugaya, Taichi" <sugaya.taichi@socionext.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Shinji Kanematsu <kanematsu.shinji@socionext.com>,
	Masami Hiramatsu <masami.hiramatsu@linaro.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Jassi Brar <jaswinder.singh@linaro.org>,
	soc@kernel.org, Takao Orito <orito.takao@socionext.com>,
	Kazuhiro Kasai <kasai.kazuhiro@socionext.com>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 9/9] ARM: configs: Add Milbeaut M10V defconfig
Date: Wed, 20 Feb 2019 20:27:32 +0900	[thread overview]
Message-ID: <dbe814ed-3cf2-f72e-b7fa-23cf41e9e42b@socionext.com> (raw)
In-Reply-To: <CAK8P3a0rwi=uDFYiF50e5HkYoDQUA6_VSWDMiAVeTMaRzeE6oQ@mail.gmail.com>

Hi

On 2019/02/20 18:28, Arnd Bergmann wrote:
> On Wed, Feb 20, 2019 at 8:44 AM Sugaya Taichi
> <sugaya.taichi@socionext.com> wrote:
> 
>> diff --git a/arch/arm/configs/milbeaut_m10v_defconfig b/arch/arm/configs/milbeaut_m10v_defconfig
>> new file mode 100644
>> index 0000000..a263211
>> --- /dev/null
>> +++ b/arch/arm/configs/milbeaut_m10v_defconfig
>> @@ -0,0 +1,175 @@
> 
> I no longer see anything here that should be turned off, but you
> might want to run 'make savedefconfig' and use the output of that,
> to make it easier to keep it up to date.
> 

I got it, I use the output of 'make savedefconfig'.
One question, is that OK to add some options on it?
  -Because "CONFIG_ARCH_MILBEAUT" was not listed.


>> diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
>> index 5bee34a..6753805 100644
>> --- a/arch/arm/configs/multi_v7_defconfig
>> +++ b/arch/arm/configs/multi_v7_defconfig
>> @@ -54,6 +54,8 @@ CONFIG_SOC_VF610=y
>>   CONFIG_ARCH_KEYSTONE=y
>>   CONFIG_ARCH_MEDIATEK=y
>>   CONFIG_ARCH_MESON=y
>> +CONFIG_ARCH_MILBEAUT=y
>> +CONFIG_ARCH_MILBEAUT_M10V=y
>>   CONFIG_ARCH_MVEBU=y
>>   CONFIG_MACH_ARMADA_370=y
>>   CONFIG_MACH_ARMADA_375=y
> 
> I'm surprised that you don't need to enable any drivers. Does this actually
> boot on your hardware?
> 

Yes, but not exactly.
The series has not serial driver, so I add the driver temporarily and 
confirm the boot log through earlycon.
The timer driver is selected by "CONFIG_ARCH_MILBEAUT_M10V", no need to 
add the the"CONFIG_MILBEAUT_TIMER".

Here one more question.
Is this OK to submit a core support patch without any serial drivers?

Thanks,
Sugaya Taichi

>        Arnd
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 


  reply	other threads:[~2019-02-20 11:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-20  7:45 Sugaya Taichi
2019-02-20  9:28 ` Arnd Bergmann
2019-02-20 11:27   ` Sugaya, Taichi [this message]
2019-02-20 12:27     ` Arnd Bergmann
2019-02-20 13:16       ` Masami Hiramatsu
2019-02-20 13:18         ` Arnd Bergmann
2019-02-20 13:23           ` Masami Hiramatsu
2019-02-21  0:36             ` Sugaya, Taichi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dbe814ed-3cf2-f72e-b7fa-23cf41e9e42b@socionext.com \
    --to=sugaya.taichi@socionext.com \
    --cc=arnd@arndb.de \
    --cc=jaswinder.singh@linaro.org \
    --cc=kanematsu.shinji@socionext.com \
    --cc=kasai.kazuhiro@socionext.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masami.hiramatsu@linaro.org \
    --cc=orito.takao@socionext.com \
    --cc=soc@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®