From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D4E4C4332F for ; Thu, 14 Dec 2023 11:38:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1444071AbjLNLiZ (ORCPT ); Thu, 14 Dec 2023 06:38:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1444073AbjLNLiV (ORCPT ); Thu, 14 Dec 2023 06:38:21 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 195AA183 for ; Thu, 14 Dec 2023 03:38:27 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6ADA2C15; Thu, 14 Dec 2023 03:39:12 -0800 (PST) Received: from [10.1.197.60] (eglon.cambridge.arm.com [10.1.197.60]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 37AD43F738; Thu, 14 Dec 2023 03:38:24 -0800 (PST) Message-ID: Date: Thu, 14 Dec 2023 11:38:22 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v7 20/24] x86/resctrl: Add CPU online callback for resctrl work Content-Language: en-GB To: babu.moger@amd.com, x86@kernel.org, linux-kernel@vger.kernel.org Cc: Fenghua Yu , Reinette Chatre , Thomas Gleixner , Ingo Molnar , Borislav Petkov , H Peter Anvin , shameerali.kolothum.thodi@huawei.com, D Scott Phillips OS , carl@os.amperecomputing.com, lcherian@marvell.com, bobo.shaobowang@huawei.com, tan.shaopeng@fujitsu.com, baolin.wang@linux.alibaba.com, Jamie Iles , Xin Hao , peternewman@google.com, dfustini@baylibre.com, amitsinght@marvell.com References: <20231025180345.28061-1-james.morse@arm.com> <20231025180345.28061-21-james.morse@arm.com> From: James Morse In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Babu, On 09/11/2023 20:51, Moger, Babu wrote: > On 10/25/23 13:03, James Morse wrote: >> The resctrl architecture specific code may need to create a domain when >> a CPU comes online, it also needs to reset the CPUs PQR_ASSOC register. >> The resctrl filesystem code needs to update the rdtgroup_default CPU >> mask when CPUs are brought online. >> >> Currently this is all done in one function, resctrl_online_cpu(). >> This will need to be split into architecture and filesystem parts >> before resctrl can be moved to /fs/. >> >> Pull the rdtgroup_default update work out as a filesystem specific >> cpu_online helper. resctrl_online_cpu() is the obvious name for this, >> which means the version in core.c needs renaming. >> >> resctrl_online_cpu() is called by the arch code once it has done the >> work to add the new CPU to any domains. >> >> In future patches, resctrl_online_cpu() will take the rdtgroup_mutex >> itself. > Reviewed-by: Babu Moger Thanks! James