From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CD6FC433F5 for ; Tue, 28 Sep 2021 16:39:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 141F660F5B for ; Tue, 28 Sep 2021 16:39:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241827AbhI1QlC (ORCPT ); Tue, 28 Sep 2021 12:41:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241800AbhI1QlB (ORCPT ); Tue, 28 Sep 2021 12:41:01 -0400 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F9BCC06161C for ; Tue, 28 Sep 2021 09:39:21 -0700 (PDT) Received: by mail-lf1-x12a.google.com with SMTP id u18so93231942lfd.12 for ; Tue, 28 Sep 2021 09:39:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=G7Nu624BHA+ciBaAN51wOEprdQ45Szw6B8+mMioIzMU=; b=cetdKQLhcnBhXSFEllvSJ8rYG6P547knd8cgm9LIqgEBIpZbimxBdLyGX5CLabrDi2 uiLSxpnHuOhVwpOg/pWAfEVtMdG1dS4PBMGIF/oy7GAyQ2xf9y+1EtWxxId3s9NIlvao v/lb3+AibTbQAIj+2DJu5cdBrkKvqBEJFLvTBlh7QM7HcrmdXH635oioXiHj26pFw8dM MyoltSzyCbx8X6MgoyFB6SyYgw0itqm+KK7oSR1GwxcRZaXXKr8syeTCWFN1RSwjaMLB FCicBfESaEPfPJszwJV0M43V04uc7L4ayKKK1LQ+VahfpNjLioeyiqxoyysoOv+kXDVE TeDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=G7Nu624BHA+ciBaAN51wOEprdQ45Szw6B8+mMioIzMU=; b=aOBGr1SPW2en4vUPV2hoCzsUCV4vxa6KoZcRQq+itfZPVb+UJ7DZzHOnvYDWuX3GV5 z8Yf4Lhlk1aXx1G3rBUXBGg17Pa2Yj9GMC74HaEh9IkaV7lPWFtj7pwgTs4qER3mR78s loKvM3Zu3cBk8b39tQJx1iLiXqWLgUaM3/W/Rd0EmMwGzoXsKHUurIYY2ciXKBUw71xH HVcblVjkJ1dCJXyiLgK2gatVSaNXNzvQ0lpWiiCEEwYvxiiURssiDaeazqImg4bEurGZ GzlUJnfMNtrG6E5u0nnDzaMSJjM6mRXIXRcoBJx5dEmXf0vDefMZwGoaXoni+5d+B4w5 O4kw== X-Gm-Message-State: AOAM531jsKZ+KYaKA3Hw/KKy+oAoPo/YPtIwIMhcZ0A/C1FZpyFA/PUA NdG9XXkdgo0bPuwQE18lhPunX2ARCAG0iw== X-Google-Smtp-Source: ABdhPJyCj8nkgVuxflTeFioAAJwZAukYxUdj8p/t666Q+NKGnuf9aDbO0HpPK9CHZhyIDATH2r/4Lg== X-Received: by 2002:ac2:4bc1:: with SMTP id o1mr6633392lfq.596.1632847155514; Tue, 28 Sep 2021 09:39:15 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id u10sm1970336lfl.87.2021.09.28.09.39.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Sep 2021 09:39:14 -0700 (PDT) Subject: Re: [PATCH] drm/msm/dpu: Remove some nonsense To: Rob Clark , dri-devel@lists.freedesktop.org Cc: freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, Rob Clark , Sean Paul , David Airlie , Daniel Vetter , Abhinav Kumar , AngeloGioacchino Del Regno , Krishna Manikandan , Lee Jones , open list References: <20210928162903.1104847-1-robdclark@gmail.com> From: Dmitry Baryshkov Message-ID: Date: Tue, 28 Sep 2021 19:39:14 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20210928162903.1104847-1-robdclark@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/09/2021 19:28, Rob Clark wrote: > From: Rob Clark > > These aren't used. And if we add use for them later, we should probably > do something a bit more structured than string parsing. > > Signed-off-by: Rob Clark Reviewed-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 6 ------ > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 8 -------- > 2 files changed, 14 deletions(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c > index b131fd376192..e32dbb06aad1 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c > @@ -958,12 +958,6 @@ static const struct dpu_perf_cfg sdm845_perf_data = { > .min_core_ib = 2400000, > .min_llcc_ib = 800000, > .min_dram_ib = 800000, > - .core_ib_ff = "6.0", > - .core_clk_ff = "1.0", > - .comp_ratio_rt = > - "NV12/5/1/1.23 AB24/5/1/1.23 XB24/5/1/1.23", > - .comp_ratio_nrt = > - "NV12/5/1/1.25 AB24/5/1/1.25 XB24/5/1/1.25", > .undersized_prefill_lines = 2, > .xtra_prefill_lines = 2, > .dest_scale_prefill_lines = 3, > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h > index d2a945a27cfa..4ade44bbd37e 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h > @@ -676,10 +676,6 @@ struct dpu_perf_cdp_cfg { > * @min_core_ib minimum mnoc ib vote in kbps > * @min_llcc_ib minimum llcc ib vote in kbps > * @min_dram_ib minimum dram ib vote in kbps > - * @core_ib_ff core instantaneous bandwidth fudge factor > - * @core_clk_ff core clock fudge factor > - * @comp_ratio_rt string of 0 or more of /// > - * @comp_ratio_nrt string of 0 or more of /// > * @undersized_prefill_lines undersized prefill in lines > * @xtra_prefill_lines extra prefill latency in lines > * @dest_scale_prefill_lines destination scaler latency in lines > @@ -702,10 +698,6 @@ struct dpu_perf_cfg { > u32 min_core_ib; > u32 min_llcc_ib; > u32 min_dram_ib; > - const char *core_ib_ff; > - const char *core_clk_ff; > - const char *comp_ratio_rt; > - const char *comp_ratio_nrt; > u32 undersized_prefill_lines; > u32 xtra_prefill_lines; > u32 dest_scale_prefill_lines; > -- With best wishes Dmitry