From: Tengfei Fan <quic_tengfan@quicinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
<andersson@kernel.org>, <agross@kernel.org>,
<konrad.dybcio@linaro.org>, <linus.walleij@linaro.org>,
<robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
<conor+dt@kernel.org>
Cc: <linux-arm-msm@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<quic_tsoni@quicinc.com>, <quic_shashim@quicinc.com>,
<quic_kaushalk@quicinc.com>, <quic_tdas@quicinc.com>,
<quic_tingweiz@quicinc.com>, <quic_aiquny@quicinc.com>,
<quic_ajipan@quicinc.com>, <kernel@quicinc.com>
Subject: Re: [PATCH v3 1/2] dt-bindings: pinctrl: qcom: Add SM4450 pinctrl
Date: Wed, 20 Sep 2023 15:04:11 +0800 [thread overview]
Message-ID: <dbf09ddd-910b-4c1f-8dbe-8d1bcb7183d0@quicinc.com> (raw)
In-Reply-To: <d2f6bfbb-fd08-a551-51d3-f81d9237e060@linaro.org>
在 9/20/2023 2:58 PM, Krzysztof Kozlowski 写道:
> On 20/09/2023 08:47, Tengfei Fan wrote:
>> Add device tree binding Documentation details for Qualcomm SM4450
>> TLMM device.
>>
>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>
>
>
>> + properties:
>> + pins:
>> + description:
>> + List of gpio pins affected by the properties specified in this
>> + subnode.
>> + items:
>> + oneOf:
>> + - pattern: "^gpio([0-9]|[1-9][0-9]|1[0-1][0-9]|12[0-5])$"
>
> Your driver and gpio-ranges in example tell you have 136 GPIOs, not 126.
> It's v3 but still counting GPIOs is incorrect :/
>
> Best regards,
> Krzysztof
>
Hi Krzysztof,
my fault, misunderstand to other platform's setting when reference, will
update.
--
Thx and BRs,
Tengfei Fan
next prev parent reply other threads:[~2023-09-20 7:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 6:47 [PATCH v3 0/2] pinctl: qcom: Add SM4450 pinctrl driver Tengfei Fan
2023-09-20 6:47 ` [PATCH v3 1/2] dt-bindings: pinctrl: qcom: Add SM4450 pinctrl Tengfei Fan
2023-09-20 6:58 ` Krzysztof Kozlowski
2023-09-20 7:04 ` Tengfei Fan [this message]
2023-09-20 6:47 ` [PATCH v3 2/2] pinctrl: qcom: Add SM4450 pinctrl driver Tengfei Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbf09ddd-910b-4c1f-8dbe-8d1bcb7183d0@quicinc.com \
--to=quic_tengfan@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@quicinc.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_aiquny@quicinc.com \
--cc=quic_ajipan@quicinc.com \
--cc=quic_kaushalk@quicinc.com \
--cc=quic_shashim@quicinc.com \
--cc=quic_tdas@quicinc.com \
--cc=quic_tingweiz@quicinc.com \
--cc=quic_tsoni@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®