From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 691D935C19F for ; Tue, 14 Jul 2026 11:35:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784028958; cv=none; b=Ab2Y4Q2jEo/xgtIcwtkaAwm05r7uinvTFFs8jZYRNFSqBZq5MgR/ml/nJS9F12sJnfqfMwXAJuEuTelOOhB4oyv/KQQxdOBpv77Gkq6+HADyANoIFjiZkI48ITibkedztI/6WcMD83xTjK0mWHsVYcTQAvrXunABfm9cZa+0cQo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784028958; c=relaxed/simple; bh=EKNSfL6K7twYkb1f/nM59iEaEppV2KkoUdglhRK+kIY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JkWSHqXFxnmpljdMbv7yZKVDuPmwqJ9r5GnRpNDnxtjE9SftrGRB2ncnQXwa49zWlyv0wR5lbI+s0px3860J3kTH4do+yiC03xb505F9gTFBabvAVQdX1ixBon7q7koKs4rikC15/6o+jyn5Bt0cKoFgvMx+y5fpti6cZnDkHbE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Q6ZE55iz; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Q6ZE55iz" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2ceab75934dso32932405ad.2 for ; Tue, 14 Jul 2026 04:35:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784028957; x=1784633757; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=EKNSfL6K7twYkb1f/nM59iEaEppV2KkoUdglhRK+kIY=; b=Q6ZE55izrPy2MQT3MQRw2P0PvQCyDMDExBZyj+RR0pT8eTQ/TazsfWPh93/YtjGFup bX0ECywG/GVwhD0eOX0GH6wNWQetTgsGR4QEcA+s63u0NKFclhJY3OoJYxXxgbGwK29Y 1o/GwqSjJTYCLNrAc09vfoEz103EQCTdmOc+LwwSpeg7OEMgEY33Y/JbRmXHcXXaEGOC suKVVcRP1eFxniqAxLGHPp8V30a8FA7XjlhmIXvB0CiratT7FpTtiLsjqHzNl+yNlO2J +lae9aXXpNZGfGuxppDPq4uw2FiK7fRIXdNAAbokCgDapA6E2x75Jcsuru2ohd/GVUGE nU5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784028957; x=1784633757; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=EKNSfL6K7twYkb1f/nM59iEaEppV2KkoUdglhRK+kIY=; b=sUMs00IupmZvI8qLTy5ERGb5J4mBHWdjqDgsM/oGflJJmmMhTpN4rYcP96Mvmh9QTS 5zXJJ7CTtgildWBrJ6HvM0p9+kw5qk8HkFdx80pDrR3IInxcdIHq9pLtTQmXW9PW2LUA qbct0gWi5Ep+UxGwXcZlEwrCBWxxq2k1lHRY1Ka762qaXFYm9RufK6yjZZB2aUm6oVpF 404mnNa05BG1k0K7wuQRnHIks+59ODovXvFMcLweVzPzmQ9/s3usysdQahnJfOynBGEU 2HPkYiL+RmyX503JrJrTF6aU8EtPIT6yGH9UhgCnFj6bAOrtE8CmnSrSJnNPpNCIHxaL OFYA== X-Forwarded-Encrypted: i=1; AHgh+RpATFNu8k6dCjGeXQrOEA/yqqd5aqDauNLCS8kx1CKY8MdY6UWq4hUgQpz9n0L1z+o93aRyAL/SUZ5gYwM=@vger.kernel.org X-Gm-Message-State: AOJu0Yxci0NNLfPbJ5t9UVyCt9xMQHhIIex2GgptJ2WYhEKuJfKkGWUE C8ii7hkExV/MNaQrSFkxZxLSS8cD2kFHdsBYgQtPS/aPx5A7bn1Lh+U= X-Gm-Gg: AfdE7ckLgBYdaaLW5kQCUSBIl9OpfoLN33t/DxhR2zb+cPljc2kMEnTDGKudZmpZvXW m5lpi/w4jDNgPMc5nhNMti+hHaNLGDcvchcLhcwgpwZYwSwC8y3j7zR8XlNBif8llwXzVU/AgCD gdQyXhcEuNiSaeSc0/67dRTaNIQJ5hl7LTOkvkZaARSsCeRjYNGaJmKUhXpbfneyi2IfyqFdxDp E2b+EJbu9UgDfCpkYS61E/ysHDMpygpipR1cmWhkdNbckhuxAYmHd6Jrtqzx8zNp30NKROJab1X fU66ifQbzkjMaHpfBt/LYjB+c3EpKEnGZ1TarpKMAeKHOGUQKr96RYwfNqyZwBjpBKnbSKouIxR 1TeHTOnLLa58aSIOTvOnzzeOKJ40J/6Dj1EVRdH+8mFBnyni8sao6ls9GkYz6e9vTqdvA3B1XmM N1lhkdQHH7fBg/AWCu9bm0YgiA+M69p/Wmyzo/MxonyuX2BnwoH3SeOHER4Q== X-Received: by 2002:a17:903:19ec:b0:2be:3850:297e with SMTP id d9443c01a7336-2ce9f052d20mr125833275ad.31.1784028956863; Tue, 14 Jul 2026 04:35:56 -0700 (PDT) Received: from [192.168.1.45] ([101.0.63.168]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ccc9d5bde9sm115071665ad.79.2026.07.14.04.35.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Jul 2026 04:35:54 -0700 (PDT) Message-ID: Date: Tue, 14 Jul 2026 17:05:51 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/4] iio: light: opt4001: Fix reversed GENMASK() arguments in fault count mask To: Andy Shevchenko Cc: Jonathan Cameron , David Lechner , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Stefan Windfeldt-Prytz , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260713035736.11346-1-nikhilgtr@gmail.com> <20260713035736.11346-2-nikhilgtr@gmail.com> Content-Language: en-US From: Nikhil Gautam In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 13-07-2026 09:36 pm, Andy Shevchenko wrote: > On Mon, Jul 13, 2026 at 09:27:33AM +0530, Nikhil Gautam wrote: >> GENMASK(h, l) requires h >= l, but OPT4001_CTRL_FAULT_COUNT is defined >> as GENMASK(0, 1). The define is currently unused so there is no >> functional impact, but fix it before anyone builds on it, and add the >> _MASK suffix for consistency with the neighbouring definitions. > Cam you check my comments on previous version? This one seems has the same > issues. Yes, updated v3 by replacing tabs by spaces Thanks, Nikhil