From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759418AbcHYMob (ORCPT ); Thu, 25 Aug 2016 08:44:31 -0400 Received: from mout.web.de ([212.227.17.11]:50556 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758064AbcHYMoa (ORCPT ); Thu, 25 Aug 2016 08:44:30 -0400 To: Al Viro , Chris Zankel , Jens Axboe , Keith Busch , Max Filippov From: SF Markus Elfring Subject: [PATCH] xtensa-simdisk: Use kmalloc_array() in simdisk_init() Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall , Paolo Bonzini Message-ID: Date: Thu, 25 Aug 2016 14:44:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:2sq2yu0QboNLX5+nQFpzkS2/Rr2yR5/aZOowwf2vrQam8B9gWTz 4thAb8/OZS2/W5hszKA80Cev8aa5FaEwnv2VrvPEd+H4WjJ37Xz9rvR1bpaXs0hQOo46cUf 1gtVlibgyExOLzLlhVMTuYtB31PgToZvxBAjbrUEAcmJeckIV9GpoMTR8SpUV6UwEohyZXw 186El6+uS3fFl2JskPm3g== X-UI-Out-Filterresults: notjunk:1;V01:K0:R+nomgWTNZs=:sZ8hHtJAm7q67f8L7OUoRZ lPMyGafjrWOpY7ito5foSMcr+zmZcyiizuReOhrL1bR0LbVng+ume+M8PUe1FNchccXAms1Td aOooGz/RzNXSljuXv8oN6zj3WyuIsmudNgXMm4gpTp3A9P7V5JXQI1444G3Ug7HuNY/cLrq86 42WywiKaktvvlgbzUwxyVA0n28DYPFffopjiP/z0f4K4isv4D7hpxl7/kW9l+PvaN1Z+U1iQr TQdjlHQlPk9bPn2HsNZWBTDCNWBCpS/Zpudixpmi/fdv7v1/QQZ9OArZGilva44D2r8FiKhQv eSlPQSNLQEc2DPPnXJ+TT64n/jwHnrSu9ZFegRblQhxnFZyixmXUqvCUEtCIkZdDs58teR763 RBt09aG5ojoAu4uaQpO3fJ8J84JXd1XchDSdzioSlLKqEIhDUQ2dphQ2cqatcINajxgv2f8Ai fzweByrezfZUYS++uoQtH/+rd+6OiZFARhBKSS+6q8pbOO5GZf56pg4UjRi4BmrG8jkHpQEzD qeYhOG4pMa7VIjMGWofJZm2X9uETiZdZpHanyXv+y92kEQpCq82OjlMV+e7LBzGqgwa4u3S3/ YE4HR4buxpQNt588pYSMEzHpfX53DaunOCIrUBfVmizemhwK44RRg6yVFhROGXYduWsfT8gy2 x23HTWoe+a8hn9g7zTbROYhgGdyB8SbavsOIhmYkVJNBCC+46wRdEsDz/L7XjhfiuXnDiqiLu 3ldekwck4MIAqUTYw4W8LvzN/PuYsExt1cH2iI/Lt/JtStORYLQ0+prJ1axvcsoZY16Znj0rs qn7kxirJyIQcQWOxTr1IQ8reKsatA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 25 Aug 2016 14:28:09 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. * Replace the specification of a data type by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- arch/xtensa/platforms/iss/simdisk.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/xtensa/platforms/iss/simdisk.c b/arch/xtensa/platforms/iss/simdisk.c index f58a4e6..0a86292 100644 --- a/arch/xtensa/platforms/iss/simdisk.c +++ b/arch/xtensa/platforms/iss/simdisk.c @@ -316,8 +316,7 @@ static int __init simdisk_init(void) if (simdisk_count > MAX_SIMDISK_COUNT) simdisk_count = MAX_SIMDISK_COUNT; - sddev = kmalloc(simdisk_count * sizeof(struct simdisk), - GFP_KERNEL); + sddev = kmalloc_array(simdisk_count, sizeof(*sddev), GFP_KERNEL); if (sddev == NULL) goto out_unregister; -- 2.9.3