From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org,
devicetree@vger.kernel.org
Cc: robdclark@gmail.com, quic_abhinavk@quicinc.com,
dmitry.baryshkov@linaro.org, sean@poorly.run, airlied@gmail.com,
daniel@ffwll.ch, robh+dt@kernel.org, dianders@chromium.org,
david@ixit.cz, krzysztof.kozlowski+dt@linaro.org,
swboyd@chromium.org, konrad.dybcio@somainline.org,
agross@kernel.org, andersson@kernel.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 08/21] dt-bindings: msm: dsi-controller-main: Add vdd* descriptions back in
Date: Thu, 22 Dec 2022 12:54:52 +0100 [thread overview]
Message-ID: <dbf60b16-9331-64ae-93eb-0a67576adf1f@linaro.org> (raw)
In-Reply-To: <20221220123634.382970-9-bryan.odonoghue@linaro.org>
On 20/12/2022 13:36, Bryan O'Donoghue wrote:
> When converting from .txt to .yaml we didn't include descriptions for the
> existing regulator supplies.
>
> - vdd
> - vdda
> - vddio
>
> Add those descriptions into the yaml now as they were prior to the
> conversion. In the .txt description we marked these regulators as required,
> however, that requirement appears to have been in error.
>
> Taking the example of sc7180-trogdor-wormdingler.dtsi. The avdd and avee
> come from GPIO controlled external regulators, not the SoC and in this case
> there's no need for vddio to power an I/O bus. Similarly the regulators for
> the LCD are controlled by the panel driver not by the dsi-ctrl driver.
>
> It would be possible to connect a different type of panel to the DSI bus
> here in which case we may or may not want to make use of vdd, vdda or
> vddio.
>
> This is also the case for older chipsets like apq8064, msm8916 etc the vdd*
> regulators in the dsi-ctrl block are helpers not dependencies.
>
> Add the description of vdd, vdda and vddio back in for the existing
> upstream dts where vdd, vdda or vddio are already declared but, don't
> declare those regulators required - they are not SoC requirements.
>
> Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
You got here ack, didn't you?
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-12-22 12:03 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-20 12:36 [PATCH v5 00/21] mdss-dsi-ctrl binding and dts fixes Bryan O'Donoghue
2022-12-20 12:36 ` [PATCH v5 01/21] dt-bindings: msm: dsi-controller-main: Fix operating-points-v2 constraint Bryan O'Donoghue
2022-12-20 12:36 ` [PATCH v5 02/21] dt-bindings: msm: dsi-controller-main: Fix power-domain constraint Bryan O'Donoghue
2022-12-20 12:36 ` [PATCH v5 03/21] dt-bindings: msm: dsi-controller-main: Fix description of core clock Bryan O'Donoghue
2022-12-20 12:36 ` [PATCH v5 04/21] dt-bindings: msm: dsi-controller-main: Add compatible strings for every current SoC Bryan O'Donoghue
2022-12-22 11:47 ` Krzysztof Kozlowski
2022-12-22 11:48 ` Krzysztof Kozlowski
2022-12-20 12:36 ` [PATCH v5 05/21] dt-bindings: msm: dsi-controller-main: Deprecate qcom,dsi-ctrl-6g-qcm2290 in favour of qcom,qcm2290-dsi-ctrl Bryan O'Donoghue
2022-12-22 11:50 ` Krzysztof Kozlowski
2022-12-22 12:45 ` Bryan O'Donoghue
2022-12-20 12:36 ` [PATCH v5 06/21] dt-bindings: msm: dsi-controller-main: Document clocks on a per compatible basis Bryan O'Donoghue
2022-12-20 16:49 ` Rob Herring
2022-12-22 11:52 ` Krzysztof Kozlowski
2022-12-20 12:36 ` [PATCH v5 07/21] dt-bindings: msm: dsi-controller-main: Fix clock declarations Bryan O'Donoghue
2022-12-20 16:49 ` Rob Herring
2022-12-22 11:54 ` Krzysztof Kozlowski
2022-12-20 12:36 ` [PATCH v5 08/21] dt-bindings: msm: dsi-controller-main: Add vdd* descriptions back in Bryan O'Donoghue
2022-12-22 11:54 ` Krzysztof Kozlowski [this message]
2022-12-20 12:36 ` [PATCH v5 09/21] dt-bindings: display/msm: Add list of mdss-dsi-ctrl compats Bryan O'Donoghue
2022-12-22 11:57 ` Krzysztof Kozlowski
2022-12-20 12:36 ` [PATCH v5 10/21] dt-bindings: display/msm: Update MDSS dsi compat strings Bryan O'Donoghue
2022-12-22 11:57 ` Krzysztof Kozlowski
2022-12-20 12:36 ` [PATCH v5 11/21] ARM: dts: qcom: apq8064: add compat qcom,apq8064-dsi-ctrl Bryan O'Donoghue
2022-12-20 12:36 ` [PATCH v5 12/21] ARM: dts: qcom: msm8974: Add compat qcom,msm8974-dsi-ctrl Bryan O'Donoghue
2022-12-20 12:36 ` [PATCH v5 13/21] arm64: dts: qcom: msm8916: Add compat qcom,msm8916-dsi-ctrl Bryan O'Donoghue
2022-12-20 12:36 ` [PATCH v5 14/21] arm64: dts: qcom: msm8953: Add compat qcom,msm8953-dsi-ctrl Bryan O'Donoghue
2022-12-20 12:36 ` [PATCH v5 15/21] arm64: dts: qcom: msm8996: Add compat qcom,msm8996-dsi-ctrl Bryan O'Donoghue
2022-12-20 12:36 ` [PATCH v5 16/21] arm64: dts: qcom: sc7180: Add compat qcom,sc7180-dsi-ctrl Bryan O'Donoghue
2022-12-20 12:36 ` [PATCH v5 17/21] arm64: dts: qcom: sc7280: Add compat qcom,sc7280-dsi-ctrl Bryan O'Donoghue
2022-12-20 12:36 ` [PATCH v5 18/21] arm64: dts: qcom: sdm630: Add compat qcom,sdm660-dsi-ctrl Bryan O'Donoghue
2022-12-20 12:36 ` [PATCH v5 19/21] arm64: dts: qcom: sdm660: " Bryan O'Donoghue
2022-12-20 12:36 ` [PATCH v5 20/21] arm64: dts: qcom: sdm845: Add compat qcom,sdm845-dsi-ctrl Bryan O'Donoghue
2022-12-20 12:36 ` [PATCH v5 21/21] arm64: dts: qcom: sm8250: Add compat qcom,sm8250-dsi-ctrl Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbf60b16-9331-64ae-93eb-0a67576adf1f@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=daniel@ffwll.ch \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=robdclark@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sean@poorly.run \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®