From: "H. Nikolaus Schaller" <hns@goldelico.com>
To: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Benoît Cousson" <bcousson@baylibre.com>,
"Tony Lindgren" <tony@atomide.com>,
"Russell King" <linux@armlinux.org.uk>,
"Arnd Bergmann" <arnd@arndb.de>,
"Michael Welling" <mwelling@ieee.org>,
"Mika Penttilä" <mika.penttila@nextfour.com>,
"Javier Martinez Canillas" <javier@osg.samsung.com>,
"Igor Grinberg" <grinberg@compulab.co.il>,
"Sebastian Reichel" <sre@kernel.org>,
"Andrew F. Davis" <afd@ti.com>,
"H. Nikolaus Schaller" <hns@goldelico.com>,
"Mark Brown" <broonie@kernel.org>,
"Jonathan Cameron" <jic23@kernel.org>
Cc: linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
letux-kernel@openphoenux.org, linux-iio@vger.kernel.org,
kernel@pyra-handheld.com
Subject: [PATCH v4 2/8] drivers:input:tsc2007: send pendown and penup only once like ads7846(+tsc2046) driver does
Date: Mon, 17 Oct 2016 15:57:50 +0200 [thread overview]
Message-ID: <dbfd2bb0ea89e6a3aa7fa6d54cfffe338b9771d6.1476712675.git.hns@goldelico.com> (raw)
In-Reply-To: <cover.1476712675.git.hns@goldelico.com>
In-Reply-To: <cover.1476712675.git.hns@goldelico.com>
this should reduce unnecessary input events.
Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
---
drivers/input/touchscreen/tsc2007.c | 17 +++++++++++++----
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git a/drivers/input/touchscreen/tsc2007.c b/drivers/input/touchscreen/tsc2007.c
index c1d9593..e9d5086 100644
--- a/drivers/input/touchscreen/tsc2007.c
+++ b/drivers/input/touchscreen/tsc2007.c
@@ -94,6 +94,7 @@ struct tsc2007 {
wait_queue_head_t wait;
bool stopped;
+ bool pendown;
int (*get_pendown_state)(struct device *);
void (*clear_penirq)(void);
@@ -227,7 +228,11 @@ static irqreturn_t tsc2007_soft_irq(int irq, void *handle)
sx, sy, rt);
/* report event */
- input_report_key(input, BTN_TOUCH, 1);
+ if (!ts->pendown) {
+ input_report_key(input, BTN_TOUCH, 1);
+ ts->pendown = true;
+ }
+
touchscreen_report_pos(ts->input, &ts->prop,
(unsigned int) sx,
(unsigned int) sy,
@@ -250,9 +255,13 @@ static irqreturn_t tsc2007_soft_irq(int irq, void *handle)
dev_dbg(&ts->client->dev, "UP\n");
- input_report_key(input, BTN_TOUCH, 0);
- input_report_abs(input, ABS_PRESSURE, 0);
- input_sync(input);
+ if (ts->pendown) {
+ input_report_key(input, BTN_TOUCH, 0);
+ input_report_abs(input, ABS_PRESSURE, 0);
+ input_sync(input);
+
+ ts->pendown = false;
+ }
if (ts->clear_penirq)
ts->clear_penirq();
--
2.7.3
next prev parent reply other threads:[~2016-10-17 14:01 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-17 13:57 [PATCH v4 0/8] drivers: touchscreen: tsc2007 and ads7846/tsc2046 improvements (use common touchscreen bindings, pre-calibration, spi fix and provide iio raw values) H. Nikolaus Schaller
2016-10-17 13:57 ` [PATCH v4 1/8] drivers:input:tsc2007: add new common binding names, pre-calibration, flipping and rotation H. Nikolaus Schaller
2016-10-18 16:22 ` Rob Herring
2016-10-18 17:27 ` H. Nikolaus Schaller
2016-10-31 3:39 ` Rob Herring
2016-10-17 13:57 ` H. Nikolaus Schaller [this message]
2016-10-17 13:57 ` [PATCH v4 3/8] drivers:input:tsc2007: check for presence and power down tsc2007 during probe H. Nikolaus Schaller
2016-10-17 13:57 ` [PATCH v4 4/8] drivers:input:tsc2007: add iio interface to read external ADC input and temperature H. Nikolaus Schaller
2016-10-22 18:33 ` Jonathan Cameron
2016-10-22 20:46 ` H. Nikolaus Schaller
2016-10-23 9:24 ` Jonathan Cameron
2016-10-23 9:57 ` H. Nikolaus Schaller
2016-10-23 18:34 ` H. Nikolaus Schaller
2016-10-23 19:00 ` Jonathan Cameron
2016-10-23 19:11 ` H. Nikolaus Schaller
2016-10-24 19:14 ` H. Nikolaus Schaller
2016-10-25 16:54 ` Jonathan Cameron
2016-10-23 18:50 ` Jonathan Cameron
2016-10-17 13:57 ` [PATCH v4 5/8] DT:omap3+tsc2007: use new common touchscreen bindings H. Nikolaus Schaller
2016-10-17 13:57 ` [PATCH v4 6/8] drivers:input:ads7846(+tsc2046): add new common binding names, pre-calibration and flipping H. Nikolaus Schaller
2016-10-17 13:57 ` [PATCH v4 7/8] drivers:input:ads7846(+tsc2046): fix spi module table H. Nikolaus Schaller
2016-10-17 15:54 ` Andrew F. Davis
2016-10-17 16:52 ` H. Nikolaus Schaller
2016-10-17 13:57 ` [PATCH v4 8/8] DT:omap3+ads7846: use new common touchscreen bindings H. Nikolaus Schaller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbfd2bb0ea89e6a3aa7fa6d54cfffe338b9771d6.1476712675.git.hns@goldelico.com \
--to=hns@goldelico.com \
--cc=afd@ti.com \
--cc=arnd@arndb.de \
--cc=bcousson@baylibre.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=grinberg@compulab.co.il \
--cc=javier@osg.samsung.com \
--cc=jic23@kernel.org \
--cc=kernel@pyra-handheld.com \
--cc=letux-kernel@openphoenux.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mika.penttila@nextfour.com \
--cc=mwelling@ieee.org \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®