From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f73.google.com (mail-dl1-f73.google.com [74.125.82.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FD98219EB for ; Thu, 8 Jan 2026 22:20:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767910802; cv=none; b=Q4XtDb50A9VtgEGDldrTv21peC2U5V55BYJJbvr5I6eZusSIRKFIVfSFFml5iC073KoTMv0x4YAtW009OlWRszbfaQ9Iq14bYhytBbEGp35QtdE1X/W7GtHLpkiSI/UhWxTO7sNwBJFNzhJ8VKsYKsF5M0NJf/UFssm14wfhZMw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767910802; c=relaxed/simple; bh=5ITqXKWePSx2bg8bCdYwfMtYEz/2moH35vHlKOk6Vzo=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=QDX+hEqe4yXkqo7PDZyL3OSOqRElUeUWXK5QKlAqpVvTpBMLhra41iYXXkuGdI4Mz3ZciHFZbHAIGss6C3SabWKjndSrGd+o+pGn2Vw/cvuaC+JtosYtl8r1tYe8c68Tcei6RX3bY2PvGTRkRqVM1OXiWpPzKxxOqRGVuaMccNQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--ynaffit.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=S//qes+3; arc=none smtp.client-ip=74.125.82.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--ynaffit.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="S//qes+3" Received: by mail-dl1-f73.google.com with SMTP id a92af1059eb24-12175e560b3so4528906c88.0 for ; Thu, 08 Jan 2026 14:20:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1767910800; x=1768515600; darn=vger.kernel.org; h=cc:to:from:subject:message-id:user-agent:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to; bh=bxjSRacv3w5er0RWgoAClaciiig1BHRL5ZKZktfUSLc=; b=S//qes+3izWIiy7mVyFI1Q4CFPpihaZyLVxzi6DWWOFcTjKKckZ53wVNhw6bTx3XaU dag2EoZn8Z8PC1ew92hKrPPFHPCCqtzECk3QRx5z2N4ODWEx9fE/3IZ3jfotkt4ISMph jGwKqv6kFYxg/TG1XPTlcC+jBqcx6eCikGu35uTL6yaKJuVt0vN/dvVkItYpVgfZaCDf x1hUo1CHp02mj6N7HkT8nv5o4HlUoo3wW18vnYa7aEFANf57USN3SKAow5zEX8xrnPNs t11Nx70oZr862pNPaHp4uSsbOQNti5aOzSLGTiH8tCKMwtVShH44b/5YgIypxuhlnBMq A5fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767910800; x=1768515600; h=cc:to:from:subject:message-id:user-agent:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bxjSRacv3w5er0RWgoAClaciiig1BHRL5ZKZktfUSLc=; b=Zr/ip0jw2EOUKASWWNPLBHJlFz2OGe47wZTxwtAYA39ZBF9lQG7vtx0avu1G1T/DST 7qUP6Rpilpd2x7WN++YJMApZ8cp78USHhSbxYagFbgsVnQPT7Mhzo7mQCRMpLuLhMgts GMMbtoCMChUIXbtdruCiaO+jk818UJyAJJIxq87Zhy6zYdAedhCzn93s03+0HiM2Zs14 ZH6WXWzsoZr7JsSkjOdSWv8KquPL81qMfT2S1iyAUhG8A5E90tRLTThTzzsK6y8vu6Ve AYw+xDM+4U9zyPKAvkoRz0rYMbXADHPjZ6Ciic/ycVz/43eFWQgOeS7G6INAGQYcdCNs beBQ== X-Forwarded-Encrypted: i=1; AJvYcCWQr8ZaJxOgLI92uyA8PrFinYfLp3i3VgjN1i21AtcDCPf196v+V6L8UfwBxiUjY1FWj13Gk8zn6uu046s=@vger.kernel.org X-Gm-Message-State: AOJu0YyDYM7st1paCFV2GnBM4L680FLnydxw1HaSUW3ja2hX7kqQ0i80 vw9C78RmD6cld3cosguQmB/LyAzG9AjoHZAP0gIWkQO5WZRDqVdrXQInUT7Ca0I9d8UZT+ouOYx qNf5/aWVbMw== X-Google-Smtp-Source: AGHT+IF+v6/uWmIJwB0eceVf/qyBol3H7EALTIc3xqb2VHJl1Wpvfq7u2x1fIR/JLxi6HhB/9rju4EBWYyGJ X-Received: from dlbuy4.prod.google.com ([2002:a05:7022:1e04:b0:11f:3f33:f0a5]) (user=ynaffit job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7022:2385:b0:11b:c2fd:3960 with SMTP id a92af1059eb24-121f8b46199mr6271092c88.28.1767910800083; Thu, 08 Jan 2026 14:20:00 -0800 (PST) Date: Thu, 08 Jan 2026 14:19:58 -0800 In-Reply-To: <20260108120348.GH302752@google.com> (Lee Jones's message of "Thu, 8 Jan 2026 12:03:48 +0000") Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20251231004510.1732543-2-ynaffit@google.com> <20260108120348.GH302752@google.com> User-Agent: mu4e 1.12.12; emacs 30.1 Message-ID: Subject: Re: [PATCH 5.10,5.15,6.1,6.6 RESEND] leds: spi-byte: Initialize device node before access From: Tiffany Yang To: Lee Jones Cc: Andy Shevchenko , stable@vger.kernel.org, pchelkin@ispras.ru, linux-kernel@vger.kernel.org, kernel-team@android.com, Pavel Machek , linux-leds@vger.kernel.org Content-Type: text/plain; charset="UTF-8"; format=flowed; delsp=yes Lee Jones writes: > On Fri, 02 Jan 2026, Andy Shevchenko wrote: >> On Tue, Dec 30, 2025 at 04:45:11PM -0800, Tiffany Yang wrote: >> > Commit 7f9ab862e05c ("leds: spi-byte: Call of_node_put() on error >> path") >> > was merged in 6.11 and then backported to stable trees through 5.10. It >> > relocates the line that initializes the variable 'child' to a later >> > point in spi_byte_probe(). >> > >> > Versions < 6.9 do not have commit ccc35ff2fd29 ("leds: spi-byte: Use >> > devm_led_classdev_register_ext()"), which removes a line that reads a >> > property from 'child' before its new initialization point. >> Consequently, >> > spi_byte_probe() reads from an uninitialized device node in stable >> > kernels 6.6-5.10. >> I'm wondering if in long term the easier maintenance will be with that >> patch >> also being backported rather than this being applied. > Works for me. Makes sense to me too! Thanks everyone for taking a look, and thanks to Fedor for originally suggesting this :) -- Tiffany Y. Yang