From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f73.google.com (mail-pj1-f73.google.com [209.85.216.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5EB2D2877E5 for ; Tue, 22 Jul 2025 22:41:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753224074; cv=none; b=fMIEvWrmU6BtcMp8ftOAj+7d8wJNpFAaV+0PHffZSucVEsYgedyS5FjwE8OXrCDuVKz4KYksEV11qc2MQbLXqY/lo0oEgxX7A1ATlo3nVVSmT23fIk1lkmmgX4Ywn6h2R77eG+2XweVCglzl5rYmr5tVM+f6eWrQ8+RtQENaHTg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753224074; c=relaxed/simple; bh=RIVO37juCsCqXBzxtTjGZr09W7FZSUQUcewbbNK0LR0=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=NgohcJStkVLmfCHsrMz46sfWoEFCuBc2F15RMU0vKbZ9F2fKHJgVxXwoRoUDc+A77PM0WOPA2JoIeBu469kcDTSTFMHmu3ls4OAgEVdlU7Lshe/Ga1aojASBkfKtaWFKp7eX2mvaOWOd6/I4FiX3LpCICWdX9x/JZmpTJFs/Bcs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--ynaffit.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=cJu9Riqt; arc=none smtp.client-ip=209.85.216.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--ynaffit.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="cJu9Riqt" Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-31cb5cc3edcso5128763a91.0 for ; Tue, 22 Jul 2025 15:41:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1753224072; x=1753828872; darn=vger.kernel.org; h=cc:to:from:subject:message-id:user-agent:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to; bh=ZOYa7ZEGNBK60fTKVSOtfx+dioBHWECsFxuIzKb+U7o=; b=cJu9RiqtZLXnZa1yPlljl+GNIs797jBnDS69KJ3Mc66ZgfictHywvc6e6vdEfbiNCe wB/Or2tCMONKmt3GcunU0pRyrR58mDasKeCf1XD1NBi6UFZ8XbDaIxxPRfCt+ATEVrn6 UQe8OENDogJ0o5/hYy3TxHEq2f6gtfqpOb71JXQ+Yuj9i2JkGtAsdwzmgRUHKUMJHzM4 Uzs8UE5oO5+EtUJYwZP6oj7eZFKJg06THxS12YajvCdiriY9tGNG3foTn4KOJiChjrQM Igjc8jCMPipuHOe779tlDVEqZVSiO+oAO/CVsDT6sKtfanHh2kaJqiviH7ykLyhIIRbX MOOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753224072; x=1753828872; h=cc:to:from:subject:message-id:user-agent:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZOYa7ZEGNBK60fTKVSOtfx+dioBHWECsFxuIzKb+U7o=; b=bt4D0vE7Y3yiGwwH63XvdnXpgZYCpkXNF6p3qE6lsWIL383i6edgI2qC0d3wRg75xw Bu9k+4/YVpamhfWnE9IsHNYaI1ta9KK9Y/UL283EEyZ/BKAFl64JofwhKJHnuQqT3xNc VV1UAlsd4EOfTgbj+a/KsEU7rqt7GYMom1FjqBiS4NNvtUxX6P1qKhvU0dRAZJqmhhWH /x1ZgoM70+4TyQ8nuiLHiGqyes0hHKx9HFS435oq5oNdUYCDjiiDoa+vYQFpULvN5VW1 0yriw11xtLa7X2dYvu2BvSnlqCzzlAFuIAEiFJeQ+iNrcg+CelHbg6SVb0bfBDC6vIoN UQ9Q== X-Forwarded-Encrypted: i=1; AJvYcCVCo4WltdLe3zQEIshgC+fBcJuUaBdAMmkSo1emOU8BdDIJ6QhnTnav9tmEkVpAnCQR1IS5X0X+x3M8JEE=@vger.kernel.org X-Gm-Message-State: AOJu0YxKl4t1orhWRBex+xCEk3MeQ2zfb4NNfLy8uNyqSWKohl/9Z11I Yfu3Tx9au5m9zx5KFGNk0itOLCzBUd4JosskMBnbR0pDCEvaYmPo2iu95vEMvBzNAvD+g6jajeM FSNRIbT3OPw== X-Google-Smtp-Source: AGHT+IEQDJG0XdYJdm4y/wzvyxG233Rn2TkKUiTzy/vJJmjMYQfTNdCOJXvVMg3gnXeY82hjHaO1NgRYqbs+ X-Received: from pji6.prod.google.com ([2002:a17:90b:3fc6:b0:313:2213:1f54]) (user=ynaffit job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:1f8c:b0:313:283e:e881 with SMTP id 98e67ed59e1d1-31e506ef4f7mr1324033a91.11.1753224072599; Tue, 22 Jul 2025 15:41:12 -0700 (PDT) Date: Tue, 22 Jul 2025 15:41:11 -0700 In-Reply-To: (Tejun Heo's message of "Thu, 17 Jul 2025 07:06:10 -1000") Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250714050008.2167786-2-ynaffit@google.com> <5rm53pnhpdeqljxqywh26gffh6vlyb5j5s6pzxhv52odhkl4fm@o6p7daoponsn> <6c9278b7-4eb4-4b47-b61a-a5bcc7e558b0@huaweicloud.com> User-Agent: mu4e 1.12.9; emacs 30.1 Message-ID: Subject: Re: [RFC PATCH v2] cgroup: Track time in cgroup v2 freezer From: Tiffany Yang To: Tejun Heo Cc: Chen Ridong , "Michal =?utf-8?Q?Koutn?= =?utf-8?Q?=C3=BD?=" , linux-kernel@vger.kernel.org, John Stultz , Thomas Gleixner , Stephen Boyd , Anna-Maria Behnsen , Frederic Weisbecker , Johannes Weiner , "Rafael J. Wysocki" , Pavel Machek , Roman Gushchin , Chen Ridong , kernel-team@android.com, Jonathan Corbet , cgroups@vger.kernel.org, linux-doc@vger.kernel.org Content-Type: text/plain; charset="UTF-8"; format=flowed; delsp=yes Tejun Heo writes: > On Thu, Jul 17, 2025 at 09:52:38PM +0800, Chen Ridong wrote: >> > With the given implementation (and use scenario), this'd better exposed >> > in >> > cgroup.freeze.stat.local >> > >> Would it be possible to add this field to either cgroup.event or >> cgroup.stat? >> Since the frozen status is already tracked in cgroup.event, this >> placement would maintain better >> cohesion with existing metrics. >> This is just a suggestion. > Yeah, given that the freezer is an integral part of cgroup core, using > cgroup.stat[.local] probably makes more sense. > Thanks. One of the reasons I avoided cgroup.stat was because I interpreted its purpose to be for exposing cgroup metadata (i.e., descendants and descendants per subsystem), and I didn't think this value fit in neatly. It doesn't seem like there currently exists a cgroup.stat.local, but if that is the preferred location for this accounting, I could create one and print it there! -- Tiffany Y. Yang