mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: Leo Yan <leo.yan@arm.com>
Cc: Mike Leach <mike.leach@arm.com>,
	James Clark <james.clark@linaro.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Mao Jinlong <quic_jinlmao@quicinc.com>,
	coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 0/8] coresight: Fix device registration and unregistration
Date: Tue, 24 Feb 2026 11:16:16 +0000	[thread overview]
Message-ID: <dc00fe4d-22b5-468a-a7b1-452304fac12c@arm.com> (raw)
In-Reply-To: <20260224110659.GA4184494@e132581.arm.com>

On 24/02/2026 11:06, Leo Yan wrote:
> On Mon, Feb 23, 2026 at 01:28:03PM +0000, Suzuki K Poulose wrote:
> 
> [...]
> 
>> [  827.216924]  Possible unsafe locking scenario:
>> [  827.216924]
>> [  827.222849]        CPU0                    CPU1
>> [  827.227380]        ----                    ----
>> [  827.231912]   lock(coresight_mutex);
>> [  827.235491]                                lock(ect_mutex);
>> [  827.241073]                                lock(coresight_mutex);
>> [  827.247176]   lock(ect_mutex);
>> [  827.250233]
>> [  827.250233]  *** DEADLOCK ***
> 
> Thanks for the test, Suzuki.
> 
> I have sent a refactor patch to dismiss locking chain:
> https://lore.kernel.org/linux-arm-kernel/20260224-arm_coresight_refactor_cti_resource_release-v1-1-ff1b2bca9176@arm.com/T/#u
> 
> For recording, I enabled the following configs to reproduce the lockdep
> report:
> 

Thanks for the patch, I can confirm that it fixes the problem and is
indeed a good cleanup. Hacking the device release operation wasn't
really a good idea.

Cheers
Suzuki



>    CONFIG_LOCKUP_DETECTOR
>    CONFIG_PROVE_LOCKING
> 
> Thanks,
> Leo


  reply	other threads:[~2026-02-24 11:17 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-09 12:44 Leo Yan
2026-02-09 12:44 ` [PATCH v4 1/8] coresight: Fix memory leak in coresight_alloc_device_name() Leo Yan
2026-02-09 12:44 ` [PATCH v4 2/8] coresight: Get parent device reference after sink ID map allocation Leo Yan
2026-02-09 12:44 ` [PATCH v4 3/8] coresight: Protect unregistration with mutex Leo Yan
2026-02-09 12:44 ` [PATCH v4 4/8] coresight: Refactor output connection sysfs link cleanup Leo Yan
2026-02-09 12:44 ` [PATCH v4 5/8] coresight: Refactor sysfs connection group cleanup Leo Yan
2026-02-09 12:44 ` [PATCH v4 6/8] coresight: Move sink validation into etm_perf_add_symlink_sink() Leo Yan
2026-02-09 12:44 ` [PATCH v4 7/8] coresight: Do not mix success path with failure handling Leo Yan
2026-02-09 12:44 ` [PATCH v4 8/8] coresight: Unify bus unregistration via coresight_unregister() Leo Yan
2026-02-17 14:51   ` James Clark
2026-02-23 13:28 ` [PATCH v4 0/8] coresight: Fix device registration and unregistration Suzuki K Poulose
2026-02-24 11:06   ` Leo Yan
2026-02-24 11:16     ` Suzuki K Poulose [this message]
2026-02-25 14:29 ` Suzuki K Poulose

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dc00fe4d-22b5-468a-a7b1-452304fac12c@arm.com \
    --to=suzuki.poulose@arm.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=coresight@lists.linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=james.clark@linaro.org \
    --cc=leo.yan@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=mike.leach@arm.com \
    --cc=quic_jinlmao@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®