From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: Jonas Jelonek <jelonek.jonas@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"Bjørn Mork" <bjorn@mork.no>
Subject: Re: [PATCH net-next v5] net: sfp: extend SMBus support
Date: Fri, 16 Jan 2026 15:00:49 +0100 [thread overview]
Message-ID: <dc0531a3-b9b9-4b51-8ce7-f03e23ea0877@bootlin.com> (raw)
In-Reply-To: <6987689b-35ac-4c15-addb-1c8e54144fa7@gmail.com>
On 16/01/2026 14:43, Jonas Jelonek wrote:
> Hi,
>
> On 16.01.26 14:23, Maxime Chevallier wrote:
>> I think Russell pointed it out, but I was also wondering the same.
>> How do we deal with controllers that cannot do neither block nor
>> single-byte, i.e. that can only do word access ?
>>
>> We can't do transfers that have an odd length. And there are some,
>> see sfp_cotsworks_fixup_check() for example.
>>
>> Maybe these smbus controller don't even exist, but I think we should
>> anyway have some log saying that this doesn't work, either at SFP
>> access time, or at init time.
>
> I tried to guard that in the sfp_i2c_configure() right now. The whole path
> to allow SMBus transfers is only allowed if there's at least byte access. For
> exactly the reason that we need byte access in case of odd lengths. Then,
> it can upgrade to word or block access if available. Or did I miss anything in
> the conditions?
Ah true, true. Should you need to respin, maybe add a comment for
clueless people like myself :)
I'll see if I can give this a test today then
Thanks
Maxime
next prev parent reply other threads:[~2026-01-16 14:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-16 11:31 Jonas Jelonek
2026-01-16 13:23 ` Maxime Chevallier
2026-01-16 13:43 ` Jonas Jelonek
2026-01-16 14:00 ` Maxime Chevallier [this message]
2026-01-16 14:07 ` Andrew Lunn
2026-01-16 14:16 ` Maxime Chevallier
2026-01-16 14:25 ` Andrew Lunn
2026-01-18 9:43 ` Jonas Jelonek
2026-01-18 10:08 ` Russell King (Oracle)
2026-01-18 15:36 ` Andrew Lunn
2026-01-18 15:39 ` Andrew Lunn
2026-01-22 10:14 ` Jonas Jelonek
2026-01-22 16:04 ` Andrew Lunn
2026-01-22 16:22 ` Russell King (Oracle)
2026-01-16 13:57 ` Russell King (Oracle)
2026-01-19 19:41 ` [net-next,v5] " Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc0531a3-b9b9-4b51-8ce7-f03e23ea0877@bootlin.com \
--to=maxime.chevallier@bootlin.com \
--cc=andrew@lunn.ch \
--cc=bjorn@mork.no \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=jelonek.jonas@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®