From: Dawid Wrobel <me@dawidwrobel.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Jianhua Lu <lujianhua000@gmail.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Jessica Zhang <jesszhan0024@gmail.com>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 4/4] arm64: dts: qcom: sm8250: add device tree for the Xiaomi Mi Pad 5 Pro 5G
Date: Tue, 08 Sep 2026 16:04:03 +0000 [thread overview]
Message-ID: <dc0759da-5783-4800-bdf1-9ddca0f2c851@dawidwrobel.com> (raw)
In-Reply-To: <1cdfb3e1-8a89-4b52-a5db-0359a9f68878@oss.qualcomm.com>
On 18.08.2026 12:48, Konrad Dybcio wrote:
>> + * Copyright (c) 2025 Dawid Wróbel <me@dawidwrobel.com>
>
> Happy new year!
Hah, indeed!
>> + status = "okay";
>
> ultra nit: \n before status is preferred
Thank you for the review. Both fixed in v3, which I just sent out:
https://lore.kernel.org/r/20260908-sm8250-xiaomi-enuma-v3-0-0198c3bf954a@dawidwrobel.com
Note that v2 had been on the list for two weeks when you reviewed this
one, so it may have slipped past you. It folds the WiFi-label patch into
this one per Krzysztof's feedback. I *did* carry your Reviewed-by onto
the v3 patch, though — let me know if you'd rather take another look on
that fold.
--
With Kind Regards,
Dawid Wrobel
prev parent reply other threads:[~2026-09-08 16:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-30 21:51 [PATCH 0/4] arm64: dts: qcom: add " Dawid Wróbel via B4 Relay
2026-07-30 21:52 ` [PATCH 1/4] dt-bindings: display: panel: novatek,nt36523: add the Mi Pad 5 Pro 5G panel Dawid Wróbel via B4 Relay
2026-08-04 8:10 ` Krzysztof Kozlowski
2026-07-30 21:52 ` [PATCH 2/4] dt-bindings: arm: qcom: add the Xiaomi Mi Pad 5 Pro 5G Dawid Wróbel via B4 Relay
2026-08-04 8:09 ` Krzysztof Kozlowski
2026-07-30 21:52 ` [PATCH 3/4] arm64: dts: qcom: sm8250-xiaomi-elish: label the WiFi node Dawid Wróbel via B4 Relay
2026-08-04 8:10 ` Krzysztof Kozlowski
2026-07-30 21:52 ` [PATCH 4/4] arm64: dts: qcom: sm8250: add device tree for the Xiaomi Mi Pad 5 Pro 5G Dawid Wróbel via B4 Relay
2026-08-18 10:48 ` Konrad Dybcio
2026-09-08 16:04 ` Dawid Wrobel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc0759da-5783-4800-bdf1-9ddca0f2c851@dawidwrobel.com \
--to=me@dawidwrobel.com \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jesszhan0024@gmail.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lujianhua000@gmail.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®