From: David Lechner <david@lechnology.com>
To: Archit Anant <architanant5@gmail.com>
Cc: maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch,
javierm@redhat.com, nathan@kernel.org, geert+renesas@glider.be,
marcus.folkesson@gmail.com, noralf@tronnes.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] drm/sitronix: add ST7789V panel driver
Date: Sun, 15 Feb 2026 16:45:06 -0600 [thread overview]
Message-ID: <dc0b7b09-d6a2-4e14-904a-d26396998529@lechnology.com> (raw)
In-Reply-To: <CADJHxWDgARMDXCKJ+F+z2mOooqxptPfjbYk2dVG38scZ7hNSaA@mail.gmail.com>
On 2/14/26 11:21 PM, Archit Anant wrote:
> Hi David,
>
>> Do we actually need a custom driver for these or can we use
>> drivers/gpu/drm/tiny/panel-mipi-dbi.c with a firmware file for
>> init?
>
> That was my initial thought as well, but looking at the staging driver
> (fb_st7789v.c), there is conditional logic in the initialization sequence.
>
> The HSD20_IPS panel requires different PORCTRL (0xB2), GCTRL (0xB7), and
> Gamma (0xE0/E1) settings compared to the standard panel. A static
> firmware blob via panel-mipi-dbi would not allow selecting between
> these configurations based on the compatible string, so a dedicated
> driver seemed necessary to preserve this support.
>
> Best regards,
> Archit
If two different panels are not 100% compatible with each other, they
should not have the same compatible string.
It seems like it would be much more efficient to fix the existing
devicetree/driver if needed rather than writing an entire new driver.
next prev parent reply other threads:[~2026-02-15 22:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-14 7:01 Archit Anant
2026-02-14 13:05 ` Chen-Yu Tsai
2026-02-15 5:34 ` Archit Anant
2026-02-16 7:47 ` Javier Martinez Canillas
2026-02-16 15:38 ` Archit Anant
2026-02-19 10:10 ` Thomas Zimmermann
2026-02-19 15:52 ` Archit Anant
2026-02-14 16:02 ` David Lechner
2026-02-15 5:21 ` Archit Anant
2026-02-15 22:45 ` David Lechner [this message]
2026-02-16 15:35 ` Archit Anant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc0b7b09-d6a2-4e14-904a-d26396998529@lechnology.com \
--to=david@lechnology.com \
--cc=airlied@gmail.com \
--cc=architanant5@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert+renesas@glider.be \
--cc=javierm@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marcus.folkesson@gmail.com \
--cc=mripard@kernel.org \
--cc=nathan@kernel.org \
--cc=noralf@tronnes.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®