From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABFC238D for ; Fri, 13 Feb 2026 00:47:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770943677; cv=none; b=ZLa/5Np4/2JpclxtMj9lNq0NzWREeipGLW1KGPJ3YMlWrOHvs3Xu6RfW+x2ESmdcrN6mV9qRQfaWfLoyH/JyX2DdbYs26Rvo24on5hMB5rmsL6n7PI72hPkMas1f2BKohxPlzz1IPE1UJKPyJ0RPkxIG+vBPorY+qsu/hTeXcMA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770943677; c=relaxed/simple; bh=zfSiBcLazIynr5sXbeIkNtmCGB4aLsxJUl0aqwBD0pI=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=tZmuwPGYGp68kPylCA/ZbZdNNandhkHAnlxWyZt2gn4wxEurZHEf4lZyDXFGCtilmEKmkPI6tsHp4upgIoBIBZ7fu/nW6iZCy+wymJLsvdmWtbqHTsVXXV8WMexZcFR03Xncgc0sAkqY/F4OaOS+44Fsw9SZHyyu3VJtmiPEnAE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ADXZcTj4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ADXZcTj4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C4FA8C4CEF7; Fri, 13 Feb 2026 00:47:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770943677; bh=zfSiBcLazIynr5sXbeIkNtmCGB4aLsxJUl0aqwBD0pI=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=ADXZcTj4Z0q4tdVCbc69RcZZhltrgBHUD8NsDbPylatsXoPQcnwwDlfN7LkuptTu1 pdwdZ7bf5xdEAT12ToWZTfMWSYlcuvvfRJ/QFgVF/Wn8j3RJqJ+n3PTKgcQDdGOFN7 Zy3Trt73LMLtPB1rv+lQGsPwe6L9t+7vWwA/YoeiMpIgX7PKclyVJQZ9rCpxhEDR9e Z1XAbDGWb7SL00qascOxKf4OaxggXD7JKKpxRrEdpAO8+vn7ab3VeaDzbEblqBiaaq gmdnUyUm/cQSSMFH/BuGCisSCXotRmMF0M7uWB3S8NYb5eG0ewCUVzLaTFTNhhDNjL 7tvpFL4QiGrgw== Date: Thu, 12 Feb 2026 17:47:56 -0700 (MST) From: Paul Walmsley To: Austin Kim cc: Paul Walmsley , Palmer Dabbelt , Alexandre Ghiti , linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH] riscv: kdump: return early for invalid 'crashkernel=0' input In-Reply-To: Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Hi, On Fri, 6 Feb 2026, Austin Kim wrote: > From: Austin Kim > > An invalid 'crashkernel=0' can be specified when running kdump. > By adding a check for 'crashkernel=0', it can return early when detecting > this invalid input. > > Signed-off-by: Austin Kim > --- > arch/riscv/mm/init.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c > index 811e03786..e61fec445 100644 > --- a/arch/riscv/mm/init.c > +++ b/arch/riscv/mm/init.c > @@ -1409,7 +1409,8 @@ static void __init arch_reserve_crashkernel(void) > ret = parse_crashkernel(boot_command_line, memblock_phys_mem_size(), > &crash_size, &crash_base, > &low_size, NULL, &high); > - if (ret) > + /* invalid value specified or 'crashkernel=0' */ > + if (ret || !crash_size) > return; > > reserve_crashkernel_generic(crash_size, crash_base, low_size, high); Should this fix the common code in kernel/crash_reserve.c to return an error code when crashkernel=0 so it benefits other architectures? - Paul