From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965971AbcHBOvR (ORCPT ); Tue, 2 Aug 2016 10:51:17 -0400 Received: from mail-oi0-f65.google.com ([209.85.218.65]:36127 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934524AbcHBOuh (ORCPT ); Tue, 2 Aug 2016 10:50:37 -0400 Subject: Re: [PATCH 0829/1285] Replace numeric parameter like 0444 with macro To: Baole Ni , konrad.wilk@oracle.com, boris.ostrovsky@oracle.com, david.vrabel@citrix.com, jgross@suse.com, bhelgaas@google.com, m.chehab@samsung.com, pawel@osciak.com, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com References: <20160802115027.5246-1-baolex.ni@intel.com> Cc: chuansheng.liu@intel.com, linux-pcmcia@lists.infradead.org, linux-kernel@vger.kernel.org From: Larry Finger Message-ID: Date: Tue, 2 Aug 2016 09:50:23 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <20160802115027.5246-1-baolex.ni@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/02/2016 06:50 AM, Baole Ni wrote: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the corresponding macro, > and that using macro can improve the robustness and readability of the code, > thus, I suggest replacing the numeric parameter with the macro. > > Signed-off-by: Chuansheng Liu > Signed-off-by: Baole Ni I'm not sure how much these changes improve robustness and/or readability, but they cause no harm. For that reason, the changes in rtlwifi drivers is acked. Acked-by: Larry Finger Larry > --- > drivers/pcmcia/cistpl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pcmcia/cistpl.c b/drivers/pcmcia/cistpl.c > index 55ef7d1..ac6f619 100644 > --- a/drivers/pcmcia/cistpl.c > +++ b/drivers/pcmcia/cistpl.c > @@ -57,7 +57,7 @@ static const u_int exponent[] = { > > /* 16-bit CIS? */ > static int cis_width; > -module_param(cis_width, int, 0444); > +module_param(cis_width, int, S_IRUSR | S_IRGRP | S_IROTH); > > void release_cis_mem(struct pcmcia_socket *s) > { >