From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C24D0261B8A for ; Mon, 8 Dec 2025 05:41:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765172477; cv=none; b=rTbjX439EzDTF/ri9mzdJ7C6zi4vQ/y66Nbn8UcRHw1/tu7nnKmod1GBn7TtEHj0oX36KFgZpGs0ihUYMVdtgUHEKuJDy+LnntZq84MtY7dMrryAWYc9MbWwrjNIUMQmkIy+ZQzsPFzPUg8TdFsOMgIdDwL4T6kh+MLyU1An1bg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765172477; c=relaxed/simple; bh=985896D1EG3WIv20THJ7bMeGE4yAYGM9Q92uY8qMyOw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=l567GU0nn+m+p/Za9FepDHCelUDLQ9EaSPLjWY9cINqnPM+hQzDUbqPVMapcLYTt5aBWThPAX1g5JYQK6NhddaAzVHXtYD5tX7gRh1544AcQMfrQcv+Shvx62HWbY35UypejOXHWJY3877FkavzlvPr6XKKD+uAjN70QfjyDKn0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=lw9CaUgK; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fFCj9x89; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="lw9CaUgK"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fFCj9x89" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B7NdtbA3185589 for ; Mon, 8 Dec 2025 05:41:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= nAgZDB+WL8BEuCWKxtSRY/sz0RcMKBtlpfHXa5SzQE0=; b=lw9CaUgKo6MjbIVj eQQZ9V+HfHDnDBvX5HyE86p69d0gbyFS0bnRNYprfNeA4WZGijqxFTV3sY+xisXr glZUdumrlYIft0gC0GuIli9X8ZjvMREQzPFm2WaY1DuWzXJWFOnoFJK8+9SeGQfy SnwvQsiXRpyA89T8bM98EeFRkORpSZmYMNWvD5dpBrysW6LffBarKuyLlMaFFZ5R zi+bS6DirPtQwZHBAuhary9uVUinqGcFXlN1VXEtvhlDFZWDzh5xwmjShkKB4BCG rWIKo305SBBw4Dc61E1uuoEzKKgUi/QKv0iXU2jAIh8YUY/kBS/fm8sfIX7u4hF7 hCIBNA== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4avd8e3nw2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 08 Dec 2025 05:41:14 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-bf06c3426b7so7315035a12.3 for ; Sun, 07 Dec 2025 21:41:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1765172474; x=1765777274; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=nAgZDB+WL8BEuCWKxtSRY/sz0RcMKBtlpfHXa5SzQE0=; b=fFCj9x89AlVCdWm9wGUCL7GaG/BZX6wLg4nphS3UhOR8DsPq9SGl98xY3sxmzCfaVe dEyNIE8qxXh0oSoL5IuJMaZhvC71CBegEKTSSDr66o8u58fnf9xabL5sqJREV3hb8+HA NZlWPIpVOiADUni0MiG0sohUaGmk9w478gxowyLUq4igPuIiTTraCmEoVHxgtHVagLTX 95WdamuKQyaeinTSB/eH0lPUXI/oRlsXDSFY89+OzHEP9yDFtn+wsljXlEkuidk71byz BXMb0Hgw/dyXKR9HQWZ6raAq39EIdo35KT9dNWpvSS+ba/oPvglx/W4jK9Y0wlIdYsQ8 Qb7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765172474; x=1765777274; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nAgZDB+WL8BEuCWKxtSRY/sz0RcMKBtlpfHXa5SzQE0=; b=fewlKZYnW9IHjcrCiQPUP2U2BIC1hY1Vt/TvACBAUHBfcgMWVWDatsk0jd7P9Hjtzp pDgLpNkFSwiYGYLEzOoEoeYAF4/ZZl13TZEfdzxSO7xvpEr74A9hGm6b3zD4HTVZX4mf 7WjhROo8zOMXdsDf8SmhUhlszhiI9IXAa7jS8I/SQFfFD3HDnmcMy1DJTls7bli/v/+M qmVhU+8uYQQDbxUJySyfmPRZ4CX0zolrlowq1r7pOLOwVg+XS87fXnQzJuvvwsaEUQOX uZH+sL+B+t1rIi3UUf2g+BZnhlNOsA+QSnU3OSn/6AGz1J0PuqQoaLpysev4vqXucya/ sYFw== X-Forwarded-Encrypted: i=1; AJvYcCUqbqVeJ+TPSiwIhzkfvLglSsvU+zdwUf3T6v9uskB3VAvfSmr2Hvyicu3LmkKPa4csJyuVWXYYUQbYuxA=@vger.kernel.org X-Gm-Message-State: AOJu0Ywtqq4XrVSRGCKNob56ScIeHN2QILeRN745DGHcd+i+44QQZnlZ 1C1OqUyTNSYSsOlWu+OjZVMkcXK1gSWB73GgFZa+Yq1b1za7MpNaeCKPQMWxbnpK5vQ3MZJH0hN 3FcqiJ3YW3NWxYXKk4puVRqODgILo9JLfr3+Ha6Gm0wJsua2RanuusdneM84fvI87Vcw= X-Gm-Gg: ASbGnctv7LZEmhYEVmBURCD3iJVidc7qzNZS3ZZtjVW+dzOIMJdW60z6dCTv7GbPr8w COTjnJy+X5fmkGERHxobuAAw4tnKEK5gat1PFcpvmxBqSXDguIA0nzFd740I6bs/e1MdC0FPMaU zTj7lZiegdWiya/ciu9kZIcMLsqLPmZDW5SBk/sKJzkRuhZOaMk1HHjLz4u+qwdZH6BdM6uThwF M+Ta9iZvXNJULtgYVIvc8WVaHjkhpQeLAnBmDtTIW+0Zp4p08efRsnNYw69+596I7IJQ79MK+TP 7quCOCxvJWkzHbXhyqBo3cAd06Jy6J6/1FBNZHnDpiQBIzyHaTt4KGskYSDKeZPXFBm7IzUnE63 oSScv8J84ds/rHgnCZyc9069cS+wy+Tl24318sdX2 X-Received: by 2002:a05:7301:162b:b0:2ab:ca55:89ad with SMTP id 5a478bee46e88-2abca5598e7mr2701761eec.40.1765172473981; Sun, 07 Dec 2025 21:41:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IH0eZZECCjKhYlXrxylmiZXDhZKDt1q/a8sPEBGZ/dNfFaGi4tnfcHdhR4jarbtU6StoEW8pA== X-Received: by 2002:a05:7301:162b:b0:2ab:ca55:89ad with SMTP id 5a478bee46e88-2abca5598e7mr2701743eec.40.1765172473360; Sun, 07 Dec 2025 21:41:13 -0800 (PST) Received: from [192.168.1.57] ([98.148.145.183]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2aba822b615sm32322187eec.0.2025.12.07.21.41.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 07 Dec 2025 21:41:13 -0800 (PST) Message-ID: Date: Sun, 7 Dec 2025 21:41:11 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 1/5] media: dt-bindings: Add CAMSS device for Kaanapali To: Dmitry Baryshkov , Bryan O'Donoghue Cc: Hangxiang Ma , Loic Poulain , Robert Foss , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Todor Tomov , Vladimir Zapolskiy , Mauro Carvalho Chehab , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, aiqun.yu@oss.qualcomm.com, tingwei.zhang@oss.qualcomm.com, trilok.soni@oss.qualcomm.com, yijie.yang@oss.qualcomm.com, Jingyi Wang , Atiya Kailany , Krzysztof Kozlowski References: <20251130-add-support-for-camss-on-kaanapali-v8-0-143a8265e6e8@oss.qualcomm.com> <20251130-add-support-for-camss-on-kaanapali-v8-1-143a8265e6e8@oss.qualcomm.com> <2tvkcuipfaa7cn7goynt6jfzlcxg2d7yvvjqizb6p7sf5oqwuj@drqiyr3khoyf> Content-Language: en-US From: Vijay Kumar Tumati In-Reply-To: <2tvkcuipfaa7cn7goynt6jfzlcxg2d7yvvjqizb6p7sf5oqwuj@drqiyr3khoyf> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjA4MDA0NiBTYWx0ZWRfX69X+Peq/x9NJ dk/+iqwirBfAPhmiLd9obEiBBFdqtaDFs15XkHYwerlOGbtgKTQk6V+NSlNaIuovqPEXpWqo0mh bdJID/uORGarEgSdY4kleYyudAySpXKfc09qIbX6Hy94TXcYgfeKeQb4HFncEzxTNATyNfOK5d4 WjGTW3ZUzmwGGNyXOIN2DhIGhj2TmQJVgCZogPlGw3iDFzK3GEvy8Zl1VLHEam49uTPJAp4/z7k 2s9SGbkyFcNPEmlp7nrN8X+ZDgBVwfyNuMyo9olk3vz1C3enMT5e+swCWk4tJoJqDfrbgF421i3 eMK1Wl3N6SO4RGDM6qzsNz8U8f5VvnDST92CvcCLkm/E3McO8DvCKmNUWra/uH0ZgV+QZHs/zmi XRlk74LEDuVJnCbNtmV5shyBiLoh6Q== X-Authority-Analysis: v=2.4 cv=BqaQAIX5 c=1 sm=1 tr=0 ts=693664fa cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=BiHMn5M11h/vNwziJwzFrg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=xq3W2uTSAAAA:8 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=VwQbUJbxAAAA:8 a=nMuhoS2BBV4FeKdUb5oA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=3WC7DwWrALyhR5TkjVHa:22 a=P5L7wpMTXyg1GfFA3Gwx:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: D6ebzaCI6iGHRx2o0oXyECM-Ta8eJid8 X-Proofpoint-ORIG-GUID: D6ebzaCI6iGHRx2o0oXyECM-Ta8eJid8 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-06_02,2025-12-04_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015 phishscore=0 spamscore=0 lowpriorityscore=0 impostorscore=0 adultscore=0 priorityscore=1501 bulkscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512080046 On 12/7/2025 5:44 PM, Dmitry Baryshkov wrote: > On Sat, Dec 06, 2025 at 10:11:20PM +0000, Bryan O'Donoghue wrote: >> On 01/12/2025 06:30, Hangxiang Ma wrote: >>> Add the compatible string "qcom,kaanapali-camss" to describe the Camera >>> Subsystem (CAMSS) on the Qualcomm Kaanapali platform. >>> >>> The Kaanapali platform provides: >>> - 3 x VFE, 5 RDI per VFE >>> - 2 x VFE Lite, 4 RDI per VFE Lite >>> - 3 x CSID >>> - 2 x CSID Lite >>> - 6 x CSIPHY >>> - 2 x ICP >>> - 1 x IPE >>> - 2 x JPEG DMA & Downscaler >>> - 2 x JPEG Encoder >>> - 1 x OFE >>> - 5 x RT CDM >>> - 3 x TPG >>> >>> Reviewed-by: Bryan O'Donoghue >>> Reviewed-by: Krzysztof Kozlowski >>> Signed-off-by: Hangxiang Ma >>> --- >>> .../bindings/media/qcom,kaanapali-camss.yaml | 647 +++++++++++++++++++++ >>> 1 file changed, 647 insertions(+) >>> >>> + - const: gcc_hf_axi >> https://patchwork.linuxtv.org/project/linux-media/patch/20251126-add-support-for-camss-on-sm8750-v1-2-646fee2eb720@oss.qualcomm.com/ >> >> Pointed out by Krzysztof in the 8750 patches but the name of this clock is >> gcc_axi_hf. >> >> ~/Development/worktree/qcom-linux-next >> ➞ grep gcc_axi_hf * -r | wc -l [git:platform-qcom-next] ✖ >> 48 >> >> ~/Development/worktree/qcom-linux-next >> ➞ grep gcc_hf_axi * -r | wc -l [git:platform-qcom-next] ✖ >> 0 > My 2c: it should be none of those. gcc_axi_hf is the _source_ of the > clock, while the bindings (in my opinion) should be describing the > function of the clock on the consumer side (e.g. bus, iface, something > else, etc). Hi Dmitry, this is MMNOC side of the AXI bus clock for the HF clients. If it's ok, we can change it to be consistent with previous generations for KNP and we can take it up in detail when we refactor the bindings for Hawi? Please let me know if you have a strong opinion on this at this point and we can discuss accordingly. Hi Bryan, we are addressing the things that makes sense for KNP as well in the next revision. Btw, couple things like a separate CSIPHY DT node and ordering of the resources (that were to be added at the end as you advised), I believe are not relevant for KNP. As for the GDSC names, we preferred the module name and it's GDSC name to be consistent so changed the latter as well to VFE. Hope that's ok. Please let us know if you would suggest any further changes to KNP v9 bindings and we can move forward accordingly. Thank you both. >> Please resolve the other inconsitencies pointed out by Krzysztof in that >> thread here also. >> >> I will have to skip application of this series in the meantime. >> >> --- >> bod