mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Michael Ellerman" <michael@ellerman.id.au>
To: akepner@sgi.com
Cc: "Tony Luck" <tony.luck@intel.com>,
	"Jesse Barnes" <jbarnes@virtuousgeek.org>,
	"Jes Sorensen" <jes@sgi.com>,
	"Randy Dunlap" <randy.dunlap@oracle.com>,
	"Roland Dreier" <rdreier@cisco.com>,
	"James Bottomley" <James.Bottomley@hansenpartnership.com>,
	"David Miller" <davem@davemloft.net>,
	"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
	"Grant Grundler" <grundler@parisc-linux.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3 v3] dma/ia64: update ia64 machvecs
Date: Fri, 29 Feb 2008 13:46:15 +1100	[thread overview]
Message-ID: <dc1166600802281846m26865caw677ea9c9bb0722ca@mail.gmail.com> (raw)
In-Reply-To: <20080228032541.GT11012@sgi.com>

On Thu, Feb 28, 2008 at 2:25 PM,  <akepner@sgi.com> wrote:
>
>  Change all ia64 machvecs to use the new dma_{un}map_*_attrs()
>  interfaces. Implement the old dma_{un}map_*() interfaces in
>  terms of the corresponding new interfaces. For ia64/sn, make
>  use of one dma attribute, DMA_ATTR_SYNC_ON_WRITE.
>
>  Signed-off-by: Arthur Kepner <akepner@sgi.com>
>
>  ---
>
>   arch/ia64/hp/common/hwsw_iommu.c         |   61 ++++++++++++-----------
>   arch/ia64/hp/common/sba_iommu.c          |   64 ++++++++++++++-----------
>   arch/ia64/sn/pci/pci_dma.c               |   79 +++++++++++++++++++++----------
>   include/asm-ia64/dma-mapping.h           |   28 +++++++++-
>   include/asm-ia64/machvec.h               |   52 ++++++++++++--------
>   include/asm-ia64/machvec_hpzx1.h         |   16 +++---
>   include/asm-ia64/machvec_hpzx1_swiotlb.h |   16 +++---
>   include/asm-ia64/machvec_sn2.h           |   16 +++---
>   include/linux/dma-attrs.h                |   55 +++++++++++++++++++++
>   lib/swiotlb.c                            |   50 ++++++++++++++++---
>   10 files changed, 300 insertions(+), 137 deletions(-)


This patch would be better off split into generic and arch portions IMHO.

cheers

      reply	other threads:[~2008-02-29  2:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-28  3:25 akepner
2008-02-29  2:46 ` Michael Ellerman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dc1166600802281846m26865caw677ea9c9bb0722ca@mail.gmail.com \
    --to=michael@ellerman.id.au \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=akepner@sgi.com \
    --cc=benh@kernel.crashing.org \
    --cc=davem@davemloft.net \
    --cc=grundler@parisc-linux.org \
    --cc=jbarnes@virtuousgeek.org \
    --cc=jes@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    --cc=rdreier@cisco.com \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®