From: "Arnd Bergmann" <arnd@arndb.de>
To: "Eric Biggers" <ebiggers@kernel.org>, linux-crypto@vger.kernel.org
Cc: "Arnd Bergmann" <arnd@kernel.org>,
"Dan Williams" <dan.j.williams@intel.com>,
"Dionna Amalie Glaze" <dionnaglaze@google.com>,
"Cedric Xing" <cedric.xing@intel.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Zi Li" <zi.li@linux.dev>,
"Masami Hiramatsu" <mhiramat@kernel.org>,
"Lance Yang" <lance.yang@linux.dev>,
"Zhou Yuhang" <zhouyuhang@kylinos.cn>,
"Colin Ian King" <colin.i.king@gmail.com>,
"Ard Biesheuvel" <ardb@kernel.org>,
linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sample/tsm-mr: Use SHA-2 library APIs
Date: Wed, 18 Mar 2026 20:57:01 +0100 [thread overview]
Message-ID: <dc124ea8-05b8-42d2-93ad-d265e0ecf585@app.fastmail.com> (raw)
In-Reply-To: <20260318164233.19800-1-ebiggers@kernel.org>
On Wed, Mar 18, 2026, at 17:42, Eric Biggers wrote:
> Given that tsm_mr_sample has a particular set of algorithms that it
> wants, just use the library APIs for those algorithms rather than
> crypto_shash. This is more straightforward and a bit more efficient.
>
> This fixes an issue where this module failed to build due to the kconfig
> options CRYPTO and CRYPTO_HASH not being selected. Also, even if it
> built, crypto_alloc_shash() could fail at runtime due to the needed
> algorithms not being available.
>
> The library functions simply use direct linking. So if it builds, which
> it will due to the kconfig options being enabled, they are available.
>
> Fixes: f6953f1f9ec4 ("tsm-mr: Add tsm-mr sample code")
> Fixes: 44a3873df811 ("coco/guest: Remove unneeded selection of CRYPTO")
> Signed-off-by: Eric Biggers <ebiggers@kernel.org>
> ---
>
> I'd like to take this via libcrypto-next, as that is where
> "coco/guest: Remove unneeded selection of CRYPTO" is.
Thanks for fixing this! It is indeed nicer than the fix
I sent earlier today.
Acked-by: Arnd Bergmann <arnd@arndb.de>
next prev parent reply other threads:[~2026-03-18 19:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-18 16:42 Eric Biggers
2026-03-18 19:57 ` Arnd Bergmann [this message]
2026-03-19 17:32 ` Eric Biggers
2026-03-19 17:51 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc124ea8-05b8-42d2-93ad-d265e0ecf585@app.fastmail.com \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=ardb@kernel.org \
--cc=arnd@kernel.org \
--cc=cedric.xing@intel.com \
--cc=colin.i.king@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=dionnaglaze@google.com \
--cc=ebiggers@kernel.org \
--cc=lance.yang@linux.dev \
--cc=linux-coco@lists.linux.dev \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=zhouyuhang@kylinos.cn \
--cc=zi.li@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®