From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753136AbdDKSa1 (ORCPT ); Tue, 11 Apr 2017 14:30:27 -0400 Received: from mout.web.de ([217.72.192.78]:57840 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752224AbdDKSaX (ORCPT ); Tue, 11 Apr 2017 14:30:23 -0400 Subject: [PATCH 2/2] tty-goldfish: Adjust five checks for null pointers From: SF Markus Elfring To: Greg Kroah-Hartman , Jiri Slaby Cc: LKML , kernel-janitors@vger.kernel.org References: <53ab1654-e0ef-1227-cef2-32dbedcdc124@users.sourceforge.net> Message-ID: Date: Tue, 11 Apr 2017 20:30:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: <53ab1654-e0ef-1227-cef2-32dbedcdc124@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:5YZ/W0GVE540LYcND8RLE1UzuL1+etZpPk7MtQ4Y1XfNOp3jhXd 4N7xzas6EQMT/AIgWfUQDN7zfiKAHbtPfzXglYGEA3jKeDkjLeY+L7s1okzgbWY0P2QjMGO ZxKqR5c191odnU/KGFARMn18f/1lyneGEN+EHK1xrLMPRAxIamFNDupUfmoQdFEXs1+g2C/ FFPHDZtye0n1Ksk3W4+vg== X-UI-Out-Filterresults: notjunk:1;V01:K0:necX4cUMp6M=:GtvbsHzv8UtuXUmHICgSpf 5NZLLWJhvECvoF/NyraiiuDgGOUbtKtwxLQENRtiLNp5Bp6Rf+UTwHNOhdgg4sllbXx/MS9FO zH4LQHRPzgi1HnRvGfANhJ7wOdife6tNUBqKEFVwiE2RGcodcd3kJ1CPRNmFiG/RJk4BLbDht j5N2+9fB3W795b+2nB5gcwIA7LecBqF+XKJmegAgPL9YfQTacU72OwtTuwikCye+wgrAYKwx3 xpUYcBqXz1cQTK+ukQ53q/PVNklJ/WJbUIt4ZXZeQec5oRt7ZsvnDoKA7cc9SbT+zGer2ATrg pRkGGK5dwdLZz245bdhJrxgw3gnPWs3O0ghPzKvnLzdfg0xryH1zmyZLUGtCpVaVHhFLjHO6v gyqttM7AdOz78XPPoX3qdR0Kl1eq+Fi1HfwAQdZKJcRYiCZLK18y5ZPgonpbWyDhLtaCmzykS 89xi73Wt7JATD/I7459UHm89IPi+wKPXHXBUiqhlgVLwktb9fxxyULfYAXVuehEl1jEHIq/Vu R6uzVEEZdUIx3DgJWaYcCeOnfyxecY1iNb0ZfUu8WD94xEYXQOBF11uBSKy3ySJ8z/IO+N0yu MesLHgArB4wWyp03EL5MhBqi6vIgRKYDkqhmm0qgjvS8litSUM6o2XbKEvQqabTVnA1QTBIcY o8Lvx259l+Y9W3ZHtm18GdGuah0oV7xNesMZ5c7z6dmLIJTZW8D6zgRGY40YajJXSUridB91J J2w4QJTzzlswzBdXZImhvHxJAejnjDOaNyAWThwmLSGwU4TW36B8lCd7jrpEBUYAz2V4rEHKW GPN0TCy Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Tue, 11 Apr 2017 20:15:30 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written !… Thus fix the affected source code places. Signed-off-by: Markus Elfring --- drivers/tty/goldfish.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/tty/goldfish.c b/drivers/tty/goldfish.c index b92c3312ecd2..a07e5b01c279 100644 --- a/drivers/tty/goldfish.c +++ b/drivers/tty/goldfish.c @@ -182,12 +182,12 @@ static int goldfish_tty_create_driver(void) goldfish_ttys = kcalloc(goldfish_tty_line_count, sizeof(*goldfish_ttys), GFP_KERNEL); - if (goldfish_ttys == NULL) { + if (!goldfish_ttys) { ret = -ENOMEM; goto err_alloc_goldfish_ttys_failed; } tty = alloc_tty_driver(goldfish_tty_line_count); - if (tty == NULL) { + if (!tty) { ret = -ENOMEM; goto err_alloc_tty_driver_failed; } @@ -235,15 +235,15 @@ static int goldfish_tty_probe(struct platform_device *pdev) unsigned int line; r = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (r == NULL) + if (!r) return -EINVAL; base = ioremap(r->start, 0x1000); - if (base == NULL) + if (!base) pr_err("goldfish_tty: unable to remap base\n"); r = platform_get_resource(pdev, IORESOURCE_IRQ, 0); - if (r == NULL) + if (!r) goto err_unmap; irq = r->start; -- 2.12.2