From: <Codrin.Ciubotariu@microchip.com>
To: <broonie@kernel.org>
Cc: <alsa-devel@alsa-project.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <perex@perex.cz>,
<tiwai@suse.com>, <alexandre.belloni@bootlin.com>,
<sha@pengutronix.de>
Subject: Re: [PATCH 1/2] Revert "ASoC: dmaengine: do not use a NULL prepare_slave_config() callback"
Date: Tue, 26 Apr 2022 07:42:04 +0000 [thread overview]
Message-ID: <dc173079-78b5-81e9-42ec-439954c00efb@microchip.com> (raw)
In-Reply-To: <YmbFr14wI6qoNJ0b@sirena.org.uk>
On 25.04.2022 19:00, Mark Brown wrote:
> On Thu, Apr 21, 2022 at 03:54:02PM +0300, Codrin Ciubotariu wrote:
>> This reverts commit 9a1e13440a4f2e7566fd4c5eae6a53e6400e08a4.
>>
>> As pointed out by Sascha Hauer, this patch changes:
>> if (pmc->config && !pcm->config->prepare_slave_config)
> Please submit patches using subject lines reflecting the style for the
> subsystem, this makes it easier for people to identify relevant patches.
> Look at what existing commits in the area you're changing are doing and
> make sure your subject lines visually resemble what they're doing.
> There's no need to resubmit to fix this alone.
I did not know how to do properly do a revert. I saw some patches of
Greg that were made with 'git revert'. I will remember for next time.
Thanks for taking my patch anyway!
Best regards,
Codrin
prev parent reply other threads:[~2022-04-26 7:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-21 12:54 Codrin Ciubotariu
2022-04-21 12:54 ` [PATCH 2/2] ASoC: atmel: mchp-pdmc: set prepare_slave_config Codrin Ciubotariu
2022-04-25 16:00 ` [PATCH 1/2] Revert "ASoC: dmaengine: do not use a NULL prepare_slave_config() callback" Mark Brown
2022-04-25 16:00 ` Mark Brown
2022-04-26 7:42 ` Codrin.Ciubotariu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc173079-78b5-81e9-42ec-439954c00efb@microchip.com \
--to=codrin.ciubotariu@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=sha@pengutronix.de \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®