From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751242AbdFBUwZ (ORCPT ); Fri, 2 Jun 2017 16:52:25 -0400 Received: from mail-by2nam01on0057.outbound.protection.outlook.com ([104.47.34.57]:7136 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750971AbdFBUwW (ORCPT ); Fri, 2 Jun 2017 16:52:22 -0400 Authentication-Results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=amd.com; Subject: Re: [PATCH] amd-xgbe: use PAGE_ALLOC_COSTLY_ORDER in xgbe_map_rx_buffer To: Michal Hocko Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Michal Hocko References: <20170602155408.12792-1-mhocko@kernel.org> From: Tom Lendacky Message-ID: Date: Fri, 2 Jun 2017 15:52:16 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170602155408.12792-1-mhocko@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.78.1] X-ClientProxiedBy: SN1PR16CA0021.namprd16.prod.outlook.com (10.169.34.31) To DM5PR12MB1147.namprd12.prod.outlook.com (10.168.236.142) X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM5PR12MB1147: X-MS-Office365-Filtering-Correlation-Id: 69eea834-9967-4514-06ed-08d4a9f94339 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081)(201703131423075)(201703031133081);SRVR:DM5PR12MB1147; X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1147;3:/4dJTjW311RVtlGJr+PzfOYooUUzQgfAyPeX7zj+lGH9PV1irPxpUXBK3ZRI7zm5mqp8aMD3rFzXDZNeC5QASxng+f3R3c0ETzl0Y8xZp56I7ACFkfB4VEP/70mwu1KuYeZqWcnLsQmH/1oyf8Fh6gHRk0l69yPDKiSsM9/AyBjeRe7yKx33Swd1oIHixtfopENNs/cVARqnsbRy6IDbpsuN/ZDLa1wyMMqPDjaWaf1BRtGlahsqjwFcK6+SvUD12uSUlytTA41HNQSGWmd5eLcuQKgvHmwNckPuzX5aUW4b8r2JukPRuceNW7I8d1IUKQfkPwu2lNCQIdSkURY40gQXFisfjvnRsqj5Bjgx+io=;25:kSPuCB0zKFjBAOp5o2pxOy6xbLyy04P6IhLAtKVi53zqoBRk4QOEHpo/9mrQ567qCRXZ7zlybATGw7SWK3dptjYQuSvM1h8gum/9nref29ZWxKtKq3t7pS9ujCX16m094wnRTBHNjfVJ8wjGMlbCwxUQ09zEehgCw/km4NENKRsK/+IxiiWlvKD/JpNyu05opyV488dKEJyfspxmH9JXXL/8P2YbrXIRzQBqjcLZYMbqIIIIos75tXzXsKb3x9rpu+Xg3KG77gA+ZRpTXySlQ/icRWSh/1ezg/jw7KW4uqMQvzAU/xMd3tjJ4HBgjQC+OcLCb+vriyitO/xfu561Fg3h1OAe0e0Fg/aJbbr6XYNKWwHctOV1cmQMaMGoDRvb8Gt/RRSJwyEcNVO8kjD5NLx8Czx30lUISwIMR5nSPkG6t1wduSBRDYtP7+BAHa4GqlvBt2aBCNl1jVoEEq2MCMcTXoZ+Bv94dk7zLjkAWd0= X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1147;31:osnuJqS9WtvC5URaK6QrP16zis0XFHUREVeBRpuhrVRN/oSLkwdiFJ+pDmb1+RnP4YekWYQX902D+/xJcd6QK6G5+e4TpsLKwFzwGDf6ORZRiQYx3hip50DnIi7NIq6wVnjHwiPRbOwOL0SNzRUWAYLoCDOJBGAU3luwojKyqNPUV+Z617EqumXfT7nhQ8vdBLSlkWderBVHjNDfynHoC4xJbaXAfU12QHe1XLKY6r7bJmIHENoj35tZpJfjWMkWdEQE9J2paJdWVqivmK8c2A==;20:KsCbJdHXh3QPxpBGP3OzqBu64atmcjDAmmAnIliuh0wnyEfOJLeCUm/b3FgEoIUkIF1+zAxTwNWx/MoiOUucpLvvLEsHp0qgQWOWWpeGjXRTNZjOYi0Cut9bxvu5ncHDFVeNgTzEs+XNICBRQsfCfGUfURS1vQKR1f0539PtimihcAeDFfg+JGXUoe9iUruVXf1k43njjlf0LZl26N7Brg3jxujlvDXtCIOp+J1e+VLtE8YDA5ILr8nRdygZtZtDqDXmhbRMII2CzA6NcLh7ezeR/DCcry91VorqCRvsm3j2K2Z2Ud6EK/6NQ6T5XIYjLgnfkS+vSjlG4xrKeCvV6iYnR6U+Sw35QNQ3Qiwz3JviZG4iDuBaT1VyTZI2j7RlDg+Tewe3vuy1WiLELG4vwK4JeuqFA5BrfFUL4vJpM0mn2+7u6F6RxC9klJRNBf2kUSh+bbv6AsYpZNx2y7MVgNsvgHcVlZotcn7MbRv0/jrvKy3DHh3UEfu7uzyfvs56 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(10201501046)(93006095)(93001095)(3002001)(6055026)(6041248)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123564025)(20161123562025)(20161123558100)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DM5PR12MB1147;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DM5PR12MB1147; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTVQUjEyTUIxMTQ3OzQ6NEdOTHppaFN2M2t0Z0swLzlCb0JDbk8xdFFT?= =?utf-8?B?dzFkWHBoTU1ZbzZvZThFQnFDOWFONmhKMUhlZXEvbElnWlAzU05RQkZPOUR2?= =?utf-8?B?NWtURTcwRDJ3aC8rb01ndlFZcWRkaUZndjdJV1BQcWpBMjBLemJvWFU2ZHl6?= =?utf-8?B?dUFyVEphMVI5RndBbGRLQ3R3UnhVbUUzV2ROblNwcnBJcW9FSWNkQjJsUno0?= =?utf-8?B?QWFVVS9QNHpLSHpQdUUrS0dhRHEvS1R5cTNRSGRBbWpabTZuMEdWTGplbFZJ?= =?utf-8?B?NU1wZnBxaGlTL1IxdHBGWVMxWExXc3NPc1U4Q0pNY3U2bHpkRkVlSGdWUHJT?= =?utf-8?B?UmcrUnlJZFZBVm1BU1NwcnF0ck55U3pDcFFweHZsZy9Gci9iSXJsRlpmN3hI?= =?utf-8?B?RGRlWUQrTU5ibG1oS2Y5RGYxQTdDaVRDb096MnVHZzVqcjFyeUVaa2xUeWxw?= =?utf-8?B?YmNkL0RHR2tqOXEzb3lPU3hDd0xUWTh6M0JqOGJNRlUxUk1HMzVMYWFrbUJO?= =?utf-8?B?U2h6c1FEZ0dMbTQxbGxOMlh4TUNOK0Myc2o0Y2c5K1Aya1M1VkQyMHYxRUJ2?= =?utf-8?B?OTVwQXY3MFQ3b2h0YjBxR3oxdVpNRVZoNWZIZmdTS2VkR0g1dG15VTlmOEsr?= =?utf-8?B?MkNNczBncmx1czJ3NlFLaVlUbGxmWElWQTJ4R08vQWt3VnNpK0paVkpKeGg1?= =?utf-8?B?Y3NHeVZrLzNzSFQ5c2FXUUpWMU1VRjRzVjY5b1lVTnh0ZDVaKzhTSWdPb25t?= =?utf-8?B?Rk9pTXV3aWVteU52V2hqME1BYnRVaDA4SmRjZkt5VVhYcHhoR081Wk5NSEU2?= =?utf-8?B?U29mYnRvSUZmKzNDaHYySEQrZjJSWjlHY05Cb1QyL1VnY0JMbUxJb3VLV3RB?= =?utf-8?B?ZkVEVkdCL2xRS1RobHlCLy8xUDF3UTVHM3VncGN1dnNmUFUvVnZkeTlZa2pu?= =?utf-8?B?UzNCczNpYlJMU2JkdVdaMEdCOTV3cEx5dU1LZlRvbEVTaHpTVWUvRzJIM2xs?= =?utf-8?B?MndSbGpBNlVGKzBtOFVOQkFMcmdBbW1KZkQ2RkQ2cEI2RmdIUFgwWjZuQjBL?= =?utf-8?B?bzBiajJNRnRHY2draXJoTUpLL25lRHlNaVFHZndDTFdoY0o1aFZZNVYvemo0?= =?utf-8?B?MWw2ZHpFeURYOVFnWlUzM0oyU1dqRlcrQmpZbWxNYnhJS3dCOEJvT2tGK2Za?= =?utf-8?B?WVlWKzdmczVLcXE4amxRVERVTk1PTERoZHJ0UjJEVWhqNmYrWkN4dFBEZ0FF?= =?utf-8?B?VGNJQkhnTzMzazRzWFpZOFRNZHcxcnJFbjh3SThQZ0pkaVpIU2gxMXNmcVhT?= =?utf-8?B?ZExMMTNjZjFUNngzY3RhSkdqYnJXWWRpeG4yL0JqUDhlbFpLWlJQa051bm0z?= =?utf-8?B?bGpKb05nNUdsNUhzOGJ1Tnd6UU9RTWtFTmtxU3MvQ254ak1xVlF0Q3VKNUto?= =?utf-8?B?eVJ2aEY5cXB1alZmUC9KY1NCRUxWZTVSSlA3MGRucEtJclBTaUlqQXplamdu?= =?utf-8?B?ZG5kM3lFMVdWRG1QdDBnYk1lZVBnTTF6SEc4R3RaQjlOODlLVldvdUZCZVov?= =?utf-8?B?RENqYzVYbmEzbEJqQlBGNCtORkF3aGRkckNDb05RUVhpd25JaUVIWkpSTnNi?= =?utf-8?Q?hHsf1dK87XKxZhVKdtD?= X-Forefront-PRVS: 03264AEA72 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6049001)(6009001)(39850400002)(39400400002)(39860400002)(39410400002)(39450400003)(39840400002)(24454002)(377454003)(90366009)(38730400002)(110136004)(47776003)(50466002)(3260700006)(25786009)(53546009)(6246003)(77096006)(6486002)(23676002)(53936002)(83506001)(72206003)(4326008)(478600001)(86362001)(66066001)(31696002)(36756003)(6916009)(54356999)(230700001)(33646002)(76176999)(6666003)(50986999)(2950100002)(5660300001)(42186005)(65826007)(6116002)(31686004)(3846002)(81166006)(8676002)(2906002)(305945005)(4001350100001)(229853002)(189998001);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR12MB1147;H:[10.236.64.250];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTVQUjEyTUIxMTQ3OzIzOnJObTIwL0Z5N0RtdmNBOWRVdEJwczg4eU1M?= =?utf-8?B?M3Z5TlVxM1B4RmFRd1hQTmp6NDR2eDFaWWVjWHU3ZFBReGdUNVJtLzdyV283?= =?utf-8?B?WDcyWkRmWExjeWxKV2VZc0lHWW5QRjVOT1hVYVBRNkt5NGsvdWdhTjY0OE4x?= =?utf-8?B?QzQ1MTZzTUxkUzQxTFl0cDhOcUcvUC9JZmduUzM1YThRempHbDJRRnhmRjVR?= =?utf-8?B?bDZ3dXV5WTJUZmlLWjRkc2UwRkp5bThTUFEwd3ZScmYyMXVuVVZzVFlDQm1t?= =?utf-8?B?S2xjejA5Y2hhbERCR0NrcUx5Z0FKNnY3R0twWjU5NXliOEZSWXVHdEh2bFBu?= =?utf-8?B?MU9ZMUMrdHdpTkFseU56emY4R2hmZFlMMlpPTTM5aGQyZVI2ZU45NDhZSDZQ?= =?utf-8?B?cnhBRzlsWW83UkhqWXRyVGh0ZE9qVHFYUlo1dVZ2a2IvVWZEaS8zSVRZbTVP?= =?utf-8?B?UU1Kdi83WFl5VXhCelVrQ0VZVFgzNkRITEplblRwS3BkZFNEMXFBcmJiZjhk?= =?utf-8?B?dDJkbzRqdndOcUN6Uld3c2o0RHVWOUFvN3o3ZXpWSlBWa3RJbkg2RTdUM3Bi?= =?utf-8?B?YkIzQVpZbW1SQUJvL2NtbDdtdFl1NndWOVEraWhKVFdVdEdEQUFxWTVXb0lD?= =?utf-8?B?L0lIYkl3MHRmd3BCRHZKbEFmeTFOMHVRQ08yVlVuMUpaRW10d0ZteXgwSExJ?= =?utf-8?B?SURuOTV6eFZqcVM3MG8xUnJWVDVza2RCUGo4RnVwbnF1aTFKbVN5TUcwRGg4?= =?utf-8?B?U3hiUTNiczQ4VlBTdko3ZDhlQXNGNVQzMlVrSVA0LzNVaTlscWZCSlkwQTk1?= =?utf-8?B?U0J1alozaEx2M2UxdlROcU02cEdiWklzc3RwdXlqZnQrNG9qZWRxNVNrL0Vy?= =?utf-8?B?NmR1ZGsvRlQ0eGR1S0VERVQ4cW4veGR3SkE3cHpHV0ZUdlZTSXhrWVZJZlZ5?= =?utf-8?B?WmRpN2lFSEM0U2xrMnFMM3NJVzQvNGE5eUNBK20zMlB0ZUhTT2JaZUh4NCtp?= =?utf-8?B?ZXJrMm1jdUQ4blk4b3JzMi9ZNkl1cEhoSkxyRThrekJtUHROMFkvMTBXTy9s?= =?utf-8?B?NUpCSFVxNFVpcE5MZnpGcW9lblM1VWU2SVNBUy9KT0ovSm1vY3ViNFo2QnFB?= =?utf-8?B?bWt3WHA4L3k0RllnOHVjSE1XcHFaUklnU0IwckxHellHUVZKWjA5WW1mV2Q1?= =?utf-8?B?QXBCNDRKZURGTjU2allmMUlrK0h6Y3NWdkt3L1hqSFJmUFRvcGlLanJucEJ1?= =?utf-8?B?VmlSbkdtMTRycktUTXAvZmNMTjJUQzlZVy9FTkFOQUNGS1VhMVFoeUdydUh4?= =?utf-8?B?L1FNem96bVd1UDdmSFhvVlJleDdCbHE4MnpwR3JpNU8rdVFTeGd0WTVqWlR5?= =?utf-8?B?QlpIRlBqMFdUdllmS1VXYnRibEhSVUZEWWswc25KekRNRDcwci94dkUrQ0xz?= =?utf-8?B?MkJtTVhITU5UbGdBVHB3RzI0emhndTJmWjRqZkZLS1NRd0w5UGxIdDRnVytC?= =?utf-8?B?aVIxTDUvZUhaakpXUVFMRGFPVFBGSTZLQ0hMSmJKVlJ2bW5jUkMyVTE2aEhK?= =?utf-8?B?endtQlEvVFNQeFlwQ1BBNTk4eWFkRzhEV29lQ1NsYzlTL1FCZmhFNjV2Vjda?= =?utf-8?B?YTNPUzJKekdRdWlBeGJFMHhEbFNHaXpLWU91enVSUmRWTFJlN2VudGlMV3JL?= =?utf-8?B?aVNXUUtQUVBTQnR1bXVRZGFCeklYU0cybzkxcHBLeEtUcENBYnlQdElvME1s?= =?utf-8?Q?pwAvvNfmWlph8JrBwTAsTOXiXC3E00p6LPMzA=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1147;6:heMS750Jri6rMv5OKMMTDW4plZ80in5z83ujpZ/J3/yrkT7VX10xGLUQas/5C6SX1iL5GLEJOmD1Tb5azPl9oBdaB/d1EyqiokffW5Cnsq9+/V5mM+Q9ehe60B9wYHV+MLQONNBGgJbYkPfzWPLHGIhlS2Kz2SI/jDXXELrWLIn/TbQB+zTKgnG8t/iyETcSiHoWqLD7/fXfYzs1pPQ8so9wzorAACstbACBEhw8vm4uu4xb5suuRGuWhU45AGZlh7kSPjX4afGMKH6VAdbHEp7YVeNkheZn4ee2MsFy/RQihZZD4e2dW8sx6LJPN/qlq1OWGpzjc1A/uwdqVwFEEWdHpN+Kp0T7aGRfawqg+kBXcvGjc7l3VEk6AtHqlTgzCORpJzSLgIIP/ji2riUHgSJQvf3SoX+DhTv/YnsLeQ/KOyxU/WsrEczfCTloakubxJyMFsWTl+Guvem8zoTVHbKQmxdG2MQh+zgalRAcZnK9lcbV7ATJ/P9rFlYvCByT4NnN2gstX6c1S1DG5VHa5q4Dr7LjYq1VABB25lhxd+I= X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1147;5:1B6dKoOxAgsNXWK8laoaR0V2x9O/cC4pHRddScskZhVa1oxZq6HBUN0ikIdFe4C0buCeRWJ/FNq/phBYlmbvTbCwmW6YOZOgxluIi8AnWMqdsfDpPLi7m/H4ebf/iOCZQS40vQ6AGOPTS0dAazcUL+3WfvY/NZ2dXNW/1l5QboanGkCN8NbfwVIH1s1JpvsbUvk8jloHXFouQkmltS0GnMrby4LqFmMWcZopFdV6MlxqKmogURmCR8qtnklJLZTRuTkz02G/cYp8D91vbS+8m6eVXnutxh/o2e5Be7w/cAaOW10RIoILS3RBAFPMrUvxmKiJfCTlal4rjPsF4aOvdez3HuyCzjO5SFVQBHbg3IiRnsrGckpT7up75k2rPAnTFuudwRASpxBcPfsaS5tN6bYNDLpnPYiqiJ3tQ112ZhQMtdVgCT5jvpMtENM7xUDRen/H1H+HvoKj5C9X9K95ktMT8c9EmlZbMrHVqRs7mxgaRQtIX/A/5wYBKUQ60O9p;24:QLTScqGyX0j3j1QvVvMj8u7SSwr/q6IEdmT7AEs7MKRX3RSjNdypYt+moyijIpwX+faFKQAF0mSMps3iBjnz4KZherxC3NfAPTYH239HHcQ= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1147;7:Nyid5aoFxLGJXGy0ulKSmxf4fdUwc53uAxmke/ixqkUuDQ9fchM/xiS2CKRXPymUo328xNoYFw3lEeZikbRuSOT0nbBJS8b1jn7UdGsR7XxznsXklUWyzXazCijeLaya9nRZoZH4rRBPvd5X+jyp4IgWuWIg9XivjpJFsxGRfsCs0vC/WjVMChZLtth2msm1yv2FpHYCbfc1+OV2ZgXFEjtWX8143TSC4i6dEhil11jJqZgvPOkJY37QkjlTTpaj/sln2hh/0XjFRBneu5RiUi2GzWhljcuWN+fpVMuw13GbWNK2HYmKXtK6ZYNmA1fqMy2vkXA7M3OEskWabBxkww==;20:xvJtwrjciqSCUv/BXC4Dt+KUXyuYo4ms6caBLV5R4+a6DLc1zRN1kHsHuGI4ADIVIgQwOv0KglZuBZhJxskKv0FEJ4eCDWSCYIXrU/cQc/yeGRQHG7HjmCYJ5KcUe441oWJBfiYKR4g8611eLrLwnIyuY4lk7aQMEt1G5VqZD+j1MQ6XtERPjQaSJEtqHWxESkW/AT6Dv3OIbd8MTWRDxGQIOmNVpH5wGaX66HUrWXHWmeqXxgXQkPzk0eI+7CNk X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jun 2017 20:52:20.3061 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1147 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/2/2017 10:54 AM, Michal Hocko wrote: > From: Michal Hocko > > xgbe_map_rx_buffer is rather confused about what PAGE_ALLOC_COSTLY_ORDER > means. It uses PAGE_ALLOC_COSTLY_ORDER-1 assuming that > PAGE_ALLOC_COSTLY_ORDER is the first costly order which is not the case > actually because orders larger than that are costly. And even that > applies only to sleeping allocations which is not the case here. We > simply do not perform any costly operations like reclaim or compaction > for those. Simplify the code by dropping the order calculation and use > PAGE_ALLOC_COSTLY_ORDER directly. > > Signed-off-by: Michal Hocko Acked-by: Tom Lendacky > --- > drivers/net/ethernet/amd/xgbe/xgbe-desc.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-desc.c b/drivers/net/ethernet/amd/xgbe/xgbe-desc.c > index b3bc87fe3764..0a98c369df20 100644 > --- a/drivers/net/ethernet/amd/xgbe/xgbe-desc.c > +++ b/drivers/net/ethernet/amd/xgbe/xgbe-desc.c > @@ -324,7 +324,7 @@ static int xgbe_map_rx_buffer(struct xgbe_prv_data *pdata, > struct xgbe_ring *ring, > struct xgbe_ring_data *rdata) > { > - int order, ret; > + int ret; > > if (!ring->rx_hdr_pa.pages) { > ret = xgbe_alloc_pages(pdata, &ring->rx_hdr_pa, GFP_ATOMIC, 0); > @@ -333,9 +333,8 @@ static int xgbe_map_rx_buffer(struct xgbe_prv_data *pdata, > } > > if (!ring->rx_buf_pa.pages) { > - order = max_t(int, PAGE_ALLOC_COSTLY_ORDER - 1, 0); > ret = xgbe_alloc_pages(pdata, &ring->rx_buf_pa, GFP_ATOMIC, > - order); > + PAGE_ALLOC_COSTLY_ORDER); > if (ret) > return ret; > } >