From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from imap4.hz.codethink.co.uk (imap4.hz.codethink.co.uk [188.40.203.114]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD3A11FC7CE for ; Mon, 27 Jan 2025 09:26:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=188.40.203.114 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737970007; cv=none; b=txwn0/rK6JC86vfIcWoEegTRpvFQXFsi37Ntu+S0RX+4VlScv98gxO26TU9kzNSC6lHpk8iapm+yOODCMMzguQxwCBXLye4hJezQ9IrTgdoAm8uhk2xXxGlNE4VDsgTs2Zh0z/fsuKXNVg5JIev+zpkPZqbfo5K/qpqk/GgrFR0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737970007; c=relaxed/simple; bh=EliWuVbeoNniGRcu1DSfgz2QJ3YDizBMKp+gwycNOR4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=m01cHtlC2ccVp/LBjbySOQWlvuCrCpxiU0gi30cH3bBxkVAV2xuNpBWCv5lwoFt+UWgZI9Xajyr0RqLwQht8zrKrdidVKcD9BXkzK1MDrvX2epBYtAJRgJqElHKS9rcbYTJ9X4l1lcVNrJkvBmz1SDi4DQWgWm10Qb4DxuthXBM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=codethink.co.uk; spf=pass smtp.mailfrom=codethink.co.uk; dkim=pass (2048-bit key) header.d=codethink.co.uk header.i=@codethink.co.uk header.b=J5B2xJ4v; arc=none smtp.client-ip=188.40.203.114 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=codethink.co.uk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=codethink.co.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=codethink.co.uk header.i=@codethink.co.uk header.b="J5B2xJ4v" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=codethink.co.uk; s=imap4-20230908; h=Sender:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=wriQl75Gusa955YmjwJpTlRf/EoZrjPRFhU8Bvkz6ew=; b=J5B2xJ4vUC14eZa5Tu1EzFnKyb FVqI21yrxH2FqFG/IwHOiCd1tTJqgXV1KheDmY9gWvWK5kRZ60Td43kWSFs+PpKKGJ0Ad2yLIn4kH 3poXc7mlLgUP6M69YVRYlLDGT8wqmd1LSb4AwD+fUg2+3ijsn1d2Nqm/PbSSQBjESd3IegIuxL+Hd QoBmbOFuKwJeQj9TTK5AcG+4OLX2mDIzCwd8zeWKa33KR0GHLaCdxyUhxHLbX76b2PpEJQSaBvG+7 XGCqwQ1PyCNitsFG2TKuug4yv/LIZITD310s+6CatmoO3adlRxyUhbSPFku7O4tt+QzDRk39SYfAm d3Ni6/rw==; Received: from [167.98.27.226] (helo=[10.35.6.157]) by imap4.hz.codethink.co.uk with esmtpsa (Exim 4.94.2 #2 (Debian)) id 1tcKpk-006uH5-QI; Mon, 27 Jan 2025 08:51:04 +0000 Message-ID: Date: Mon, 27 Jan 2025 08:51:04 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] riscv: Add runtime constant support To: Charlie Jenkins , Paul Walmsley , Palmer Dabbelt , Ard Biesheuvel Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org References: <20250127-runtime_const_riscv-v1-1-795b023ea20b@rivosinc.com> Content-Language: en-GB From: Ben Dooks Organization: Codethink Limited. In-Reply-To: <20250127-runtime_const_riscv-v1-1-795b023ea20b@rivosinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: ben.dooks@codethink.co.uk On 27/01/2025 08:18, Charlie Jenkins wrote: > Implement the runtime constant infrastructure for riscv. Use this > infrastructure to generate constants to be used by the d_hash() > function. > > This is the riscv variant of commit 94a2bc0f611c ("arm64: add 'runtime > constant' support") and commit e3c92e81711d ("runtime constants: add > x86 architecture support"). > > Signed-off-by: Charlie Jenkins I think my only comment on this is we should treat instructions as __le32 type and add the proper conversions when maniuplating them. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius https://www.codethink.co.uk/privacy.html