From: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
To: Mike Leach <mike.leach@linaro.org>,
linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org,
linux-kernel@vger.kernel.org
Cc: linux@armlinux.org.uk, mathieu.poirier@linaro.org,
suzuki.poulose@arm.com, arm@kernel.org
Subject: Re: [PATCH v4 1/3] drivers: amba: Updates to component identification for driver matching.
Date: Thu, 31 Jan 2019 16:53:10 +0530 [thread overview]
Message-ID: <dc23a09c-7814-8fa1-ed07-7afe9eb3e7ed@codeaurora.org> (raw)
In-Reply-To: <20190130234051.2294-2-mike.leach@linaro.org>
On 1/31/2019 5:10 AM, Mike Leach wrote:
> The CoreSight specification (ARM IHI 0029E), updates the ID register
> requirements for components on an AMBA bus, to cover both traditional
> ARM Primecell type devices, and newer CoreSight and other components.
>
> The Peripheral ID (PID) / Component ID (CID) pair is extended in certain
> cases to uniquely identify components. CoreSight components related to
> a single function can share Peripheral ID values, and must be further
> identified using a Unique Component Identifier (UCI). e.g. the ETM, CTI,
> PMU and Debug hardware of the A35 all share the same PID.
>
> Bits 15:12 of the CID are defined to be the device class.
> Class 0xF remains for PrimeCell and legacy components.
> Class 0x9 defines the component as CoreSight (CORESIGHT_CID above)
> Class 0x0, 0x1, 0xB, 0xE define components that do not have driver support
> at present.
> Class 0x2-0x8,0xA and 0xD-0xD are presently reserved.
>
> The specification futher defines which classes of device use the standard
> CID/PID pair, and when additional ID registers are required.
>
> This patch introduces the amba_cs_uci_id structure which will be used in
> all coresight drivers for indentification via the private data pointer in
> the amba_id structure.
>
> Existing drivers that currently use the amba_id->data pointer for private
> data are updated to use the amba_cs_uci_id->data pointer. Macros and
> inline functions are added to simplify this code.
>
Thanks Mike, this fixes STM probe with UCI change.
Tested-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2019-01-31 11:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 23:40 [PATCH v4 0/3] Update AMBA driver for enhanced component ID spec Mike Leach
2019-01-30 23:40 ` [PATCH v4 1/3] drivers: amba: Updates to component identification for driver matching Mike Leach
2019-01-31 11:23 ` Sai Prakash Ranjan [this message]
2019-01-30 23:40 ` [PATCH v4 2/3] drivers: amba: Update component matching to use the CoreSight UCI values Mike Leach
2019-01-30 23:40 ` [PATCH v4 3/3] coresight: etmv4: Update ID register table to add UCI support Mike Leach
2019-02-06 20:58 ` [PATCH v4 0/3] Update AMBA driver for enhanced component ID spec Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc23a09c-7814-8fa1-ed07-7afe9eb3e7ed@codeaurora.org \
--to=saiprakash.ranjan@codeaurora.org \
--cc=arm@kernel.org \
--cc=coresight@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome