mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@cam.ac.uk>
To: Jon Brenner <jbrenner@taosinc.com>
Cc: linux-iio <linux-iio@vger.kernel.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2] IIO channel type and modifiers for CCT and RGBC data
Date: Wed, 16 May 2012 17:06:59 +0100	[thread overview]
Message-ID: <dc25012a-f53d-472d-8df5-77f8f6a9855d@email.android.com> (raw)
In-Reply-To: <1337183202.6344.1.camel@jonz-ub2>



Jon Brenner <jbrenner@taosinc.com> wrote:

>Add iio channel type and modifiers for Correlated Color Temperature
>(CCT)
>and RGBC (red/green/blue/clear) data.
>Add CCT and RGBC descriptions to documentation.
>
>Changes:
>Revised/condensed RGBC descriptions.
>
>Signed-off-by: Jon Brenner <jbrenner@taosinc.com>
Acked-by: Jonathan Cameron <jic23@kernel.org>
>---
> drivers/iio/industrialio-core.c                    |    5 ++++
>.../staging/iio/Documentation/sysfs-bus-iio-light  |   23
>++++++++++++++++++++
> include/linux/iio/types.h                          |    5 ++++
> 3 files changed, 33 insertions(+), 0 deletions(-)
>
>diff --git a/drivers/iio/industrialio-core.c
>b/drivers/iio/industrialio-core.c
>index 1ddd886..34d8cc9 100644
>--- a/drivers/iio/industrialio-core.c
>+++ b/drivers/iio/industrialio-core.c
>@@ -64,6 +64,7 @@ static const char * const iio_chan_type_name_spec[] =
>{
> 	[IIO_TIMESTAMP] = "timestamp",
> 	[IIO_CAPACITANCE] = "capacitance",
> 	[IIO_ALTVOLTAGE] = "altvoltage",
>+	[IIO_CCT] = "cct",
> };
>
> static const char * const iio_modifier_names[] = {
>@@ -72,6 +73,10 @@ static const char * const iio_modifier_names[] = {
> 	[IIO_MOD_Z] = "z",
> 	[IIO_MOD_LIGHT_BOTH] = "both",
> 	[IIO_MOD_LIGHT_IR] = "ir",
>+	[IIO_MOD_LIGHT_CLEAR] = "clear",
>+	[IIO_MOD_LIGHT_RED] = "red",
>+	[IIO_MOD_LIGHT_GREEN] = "green",
>+	[IIO_MOD_LIGHT_BLUE] = "blue",
> };
>
> /* relies on pairs of these shared then separate */
>diff --git a/drivers/staging/iio/Documentation/sysfs-bus-iio-light
>b/drivers/staging/iio/Documentation/sysfs-bus-iio-light
>index 715c74d..83a2876 100644
>--- a/drivers/staging/iio/Documentation/sysfs-bus-iio-light
>+++ b/drivers/staging/iio/Documentation/sysfs-bus-iio-light
>@@ -34,6 +34,15 @@ Description:
> 		it comes back in SI units, it should also include _input else it
> 		should include _raw to signify it is not in SI units.
>
>+What:		/sys/bus/iio/devices/device[n]/in_cct0[_input|_raw]
>+KernelVersion:	3.4.0
>+Contact:	linux-iio@vger.kernel.org
>+Description:
>+		This should return the correlated color temperature from the
>+		light sensor. If it comes back in SI units, it should also
>+		include _input else it should include _raw to signify it is not
>+		in SI units.
>+
>What:		/sys/.../device[n]/proximity_on_chip_ambient_infrared_supression
> KernelVersion:	2.6.37
> Contact:	linux-iio@vger.kernel.org
>@@ -82,3 +91,17 @@ Contact:	linux-iio@vger.kernel.org
> Description:
> 		This property gets/sets the table of coefficients
> 		used in calculating illuminance in lux.
>+
>+What:		/sys/bus/iio/devices/device[n]/in_intensity_clear[_input|_raw]
>+What:		/sys/bus/iio/devices/device[n]/in_intensity_red[_input|_raw]
>+What:		/sys/bus/iio/devices/device[n]/in_intensity_green[_input|_raw]
>+What:		/sys/bus/iio/devices/device[n]/in_intensity_blue[_input|_raw]
>+KernelVersion:	3.4.0
>+Contact:	linux-iio@vger.kernel.org
>+Description:
>+		This property is supported by sensors that have a RGBC
>+		sensing mode. This value should be the output from a reading
>+		and if expressed in SI units, should include _input. If this
>+		value is not in SI units (irradiance, uW/mm), then it should
>+		include _raw.
>+
>diff --git a/include/linux/iio/types.h b/include/linux/iio/types.h
>index 1b073b1..a7de5d9 100644
>--- a/include/linux/iio/types.h
>+++ b/include/linux/iio/types.h
>@@ -28,6 +28,7 @@ enum iio_chan_type {
> 	IIO_TIMESTAMP,
> 	IIO_CAPACITANCE,
> 	IIO_ALTVOLTAGE,
>+	IIO_CCT,
> };
>
> enum iio_modifier {
>@@ -45,6 +46,10 @@ enum iio_modifier {
> 	IIO_MOD_X_OR_Y_OR_Z,
> 	IIO_MOD_LIGHT_BOTH,
> 	IIO_MOD_LIGHT_IR,
>+	IIO_MOD_LIGHT_CLEAR,
>+	IIO_MOD_LIGHT_RED,
>+	IIO_MOD_LIGHT_GREEN,
>+	IIO_MOD_LIGHT_BLUE,
> };
>
> #define IIO_VAL_INT 1
>--
>1.7.4.1
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-iio" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Sent from my Android phone with K-9 Mail. Please excuse my brevity.

      reply	other threads:[~2012-05-16 16:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-16 15:46 Jon Brenner
2012-05-16 16:06 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dc25012a-f53d-472d-8df5-77f8f6a9855d@email.android.com \
    --to=jic23@cam.ac.uk \
    --cc=jbrenner@taosinc.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®