mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alexey Kardashevskiy <aik@ozlabs.ru>
To: "Murilo Opsfelder Araújo" <mopsfelder@gmail.com>,
	"Michael Ellerman" <mpe@ellerman.id.au>,
	"kbuild test robot" <lkp@intel.com>
Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org,
	kvm@vger.kernel.org, Alex Williamson <alex.williamson@redhat.com>,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] include/linux/vfio.h: Guard powerpc-specific functions with CONFIG_VFIO_SPAPR_EEH
Date: Thu, 8 Jun 2017 23:10:10 +1000	[thread overview]
Message-ID: <dc26bfd2-9ba6-b3bd-afa9-ed0d801757b7@ozlabs.ru> (raw)
In-Reply-To: <e426fff2-ad3e-64c6-7c6b-2c37c16c00c1@gmail.com>

On 08/06/17 22:45, Murilo Opsfelder Araújo wrote:
> On 06/08/2017 08:41 AM, Michael Ellerman wrote:
>> Alexey Kardashevskiy <aik@ozlabs.ru> writes:
>>
>>> Hi,
>>>
>>> How did you manage to have CONFIG_EEH=y and CONFIG_VFIO_SPAPR_EEH=n? "make
>>> oldconfig" fixes this to CONFIG_VFIO_SPAPR_EEH=y.
>>
>> Hmm, Murilo did you confirm the bug still happens on upstream with that
>> rand config?
> 
> Yes, it's still happening with next-20170607.


The config you attached in the first mail has CONFIG_VFIO_SPAPR_EEH=m, here
is my confusion. The config from the link below does not have KVM_BOOK3S_64
which selects SPAPR_TCE_IOMMU and which in turn selects VFIO_IOMMU_SPAPR_TCE.

So
https://github.com/0day-ci/linux/commit/36ed1ddb05e132aa3cfbb610f0f8402a0774da12
looks correct.



> 
> For me, `make oldconfig` hasn't changed it to CONFIG_VFIO_SPAPR_EEH=y. See:
> 
>     $ git clean -dfxq
>     $ git reset --hard origin/master
>     HEAD is now at 8d1b80c Add linux-next specific files for 20170607
> 
>     $ curl http://kisskb.ellerman.id.au/kisskb/buildresult/12982362/config/ -o .config
>     $ grep -E 'EEH|SPAPR' .config
>     CONFIG_EEH=y
>     # CONFIG_SPAPR_TCE_IOMMU is not set
> 
>     $ yes '' | make oldconfig
> 
>     $ grep -E 'EEH|SPAPR' .config
>     CONFIG_EEH=y
>     # CONFIG_SPAPR_TCE_IOMMU is not set
> 
>     $ make -j 160 ARCH=powerpc
>     ...
>     drivers/vfio/pci/vfio_pci.o: In function `.vfio_pci_release':
>     vfio_pci.c:(.text+0xa98): undefined reference to `.vfio_spapr_pci_eeh_release'
>     drivers/vfio/pci/vfio_pci.o: In function `.vfio_pci_open':
>     vfio_pci.c:(.text+0x1420): undefined reference to `.vfio_spapr_pci_eeh_open'
>     make: *** [vmlinux] Error 1
> 


-- 
Alexey

  reply	other threads:[~2017-06-08 13:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-06 12:09 Murilo Opsfelder Araujo
2017-06-07 10:49 ` Michael Ellerman
2017-06-07 16:31 ` kbuild test robot
2017-06-08  5:35   ` Alexey Kardashevskiy
2017-06-08  5:36     ` Alexey Kardashevskiy
2017-06-13  8:36       ` [kbuild-all] " Ye Xiaolong
2017-06-08 11:41     ` Michael Ellerman
2017-06-08 12:45       ` Murilo Opsfelder Araújo
2017-06-08 13:10         ` Alexey Kardashevskiy [this message]
2017-06-08 15:32           ` Murilo Opsfelder Araújo
2017-06-08  0:06 ` [PATCH v2] " Murilo Opsfelder Araujo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dc26bfd2-9ba6-b3bd-afa9-ed0d801757b7@ozlabs.ru \
    --to=aik@ozlabs.ru \
    --cc=alex.williamson@redhat.com \
    --cc=kbuild-all@01.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=lkp@intel.com \
    --cc=mopsfelder@gmail.com \
    --cc=mpe@ellerman.id.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®