From: Daniel Borkmann <daniel@iogearbox.net>
To: Keith Busch <keith.busch@linux.intel.com>,
intel-gfx@lists.freedesktop.org,
John Fastabend <john.fastabend@gmail.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [BUG] cc5b114dcf bpf, i40e: add meta data support
Date: Tue, 12 Jun 2018 22:24:52 +0200 [thread overview]
Message-ID: <dc3176ae-5b16-ffa8-c8c8-595a0ede57f4@iogearbox.net> (raw)
In-Reply-To: <20180612161739.GA3303@localhost.localdomain>
On 06/12/2018 06:17 PM, Keith Busch wrote:
> My server's i40e no longer obtains an IP address on linux
> mainline. Bisected to the following:
>
> commit cc5b114dcf986bfd8e4c37bf65d1b7b1e5290ac6
> Author: Daniel Borkmann <daniel@iogearbox.net>
> Date: Mon May 28 11:07:20 2018 +0200
>
> bpf, i40e: add meta data support
>
> Reverting on mainline resolves the issue.
>
> Is there something wrong with my i40e adapter, or is the patch possibly
> doing something wrong? Or any other information I can get to help
> understand why it's stopped working with this feature?
>
> An excert from "journalctl -xe" on on the failing network adapter
> is below.
Thanks for the report & sorry for the issue, Keith! Instead of revert,
could you give the below fix a try?
diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c
index 8ffb745..ed6dbcf 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c
@@ -2103,9 +2103,8 @@ static struct sk_buff *i40e_build_skb(struct i40e_ring *rx_ring,
unsigned int truesize = i40e_rx_pg_size(rx_ring) / 2;
#else
unsigned int truesize = SKB_DATA_ALIGN(sizeof(struct skb_shared_info)) +
- SKB_DATA_ALIGN(I40E_SKB_PAD +
- (xdp->data_end -
- xdp->data_hard_start));
+ SKB_DATA_ALIGN(xdp->data_end -
+ xdp->data_hard_start);
#endif
struct sk_buff *skb;
@@ -2124,7 +2123,7 @@ static struct sk_buff *i40e_build_skb(struct i40e_ring *rx_ring,
return NULL;
/* update pointers within the skb to store the data */
- skb_reserve(skb, I40E_SKB_PAD + (xdp->data - xdp->data_hard_start));
+ skb_reserve(skb, xdp->data - xdp->data_hard_start);
__skb_put(skb, xdp->data_end - xdp->data);
if (metasize)
skb_metadata_set(skb, metasize);
Thanks,
Daniel
next prev parent reply other threads:[~2018-06-12 20:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-12 16:17 Keith Busch
2018-06-12 20:24 ` Daniel Borkmann [this message]
2018-06-25 12:24 ` [Intel-gfx] " Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc3176ae-5b16-ffa8-c8c8-595a0ede57f4@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=john.fastabend@gmail.com \
--cc=keith.busch@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®