From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D12DC25B09E for ; Sun, 19 Jul 2026 14:38:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784471931; cv=none; b=Mbv9CBVi9COocZ3Z2QIANe0wc+4Ckehi79lN+SDcY8ls3oc6vrVUowMoFOFFbyg9qszzmTrl9L2tzcGeTaXz9L41/62cbzpWTtOIP2FqCkBgouKOTDSOWiMtGTLKgaNiOqY5jMWZM5C1sdk5de/tT7jmeAdoTNk7HoCbimoAfKs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784471931; c=relaxed/simple; bh=5JViRLvKb8dPvcqX4KeS3RCG1atYi0jAQLZkceHHjVk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NJK32T3gP2w2td1cgqATSnkTr+lhWEdDjjJOQAQsM/p4LWccLcgKHveXZ8uyuaELw2TqSoQO9HJqOltYHsPYPjHwjV83ieh1AgNcyC+cpN7l0xJWmxydH8bphGkj4RkMaPbN8gj7aFXlz/W0S9+yO99/Sz54qWhCxGtYwd2Co9s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Z1a+G//J; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Z1a+G//J" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-8423f236418so4639105b3a.1 for ; Sun, 19 Jul 2026 07:38:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784471929; x=1785076729; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:sender:from:to:cc :subject:date:message-id:reply-to:content-type; bh=QWosVd6/mPQVTjsyekcZhVDtJcqWOKI5sNaG4tYywqM=; b=Z1a+G//JzY2pD/WpuwZM1YYNV0HCgwWt6vH11YgjELiL008w01HiIXDyc47krD+Huz 6gchN34AhmC+FozmWhLf9qlszm7Ml11ArisnWxh3sebd0mO1jnQYdETu75zEK3hkLIDG jpBRX1TWngfVIu7aUvJFOPuAUOejl3i2IySX5Mq9sfYRn+IRbnv94w3gT22S+q2Jl2bN 6ihfoAzMJozX9KL8aiXO5ynueZy5wWSDxvHkHRcvp+SJHfPV8rO8mUqvT72BJN5SM77c IBE4rI47fCdmg9wYFuCNWjEgJ2GRrKOYaVAxfd2dldKCb6Y85cNkuegoy6w6Th0KTuj8 +W0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784471929; x=1785076729; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:sender:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=QWosVd6/mPQVTjsyekcZhVDtJcqWOKI5sNaG4tYywqM=; b=IaywlXqakIzhKwIO7/7lsfB9sz7TXTXvpqz1L1x0sWvqUwdCYvT074ZIgiD0NIZzjo R1s/s8Lv+J7pjDAhxWh5lEEE+f5oajT5bTkZE+PvUfH2UHUf1bnPM/RyNge1IFVAtmI0 esCLqaVXN2UeSsDUaYyyqOfUeaIlfk+srokMovm/O+AEDs0GZyw/E15OOGRwRQu8h+fd 9LDgY3W0ziw+kkJox4nYWuJ4s8wKlhsGDK+vwnmlRhRWKPv9bOpiEt82XodAFvReq2lU 4/r8h2WG+kEdD1n4tQEpMZLfFFW8EZbYMt8R2OMqET7FezKfGEzCpB4tmmdyuU9GIdAn o4yg== X-Forwarded-Encrypted: i=1; AHgh+RqPZl6CoGPKsF6Sft5WJ0eP/NAl0Uks2KZuIqigMWaHG79vKP5YRjc5ZY46luXPUTGOWOyg4in30k/Edtg=@vger.kernel.org X-Gm-Message-State: AOJu0YzZb/9PUtt7SVXE1Eb9yznLYu2MXHlGj3sBfHKcXKfDODLWdYav Rwl3HC5i0BXl7pZvYnnIDEA+t3p3nHqeH/G3ncz9YS+lUfANOyzYcMe8 X-Gm-Gg: AfdE7cnFUUumF9gcgm9ljFWC8LFGLSl7DheSlhdto0zcqA/yEYFcgydUzWHW+kdy4MM khMhrZiDCkRPJbeqL7SXEzmq7rrh7zc5QCTKUaOkA9Ob0pfFo48SK4avTWaPgincA5hVoBSkJpg UCQVyDFGTMtC3csPqCXcA6zPNlZivx3LpFqOGj1Ksje3XhJphSDtsBK8uQlN/2JL6kYc5UTK7VC cEigJhBmhkY4fxgvV6D2zw3EgdbH+AKUeTdQA+mB2uQgvgLQ2vsNB+HNgu4X1vnGoZZ7ILgDhfq DvvTOpmhM+czM02yW6XdNvmzEryTExSh1986JZj2+M0RC0ZomzmBrmAcR3DDMwH8kgI8mLJYhjg zTstWi1Ljr6tWUvZCaFyc70mrght+dH40nkB2joffBMeWHJB2WcOBBTRRs9/NYrW3n8ZIfY1yK+ BS7ilGhNH54JPNt0axY8Isl5R3Sw== X-Received: by 2002:a05:6a00:17a2:b0:848:2f74:1d5d with SMTP id d2e1a72fcca58-84c2955cea8mr10590475b3a.67.1784471928854; Sun, 19 Jul 2026 07:38:48 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84c2af30b89sm4244052b3a.33.2026.07.19.07.38.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Jul 2026 07:38:48 -0700 (PDT) Sender: Guenter Roeck Date: Sun, 19 Jul 2026 07:38:47 -0700 From: Guenter Roeck To: Shih-Yuan Lee Cc: Henrik Rydberg , Armin Wolf , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 2/3] hwmon: (applesmc) Fix lockless cache validation data race Message-ID: References: <20260710123236.10508-1-fourdollars@debian.org> <20260711093323.14529-1-fourdollars@debian.org> <20260711093323.14529-3-fourdollars@debian.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260711093323.14529-3-fourdollars@debian.org> On Sat, Jul 11, 2026 at 05:33:22PM +0800, Shih-Yuan Lee wrote: > In applesmc_get_entry_by_index(), the cache->valid flag is checked > locklessly, but setting it to true lacks memory barriers. This can lead to > a data race (TOCTOU) where another thread sees cache->valid as true > before the actual cache contents (cache->key, cache->len, cache->type, etc.) > are fully committed and visible to that CPU, potentially causing it to read > uninitialized data and send incorrect keys to the Apple SMC hardware. > > Introduce memory barriers (smp_load_acquire and smp_store_release) with > explanatory comments to ensure cache synchronization is thread-safe and > fully visible across all CPUs. > > Signed-off-by: Shih-Yuan Lee Applied. Thanks, Guenter